Merge branch '6.4' into 7.3

* 6.4:
  [HttpClient] Fix ever growing $maxHostConnections
  Fix typo
  [DependencyInjection] Fix referencing build-time array parameters
  cs fix
  [FrameworkBundle] Fix cache:pool:prune exit code on failure
  [Form] Always normalize CRLF and CR to LF in `TextareaType`
  [Cache] Fix stampede protection when forcing item recomputation
  [Console] Fix EofShortcut instruction when using a modern terminal on Windows
  [Console] Fix choice autocomplete issue when string has spaces
  [Serializer] Fix inconsistent field naming from accessors when using groups
  [Finder] Fix converting unanchored glob patterns to regex

Author: nicolas-grekas

Command/CachePoolPruneCommand.php

@@ -50,14 +50,21 @@ protected function configure(): void
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $io = new SymfonyStyle($input, $output);
+        $exitCode = Command::SUCCESS;
 
         foreach ($this->pools as $name => $pool) {
             $io->comment(\sprintf('Pruning cache pool: <info>%s</info>', $name));
-            $pool->prune();
+
+            if (!$pool->prune()) {
+                $io->error(\sprintf('Cache pool "%s" could not be pruned.', $name));
+                $exitCode = Command::FAILURE;
+            }
         }
 
-        $io->success('Successfully pruned cache pool(s).');
+        if (Command::SUCCESS === $exitCode) {
+            $io->success('Successfully pruned cache pool(s).');
+        }
 
-        return 0;
+        return $exitCode;
     }
 }

Tests/Command/CachePruneCommandTest.php

@@ -35,6 +35,44 @@ public function testCommandWithNoPools()
         $tester->execute([]);
     }
 
+    public function testCommandFailsOnPruneError()
+    {
+        $failedPool = $this->createMock(PruneableInterface::class);
+        $failedPool->expects($this->once())->method('prune')->willReturn(false);
+
+        $generator = new RewindableGenerator(static function () use ($failedPool) {
+            yield 'failed_pool' => $failedPool;
+        }, 1);
+
+        $tester = $this->getCommandTester($this->getKernel(), $generator);
+        $tester->execute([]);
+
+        $this->assertSame(1, $tester->getStatusCode());
+        $this->assertStringContainsString('[ERROR] Cache pool "failed_pool" could not be pruned.', $tester->getDisplay());
+    }
+
+    public function testCommandContinuesOnFailure()
+    {
+        $failedPool = $this->createMock(PruneableInterface::class);
+        $failedPool->expects($this->once())->method('prune')->willReturn(false);
+
+        $successPool = $this->createMock(PruneableInterface::class);
+        $successPool->expects($this->once())->method('prune')->willReturn(true);
+
+        $generator = new RewindableGenerator(static function () use ($failedPool, $successPool) {
+            yield 'failed_pool' => $failedPool;
+            yield 'success_pool' => $successPool;
+        }, 2);
+
+        $tester = $this->getCommandTester($this->getKernel(), $generator);
+        $tester->execute([]);
+
+        $this->assertSame(1, $tester->getStatusCode());
+        $display = $tester->getDisplay();
+        $this->assertStringContainsString('[ERROR] Cache pool "failed_pool" could not be pruned.', $display);
+        $this->assertStringContainsString('Pruning cache pool: success_pool', $display);
+    }
+
     private function getRewindableGenerator(): RewindableGenerator
     {
         return new RewindableGenerator(function () {
@@ -45,7 +83,7 @@ private function getRewindableGenerator(): RewindableGenerator
 
     private function getEmptyRewindableGenerator(): RewindableGenerator
     {
-        return new RewindableGenerator(fn () => new \ArrayIterator([]), 0);
+        return new RewindableGenerator(static fn () => new \ArrayIterator([]), 0);
     }
 
     private function getKernel(): MockObject&KernelInterface