Merge branch '7.4' into 8.0

* 7.4:
  Fix merge
  [WebProfiler] fix the security profiler template
  add tests for bypassed headers
  [Scheduler] Array to string conversion when using AsCronTask with array options
  [Config] Fix merging node that canBeDisable()/canBeEnabled()
  [ObjectMapper] error when multiple targets and no condition

Author: nicolas-grekas

ObjectMapper.php

@@ -60,7 +60,7 @@ public function map(object $source, object|string|null $target = null): object
     private function doMap(object $source, object|string|null $target, \WeakMap $objectMap, bool $rootCall): object
     {
         $metadata = $this->metadataFactory->create($source);
-        $map = $this->getMapTarget($metadata, null, $source, null);
+        $map = $this->getMapTarget($metadata, null, $source, null, null === $target);
         $target ??= $map?->target;
         $mappingToObject = \is_object($target);
 
@@ -82,7 +82,7 @@ private function doMap(object $source, object|string|null $target, \WeakMap $obj
 
         if (!$metadata && $targetMetadata = $this->metadataFactory->create($mappedTarget)) {
             $metadata = $targetMetadata;
-            $map = $this->getMapTarget($metadata, null, $source, null);
+            $map = $this->getMapTarget($metadata, null, $source, null, false);
         }
 
         if ($map && $map->transform) {
@@ -243,7 +243,7 @@ private function getSourceValue(object $source, object $target, mixed $value, \W
         if (
             \is_object($value)
             && ($innerMetadata = $this->metadataFactory->create($value))
-            && ($mapTo = $this->getMapTarget($innerMetadata, $value, $source, $target))
+            && ($mapTo = $this->getMapTarget($innerMetadata, $value, $source, $target, true))
             && (\is_string($mapTo->target) && class_exists($mapTo->target))
         ) {
             $value = $this->applyTransforms($mapTo, $value, $source, $target);
@@ -307,14 +307,18 @@ private function call(callable $fn, mixed $value, object $source, ?object $targe
     /**
      * @param Mapping[] $metadata
      */
-    private function getMapTarget(array $metadata, mixed $value, object $source, ?object $target): ?Mapping
+    private function getMapTarget(array $metadata, mixed $value, object $source, ?object $target, bool $enforceUnique = false): ?Mapping
     {
         $mapTo = null;
         foreach ($metadata as $mapAttribute) {
             if (($if = $mapAttribute->if) && ($fn = $this->getCallable($if, $this->conditionCallableLocator)) && !$this->call($fn, $value, $source, $target)) {
                 continue;
             }
 
+            if ($enforceUnique && null !== $mapTo) {
+                throw new MappingException(\sprintf('Ambiguous mapping for "%s". Multiple #[Map] attributes match. Use the "if" parameter to specify conditions.', get_debug_type($value ?? $source)));
+            }
+
             $mapTo = $mapAttribute;
         }
 

Tests/Fixtures/NestedMapping/NestedSourceA.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace Symfony\Component\ObjectMapper\Tests\Fixtures\NestedMapping;
+
+use Symfony\Component\ObjectMapper\Attribute\Map;
+
+#[Map(target: NestedSourceB::class)]
+class NestedSourceA
+{
+    public function __construct(
+        public string $foo,
+        public string $bar,
+    ) {
+    }
+}

Tests/Fixtures/NestedMapping/NestedSourceB.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Symfony\Component\ObjectMapper\Tests\Fixtures\NestedMapping;
+
+class NestedSourceB
+{
+    public function __construct(
+        public string $foo,
+    ) {
+    }
+}

Tests/Fixtures/NestedMapping/Source.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Symfony\Component\ObjectMapper\Tests\Fixtures\NestedMapping;
+
+class Source
+{
+    public function __construct(
+        public NestedSourceA $item,
+    ) {
+    }
+}

Tests/Fixtures/NestedMapping/TargetUnion.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Symfony\Component\ObjectMapper\Tests\Fixtures\NestedMapping;
+
+class TargetUnion
+{
+    public function __construct(
+        public NestedSourceA|NestedSourceB $item,
+    ) {
+    }
+}

Tests/ObjectMapperTest.php

@@ -669,4 +669,14 @@ public function testMissingSourcePropertiesAreIgnored()
             'Property without default value should remain uninitialized'
         );
     }
+
+    public function testMultipleTargetsWithoutConditionThrowsExceptionWhenNoTargetProvided()
+    {
+        $this->expectException(MappingException::class);
+        $this->expectExceptionMessage('Ambiguous mapping');
+
+        $source = new MultipleTargetPropertyA();
+        $mapper = new ObjectMapper();
+        $mapper->map($source);
+    }
 }