Align Time\Duration with the native implementation

Runs the phpt tests of php-src (php/php-src#23073) unmodified against the
polyfill, and fixes the divergences that are left:

 * use the native ZPP wording for the multiplyBy()/divideBy() argument errors,
   and reject a negative divisor with ValueError instead of DivisionByZeroError
 * detect the nanoseconds overflow of multiplyBy(), which turned into
   "TypeError: ... must be of type int, float given"
 * reject "PT1HS" and "PTS", which the native parser does not accept
 * validate $nanoseconds before the range of $seconds in fromSeconds()
 * report the native range error in fromMinutes()/fromHours()/fromMicroseconds()/
   fromMilliseconds() and when parsing an ISO-8601 duration
 * forbid dynamic properties, as the native readonly class does

The range and the sign of zero durations are now enforced in a single place,
so that no operation can return a Duration that breaks the class invariants.

On the test side, the phpt files are byte-identical to php-src, except
helper.inc which cannot use the syntax of PHP >= 8.5, and new.phpt which is
covered by DurationTest since a userland class cannot reject
ReflectionClass::newInstanceWithoutConstructor(). DurationTest now runs on
PHP >= 8.6 too, so its expectations are checked against the native class.

Also adds the subtree split, moves the classmap entry next to the other 8.6
polyfills and ignores the temporary files written by PhptTest.

Author: nyamsprod

.gitignore

@@ -6,4 +6,6 @@ phpunit.xml
 .phpunit
 vendor/
 /tests/Io/Poll/phpt/*.php
+/tests/Time/phpt/*.php
+/tests/Time/phpt/methods/*.php
 /tests/unicode

README.md

@@ -174,9 +174,9 @@ should **not** `require` the `symfony/polyfill` package, but the standalone ones
 - `symfony/polyfill-intl-normalizer` for using the intl normalizer,
 - `symfony/polyfill-io-poll` for using the `Io\Poll` API and `StreamPollHandle`,
 - `symfony/polyfill-mbstring` for using the mbstring functions,
+- `symfony/polyfill-time` for using the `Time` API,
 - `symfony/polyfill-util` for using the polyfill utility helpers.
 - `symfony/polyfill-uuid` for using the `uuid_*` functions,
-- `symfony/polyfill-time` for using the `Time` API,
 
 Requiring `symfony/polyfill` directly would prevent Composer from sharing
 correctly polyfills in dependency graphs. As such, it would likely install

composer.json

@@ -70,15 +70,15 @@
             "src/Intl/MessageFormatter/Resources/stubs",
             "src/Intl/Normalizer/Resources/stubs",
             "src/Io/Poll/Resources/stubs",
+            "src/Time/Resources/stubs",
             "src/Php86/Resources/stubs",
             "src/Php85/Resources/stubs",
             "src/Php84/Resources/stubs",
             "src/Php83/Resources/stubs",
             "src/Php82/Resources/stubs",
             "src/Php81/Resources/stubs",
             "src/Php80/Resources/stubs",
-            "src/Php73/Resources/stubs",
-            "src/Time/Resources/stubs"
+            "src/Php73/Resources/stubs"
         ]
     },
     "minimum-stability": "dev"

splitsh.json

@@ -20,6 +20,7 @@
         "polyfill-intl-messageformatter": "src/Intl/MessageFormatter",
         "polyfill-intl-normalizer": "src/Intl/Normalizer",
         "polyfill-mbstring": "src/Mbstring",
+        "polyfill-time": "src/Time",
         "polyfill-util": "src/Util",
         "polyfill-uuid": "src/Uuid"
     },

src/Time/README.md

@@ -1,11 +1,22 @@
 Symfony Polyfill / Time
-============================
+=======================
 
 This component provides the [`Time` API](https://wiki.php.net/rfc/duration_class)
 added to PHP 8.6 core, for PHP >= 8.1:
 
 - `Time\TimeException`, `Time\Duration`
 
+The phpt tests of the native implementation, borrowed from php-src, run against
+the polyfill as part of the test suite. Two divergences remain:
+
+- `Duration` is a plain final class with readonly properties instead of a
+  `readonly` class, so `ReflectionClass::newInstanceWithoutConstructor()`
+  succeeds where the native class rejects it; dynamic properties are rejected
+  as they are natively.
+- On 32-bit platforms, operations whose intermediate values do not fit in an
+  integer throw `Time\TimeException` instead of returning the in-range result
+  the native implementation computes with 64-bit arithmetic.
+
 More information can be found in the
 [main Polyfill README](https://github.com/symfony/polyfill/blob/main/README.md).