Merge branch '5.4' into 6.2

* 5.4:
  Migrate to `static` data providers using `rector/rector`

Author: nicolas-grekas

Tests/PropertyAccessorTest.php

@@ -49,7 +49,7 @@ protected function setUp(): void
         $this->propertyAccessor = new PropertyAccessor();
     }
 
-    public function getPathsWithMissingProperty()
+    public static function getPathsWithMissingProperty()
     {
         return [
             [(object) ['firstName' => 'Bernhard'], 'lastName'],
@@ -69,7 +69,7 @@ public function getPathsWithMissingProperty()
         ];
     }
 
-    public function getPathsWithMissingIndex()
+    public static function getPathsWithMissingIndex()
     {
         return [
             [['firstName' => 'Bernhard'], '[lastName]'],
@@ -515,7 +515,7 @@ public function testIsWritableRecognizesMagicCallIfEnabled()
         $this->assertTrue($this->propertyAccessor->isWritable(new TestClassMagicCall('Bernhard'), 'magicCallProperty'));
     }
 
-    public function getValidWritePropertyPaths()
+    public static function getValidWritePropertyPaths()
     {
         return [
             [['Bernhard', 'Schussek'], '[0]', 'Bernhard'],
@@ -561,9 +561,9 @@ public function getValidWritePropertyPaths()
         ];
     }
 
-    public function getValidReadPropertyPaths(): iterable
+    public static function getValidReadPropertyPaths(): iterable
     {
-        yield from $this->getValidWritePropertyPaths();
+        yield from self::getValidWritePropertyPaths();
 
         // Optional paths can only be read and can't be written to.
         yield [(object) [], 'foo?', null];
@@ -596,7 +596,7 @@ public function testSetValueDeepWithMagicGetter()
         $this->assertSame('Updated', $obj->publicProperty['foo']['bar']);
     }
 
-    public function getReferenceChainObjectsForSetValue()
+    public static function getReferenceChainObjectsForSetValue()
     {
         return [
             [['a' => ['b' => ['c' => 'old-value']]], '[a][b][c]', 'new-value'],
@@ -617,7 +617,7 @@ public function testSetValueForReferenceChainIssue($object, $path, $value)
         $this->assertEquals($value, $this->propertyAccessor->getValue($object, $path));
     }
 
-    public function getReferenceChainObjectsForIsWritable()
+    public static function getReferenceChainObjectsForIsWritable()
     {
         return [
             [new TestClassIsWritable(['a' => ['b' => 'old-value']]), 'value[a][b]', false],

Tests/PropertyPathBuilderTest.php

@@ -194,7 +194,7 @@ public function testReplaceDoesNotAllowInvalidOffsets($offset)
         $this->builder->replace($offset, 1, new PropertyPath('new1[new2].new3'));
     }
 
-    public function provideInvalidOffsets()
+    public static function provideInvalidOffsets()
     {
         return [
             [6],

Tests/PropertyPathTest.php

@@ -36,7 +36,7 @@ public function testDotCannotBePresentAtTheBeginning()
         new PropertyPath('.property');
     }
 
-    public function providePathsContainingUnexpectedCharacters()
+    public static function providePathsContainingUnexpectedCharacters()
     {
         return [
             ['property.'],