Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Translator] Cache is not warmed anymore #2056

Closed
MatTheCat opened this issue Aug 13, 2024 · 0 comments · Fixed by #2060 · May be fixed by #2061
Closed

[Translator] Cache is not warmed anymore #2056

MatTheCat opened this issue Aug 13, 2024 · 0 comments · Fixed by #2060 · May be fixed by #2061
Labels
Bug Bug Fix Status: Needs Review Needs to be reviewed Translator

Comments

@MatTheCat
Copy link
Contributor

MatTheCat commented Aug 13, 2024 •
edited
Loading

Upgrading symfony/ux-translator to v2.19.0 (and running Symfony 6.4.10), we noticed that the var/translations folder and its content was not generated anymore.

The culprit seems to be #1965: our translator service is an alias of translation.default, so TranslatorCompilerPass::hasValidTranslator returns false because ContainerBuilder::hasDefinition does not check aliases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Bug Fix Status: Needs Review Needs to be reviewed Translator
Projects
None yet
Milestone
No milestone
3 participants
@smnandre @MatTheCat @carsonbot