Merge branch '7.4' into 8.0

* 7.4: (22 commits)
  Fix Warning: curl_multi_select(): timeout must be positive
  [PropertyInfo] Fix ReflectionExtractor handling of underscore-only property names
  ObjectNormalizer: allow null and scalar
  [Security] Fix `HttpUtils::createRequest()` when the context’s base URL isn’t empty
  [Serializer] fix Inherited properties normalization
  [OptionsResolver] Fix missing prototype key in nested error paths
  Bump Symfony version to 7.3.8
  Update VERSION for 7.3.7
  Update CHANGELOG for 7.3.7
  Bump Symfony version to 6.4.30
  Update VERSION for 6.4.29
  Update CHANGELOG for 6.4.29
  [FrameworkBundle] Update deprecation message for collect_serializer_data
  run test using a read-only directory on Windows too
  [Yaml] Fix parsing of unquoted multiline scalars with comments or blank lines
  [Clock] Align MockClock::sleep() behavior with NativeClock for negative values
  [OptionsResolver] Ensure remove() also unsets deprecation status
  Remove review state for Belarusian translations (entries 141 and 142)
  [ExpressionLanguage] Compile numbers with var_export in Compiler::repr for thread-safety
  compatibility with ext-redis 6.3
  ...

Author: xabbuh

Parser.php

@@ -769,13 +769,22 @@ private function parseValue(string $value, int $flags, string $context): mixed
                     $lines = [];
 
                     while ($this->moveToNextLine()) {
+                        if ($this->isCurrentLineBlank()) {
+                            $lines[] = '';
+                            continue;
+                        }
+
                         // unquoted strings end before the first unindented line
                         if (0 === $this->getCurrentLineIndentation()) {
                             $this->moveToPreviousLine();
 
                             break;
                         }
 
+                        if ($this->isCurrentLineComment()) {
+                            continue;
+                        }
+
                         $lines[] = trim($this->currentLine);
                     }
 

Tests/ParserTest.php

@@ -1756,6 +1756,71 @@ public function testParseMultiLineUnquotedString()
         $this->assertSame(['foo' => 'bar baz foobar foo', 'bar' => 'baz'], $this->parser->parse($yaml));
     }
 
+    #[DataProvider('unquotedStringWithTrailingComment')]
+    public function testUnquotedMultilineScalarIgnoresComments(string $yaml, array $expected)
+    {
+        $this->assertSame($expected, $this->parser->parse($yaml));
+    }
+
+    public static function getUnquotedMultilineScalarIgnoresCommentsData()
+    {
+        yield 'comments interspersed' => [
+            <<<YAML
+                key: unquoted
+                  # this comment should be ignored
+                  next line
+                  # another comment
+                  final line
+                another_key: works
+                YAML,
+            [
+                'key' => 'unquoted next line final line',
+                'another_key' => 'works',
+            ],
+        ];
+
+        yield 'only comments' => [
+            <<<YAML
+                key: unquoted
+                  # this comment should be ignored
+                  # another comment
+                another_key: works
+                YAML,
+            [
+                'key' => 'unquoted',
+                'another_key' => 'works',
+            ],
+        ];
+
+        yield 'blank lines and comments' => [
+            <<<YAML
+                key: unquoted
+                  next line
+
+                  # this comment should be ignored
+                  final line
+                another_key: works
+                YAML,
+            [
+                'key' => "unquoted next line\nfinal line",
+                'another_key' => 'works',
+            ],
+        ];
+
+        yield 'comment at end' => [
+            <<<YAML
+                key: unquoted
+                  next line
+                  # comment at end
+                another_key: works
+                YAML,
+            [
+                'key' => 'unquoted next line',
+                'another_key' => 'works',
+            ],
+        ];
+    }
+
     #[DataProvider('unquotedStringWithTrailingComment')]
     public function testParseMultiLineUnquotedStringWithTrailingComment(string $yaml, array $expected)
     {