Skip to content

Commit 9741edf

Browse files
[SymForce-External] Set min version of lazy-object-proxy to 1.9.0
Set min version of lazy-object-proxy to 1.9.0 This is because lazy-object-proxy does not have built wheels on pypa for linux on version 1.8.0, and for some reason running it's setup.py can fail when done locally. Also, for some reason, a pre-built wheel for the same package is not available for python3.11 on bionic (even for version 1.9.0). Note, lazy-object-proxy can be built on pip 22.3.1 (but not on the current latest, 23.0.0). Suspect this is a bug on pip's end, but if not, then it's probably a bug on lazy-object-proxy's end. Anyway, because we don't want to contort our code around other package's problems, I am just removing the python3.11 on bionic tests. If for some reason you do need build on python3.11 on bionic, just set your pip version to 22.3.1 then try again. Should work (not just for this pair but more generally). Topic: get_CI_workflow_passing_again Closes #296 GitOrigin-RevId: 33a9d4a7475f0aea7e77886ef14a481a1aa64b21
1 parent ab1c621 commit 9741edf

File tree

3 files changed

+15
-2
lines changed

3 files changed

+15
-2
lines changed

.github/workflows/ci.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,15 @@ jobs:
2121
- C: gcc-11
2222
CXX: g++-11
2323
repos: ['"ppa:ubuntu-toolchain-r/test"']
24+
exclude:
25+
# NOTE(brad): No available pre-built wheel for lazy-object-proxy==1.9.0 for this
26+
# combination. Local-build fails on pip 23.0.0, so we skip the test. Root cause of issue
27+
# seems to come from https://github.com/pypa/pip/pull/11598, as
28+
# sysconfig.get_paths(vars=vars, scheme="venv") gives the wrong paths. To build anyway,
29+
# either modify pip to not take "venv" path, or just use pip 22.3.1 (version before this
30+
# was added).
31+
- os: ubuntu-18.04
32+
python: python3.11
2433
include:
2534
# gcc 5
2635
- os: ubuntu-18.04

dev_requirements.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,10 @@ jupyterlab-pygments==0.2.2
131131
# via nbconvert
132132
kiwisolver==1.4.4
133133
# via matplotlib
134-
lazy-object-proxy==1.8.0
135-
# via astroid
134+
lazy-object-proxy==1.9.0
135+
# via
136+
# astroid
137+
# symforce (setup.py)
136138
llvmlite==0.39.1 ; python_version < "3.11"
137139
# via
138140
# numba

setup.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -491,6 +491,8 @@ def fixed_readme() -> str:
491491
"pip-tools<6.11",
492492
"pybind11-stubgen",
493493
"pylint",
494+
# NOTE(brad): A transitive dependency of pylint. Added here only to pin the version.
495+
"lazy-object-proxy>=1.9.0",
494496
"types-jinja2",
495497
"types-pygments",
496498
"types-requests",

0 commit comments

Comments
 (0)