Skip to content

Commit c318124

Browse files
committed
[SymForce] Fix macos wheels
Tested here: - https://github.com/aaron-skydio/symforce/actions/runs/14543998013 - https://github.com/aaron-skydio/symforce/actions/runs/14543998018 - https://github.com/aaron-skydio/symforce/actions/runs/14543998022 The macos-13 runner is an Intel runner, so this was all wrong, in particular the copy of gmp was x86, so the symengine library wasn't importable. Topic: sf-fix-macos-wheels GitOrigin-RevId: 2ac83edecb18174b9f398a52a3df8d4362a4e0f3
1 parent 13a5612 commit c318124

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

.github/workflows/build_wheels.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,14 @@ jobs:
3131
path: dist/*
3232

3333
build-macos:
34-
# This is macos 13 instead of newer, because brew won't pull libgmp for an older macos, so we
35-
# just support 13 or newer
36-
runs-on: macos-13
34+
runs-on: macos-${{ matrix.os.version }}
3735
strategy:
3836
fail-fast: false
3937
matrix:
4038
os:
41-
- runner: macos-13
39+
- version: 13
4240
arch: x86_64
43-
- runner: macos-13
41+
- version: 14
4442
arch: arm64
4543
python-version: [cp38, cp39, cp310, cp311, cp312]
4644

@@ -52,8 +50,11 @@ jobs:
5250
fetch-depth: 300
5351
fetch-tags: true
5452

55-
- run: python3 -m pip install setuptools_scm
56-
- run: echo "SYMFORCE_VERSION=$(python3 -m setuptools_scm)" | tee $GITHUB_ENV
53+
- uses: actions/setup-python@v5
54+
with:
55+
python-version: '3.12'
56+
- run: pip install setuptools_scm
57+
- run: echo "SYMFORCE_VERSION=$(python -m setuptools_scm)" | tee $GITHUB_ENV
5758

5859
- name: Build wheels
5960
uses: pypa/[email protected]
@@ -63,7 +64,7 @@ jobs:
6364
CIBW_BUILD_FRONTEND: build
6465
# For arm64; for x86, it's at /usr/local but cmake finds that ok already
6566
GMP_ROOT: /opt/homebrew
66-
CIBW_ENVIRONMENT: SYMFORCE_REWRITE_LOCAL_DEPENDENCIES=$SYMFORCE_VERSION MACOSX_DEPLOYMENT_TARGET=13.0
67+
CIBW_ENVIRONMENT: SYMFORCE_REWRITE_LOCAL_DEPENDENCIES=$SYMFORCE_VERSION MACOSX_DEPLOYMENT_TARGET=${{ matrix.os.version }}.0
6768

6869
- name: Upload wheels
6970
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)