Skip to content

Commit 42dfc9c

Browse files
authored
CI: Disable flaky std.experimental.allocator.building_blocks.allocator_list unittests altogether (ldc-developers#5086)
While they seem to more frequently fail on FreeBSD, macOS and musl, they can fail in general, on all platforms (at least glibc Linux too), according to dlang/phobos#10876 (comment). I'm not sure if I've ever seen them fail on Windows; skip the unittests there too, just in case; that module is clearly still experimental indeed.
1 parent 923b082 commit 42dfc9c

4 files changed

Lines changed: 20 additions & 17 deletions

File tree

.circleci/config.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,13 @@ commonSteps: &commonSteps
9191
- run:
9292
name: Run defaultlib unittests & druntime integration tests
9393
when: always
94-
command: cd ../build && ctest -j$PARALLELISM --output-on-failure -E "dmd-testsuite|ldc2-unittest|lit-tests" --timeout 120
94+
command: |
95+
set -ux
96+
excludes='dmd-testsuite|lit-tests|ldc2-unittest'
97+
# FIXME: https://github.com/dlang/phobos/issues/10730
98+
excludes+='|^std.experimental.allocator.building_blocks.allocator_list'
99+
cd ../build
100+
ctest -j$PARALLELISM --output-on-failure -E "$excludes" --timeout 120
95101
96102
version: 2
97103
jobs:

.cirrus.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,9 @@ common_steps_template: &COMMON_STEPS_TEMPLATE
4949
run_defaultlib_tests_script: |
5050
# Run defaultlib unittests & druntime integration tests
5151
cd $CIRRUS_WORKING_DIR/../build
52-
excludes="dmd-testsuite|lit-tests|ldc2-unittest"
53-
if [[ "$CI_OS" == "freebsd" ]]; then
54-
# FIXME: https://github.com/dlang/phobos/issues/10730
55-
excludes+='|^std.experimental.allocator.building_blocks.allocator_list'
56-
fi
52+
excludes='dmd-testsuite|lit-tests|ldc2-unittest'
53+
# FIXME: https://github.com/dlang/phobos/issues/10730
54+
excludes+='|^std.experimental.allocator.building_blocks.allocator_list'
5755
ctest -j$PARALLELISM --output-on-failure -E "$excludes" --timeout 120
5856
5957
# Performs the extra packaging steps for jobs producing a prebuilt package.

.github/actions/4d-test-libs/action.yml

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,18 @@ runs:
1818
N=$(nproc)
1919
fi
2020
21-
excludes="dmd-testsuite|lit-tests|ldc2-unittest"
21+
excludes='dmd-testsuite|lit-tests|ldc2-unittest'
22+
# FIXME: https://github.com/dlang/phobos/issues/10730
23+
excludes+='|^std.experimental.allocator.building_blocks.allocator_list'
2224
if [[ '${{ runner.os }}-${{ inputs.arch }}' == Linux-aarch64 ]]; then
2325
if type -P apk &>/dev/null; then
2426
# FIXME: empty exception backtraces on musl AArch64 with enabled optimizations
2527
excludes+='|^druntime-test-exceptions-release$'
2628
fi
2729
fi
28-
if [[ '${{ runner.os }}' == macOS ]]; then
29-
# FIXME: https://github.com/dlang/phobos/issues/10730
30-
excludes+='|^std.experimental.allocator.building_blocks.allocator_list'
31-
if [[ '${{ inputs.arch }}' == x86_64 ]]; then
32-
# FIXME: regressed with image bump from macos-13 to macos-15-intel, apparently wrt. getpwnam_r() setting unexpected errno
33-
excludes+='|^std.path'
34-
fi
30+
if [[ '${{ runner.os }}-${{ inputs.arch }}' == macOS-x86_64 ]]; then
31+
# FIXME: regressed with image bump from macos-13 to macos-15-intel, apparently wrt. getpwnam_r() setting unexpected errno
32+
excludes+='|^std.path'
3533
fi
3634
3735
ctest -j$N --output-on-failure -E "$excludes" --timeout 120
@@ -50,4 +48,5 @@ runs:
5048
call "%LDC_VSDIR%\Common7\Tools\VsDevCmd.bat" -arch=${{ matrix.arch }} || exit /b
5149
echo on
5250
cd build || exit /b
53-
ctest -j4 --output-on-failure -E "dmd-testsuite|lit-tests|ldc2-unittest" --timeout 120 || exit /b
51+
# FIXME: https://github.com/dlang/phobos/issues/10730
52+
ctest -j4 --output-on-failure -E "dmd-testsuite|lit-tests|ldc2-unittest|^std.experimental.allocator.building_blocks.allocator_list" --timeout 120 || exit /b

.github/workflows/supported_llvm_versions.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,10 +164,10 @@ jobs:
164164
run: |
165165
set -eux
166166
excludes='dmd-testsuite|lit-tests|ldc2-unittest'
167+
# FIXME: https://github.com/dlang/phobos/issues/10730
168+
excludes+='|^std.experimental.allocator.building_blocks.allocator_list'
167169
if [[ '${{ runner.os }}' == macOS ]]; then
168170
N=$(sysctl -n hw.logicalcpu)
169-
# FIXME: https://github.com/dlang/phobos/issues/10730
170-
excludes+='|^std.experimental.allocator.building_blocks.allocator_list'
171171
else
172172
N=$(nproc)
173173
fi

0 commit comments

Comments
 (0)