code coverage updates

Author: TheTechsTech

Http/RequestCookies.php

@@ -32,10 +32,6 @@ public static function set(RequestInterface $request, Cookie $cookie) : RequestI
 
     public static function modify(RequestInterface $request, string $name, callable $modify) : RequestInterface
     {
-        if (! \is_callable($modify)) {
-            throw new \InvalidArgumentException('$modify must be callable.');
-        }
-
         $cookies = Cookies::fromRequest($request);
         $cookie  = $modify($cookies->has($name)
             ? $cookies->get($name)

Http/ResponseCookies.php

@@ -37,10 +37,6 @@ public static function expire(ResponseInterface $response, string $cookieName) :
 
     public static function modify(ResponseInterface $response, string $name, callable $modify) : ResponseInterface
     {
-        if (! \is_callable($modify)) {
-            throw new \InvalidArgumentException('$modify must be callable.');
-        }
-
         $setCookies = SetCookies::fromResponse($response);
         $setCookie  = $modify($setCookies->has($name)
             ? $setCookies->get($name)

tests/ResponseCookiesTest.php

@@ -10,10 +10,7 @@
 
 class ResponseCookiesTest extends TestCase
 {
-    /**
-     * @test
-     */
-    public function it_gets_cookies() : void
+    public function testGet() : void
     {
         $response = (new Response());
 
@@ -23,16 +20,46 @@ public function it_gets_cookies() : void
             ->withAddedHeader(SetCookies::SET_COOKIE_HEADER, SetCookie::create('hello', 'world'))
         ;
 
-        self::assertEquals(
+        $this->assertEquals(
             'ENCRYPTED',
             ResponseCookies::get($response, 'sessionToken')->getValue()
         );
     }
 
-    /**
-     * @test
-     */
-    public function it_sets_cookies() : void
+    public function testGetNull() : void
+    {
+        $response = (new Response());
+
+        $response = $response
+            ->withAddedHeader(SetCookies::SET_COOKIE_HEADER, SetCookie::create('theme', 'light'))
+            ->withAddedHeader(SetCookies::SET_COOKIE_HEADER, SetCookie::create('hello', 'world'))
+        ;
+
+        $this->assertEquals(
+            'ENCRYPTED',
+            ResponseCookies::get($response, 'sessionToken', 'ENCRYPTED')->getValue()
+        );
+    }
+
+    public function testExpire() : void
+    {
+        $response = (new Response());
+
+        $response = $response
+            ->withAddedHeader(SetCookies::SET_COOKIE_HEADER, SetCookie::create('theme', 'light'))
+            ->withAddedHeader(SetCookies::SET_COOKIE_HEADER, SetCookie::create('sessionToken', 'ENCRYPTED'))
+            ->withAddedHeader(SetCookies::SET_COOKIE_HEADER, SetCookie::create('hello', 'world'))
+        ;
+
+        $response = ResponseCookies::expire($response, 'sessionToken');
+
+        $this->assertEquals(
+            '',
+            ResponseCookies::get($response, 'sessionToken')->getValue()
+        );
+    }
+
+    public function testSet() : void
     {
         $response = (new Response());
 
@@ -44,16 +71,13 @@ public function it_sets_cookies() : void
 
         $response = ResponseCookies::set($response, SetCookie::create('hello', 'WORLD!'));
 
-        self::assertEquals(
+        $this->assertEquals(
             'theme=light,sessionToken=ENCRYPTED,hello=WORLD%21',
             $response->getHeaderLine('Set-Cookie')
         );
     }
 
-    /**
-     * @test
-     */
-    public function it_modifies_cookies() : void
+    public function testModify() : void
     {
         $response = (new Response());
 
@@ -67,16 +91,13 @@ public function it_modifies_cookies() : void
             return $setCookie->withValue(strtoupper($setCookie->getName()));
         });
 
-        self::assertEquals(
+        $this->assertEquals(
             'theme=light,sessionToken=ENCRYPTED,hello=HELLO',
             $response->getHeaderLine('Set-Cookie')
         );
     }
 
-    /**
-     * @test
-     */
-    public function it_removes_cookies() : void
+    public function testRemove() : void
     {
         $response = (new Response());
 
@@ -88,7 +109,7 @@ public function it_removes_cookies() : void
 
         $response = ResponseCookies::remove($response, 'sessionToken');
 
-        self::assertEquals(
+        $this->assertEquals(
             'theme=light,hello=world',
             $response->getHeaderLine('Set-Cookie')
         );