Skip to content

Commit b04cb44

Browse files
committed
Revert useless distribution aliases in gRPC framer tests
These test files import only the distribution package; the gRPC child lives in the separate suite file, so there is no in-file conflict and no alias is needed. The mock tests keep their aliases since they import both packages in one file.
1 parent a763ed4 commit b04cb44

4 files changed

Lines changed: 28 additions & 28 deletions

File tree

core/pkg/distribution/transport/grpc/framer/deleter/transport_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,22 @@ import (
1818
. "github.com/onsi/gomega"
1919
"github.com/synnaxlabs/freighter"
2020
"github.com/synnaxlabs/synnax/pkg/distribution/channel"
21-
distdeleter "github.com/synnaxlabs/synnax/pkg/distribution/framer/deleter"
21+
"github.com/synnaxlabs/synnax/pkg/distribution/framer/deleter"
2222
)
2323

2424
var _ = Describe("Transport", func() {
2525
It("Should round-trip a delete request over the wire", func(ctx SpecContext) {
26-
var received distdeleter.Request
26+
var received deleter.Request
2727
transport.Server().BindHandler(
28-
func(_ context.Context, req distdeleter.Request) (types.Nil, error) {
28+
func(_ context.Context, req deleter.Request) (types.Nil, error) {
2929
received = req
3030
return types.Nil{}, nil
3131
},
3232
)
3333
Expect(transport.Client().Send(
3434
ctx,
3535
addr,
36-
distdeleter.Request{Keys: channel.Keys{1, 2, 3}},
36+
deleter.Request{Keys: channel.Keys{1, 2, 3}},
3737
)).To(Equal(types.Nil{}))
3838
Expect(received.Keys).To(Equal(channel.Keys{1, 2, 3}))
3939
})
@@ -59,14 +59,14 @@ var _ = Describe("Transport", func() {
5959
return next(mCtx)
6060
}))
6161
transport.Server().BindHandler(
62-
func(_ context.Context, _ distdeleter.Request) (types.Nil, error) {
62+
func(_ context.Context, _ deleter.Request) (types.Nil, error) {
6363
return types.Nil{}, nil
6464
},
6565
)
6666
Expect(transport.Client().Send(
6767
ctx,
6868
addr,
69-
distdeleter.Request{Keys: channel.Keys{1}},
69+
deleter.Request{Keys: channel.Keys{1}},
7070
)).To(Equal(types.Nil{}))
7171
Expect(clientCalls.Load()).To(Equal(int32(1)))
7272
Expect(serverCalls.Load()).To(Equal(int32(1)))

core/pkg/distribution/transport/grpc/framer/iterator/transport_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,24 @@ import (
1616
. "github.com/onsi/ginkgo/v2"
1717
. "github.com/onsi/gomega"
1818
"github.com/synnaxlabs/freighter"
19-
distiterator "github.com/synnaxlabs/synnax/pkg/distribution/framer/iterator"
19+
"github.com/synnaxlabs/synnax/pkg/distribution/framer/iterator"
2020
. "github.com/synnaxlabs/x/testutil"
2121
)
2222

2323
var _ = Describe("Transport", func() {
2424
It("Should round-trip a request over the wire", func(ctx SpecContext) {
2525
transport.Server().BindHandler(func(
2626
_ context.Context,
27-
srv freighter.ServerStream[distiterator.Request, distiterator.Response],
27+
srv freighter.ServerStream[iterator.Request, iterator.Response],
2828
) error {
2929
req, err := srv.Receive()
3030
if err != nil {
3131
return err
3232
}
33-
return srv.Send(distiterator.Response{SeqNum: req.SeqNum})
33+
return srv.Send(iterator.Response{SeqNum: req.SeqNum})
3434
})
3535
stream := MustSucceed(transport.Client().Stream(ctx, addr))
36-
Expect(stream.Send(distiterator.Request{SeqNum: 42})).To(Succeed())
36+
Expect(stream.Send(iterator.Request{SeqNum: 42})).To(Succeed())
3737
Expect(MustSucceed(stream.Receive()).SeqNum).To(Equal(42))
3838
Expect(stream.CloseSend()).To(Succeed())
3939
})
@@ -60,15 +60,15 @@ var _ = Describe("Transport", func() {
6060
}))
6161
transport.Server().BindHandler(func(
6262
_ context.Context,
63-
srv freighter.ServerStream[distiterator.Request, distiterator.Response],
63+
srv freighter.ServerStream[iterator.Request, iterator.Response],
6464
) error {
6565
if _, err := srv.Receive(); err != nil {
6666
return err
6767
}
68-
return srv.Send(distiterator.Response{})
68+
return srv.Send(iterator.Response{})
6969
})
7070
stream := MustSucceed(transport.Client().Stream(ctx, addr))
71-
Expect(stream.Send(distiterator.Request{SeqNum: 1})).To(Succeed())
71+
Expect(stream.Send(iterator.Request{SeqNum: 1})).To(Succeed())
7272
MustSucceed(stream.Receive())
7373
Expect(stream.CloseSend()).To(Succeed())
7474
Expect(clientCalls.Load()).To(Equal(int32(1)))

core/pkg/distribution/transport/grpc/framer/relay/transport_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,23 @@ import (
1717
. "github.com/onsi/gomega"
1818
"github.com/synnaxlabs/freighter"
1919
"github.com/synnaxlabs/synnax/pkg/distribution/channel"
20-
distrelay "github.com/synnaxlabs/synnax/pkg/distribution/framer/relay"
20+
"github.com/synnaxlabs/synnax/pkg/distribution/framer/relay"
2121
. "github.com/synnaxlabs/x/testutil"
2222
)
2323

2424
var _ = Describe("Transport", func() {
2525
It("Should round-trip a request over the wire", func(ctx SpecContext) {
2626
transport.Server().BindHandler(func(
2727
_ context.Context,
28-
srv freighter.ServerStream[distrelay.Request, distrelay.Response],
28+
srv freighter.ServerStream[relay.Request, relay.Response],
2929
) error {
3030
if _, err := srv.Receive(); err != nil {
3131
return err
3232
}
33-
return srv.Send(distrelay.Response{Group: 7})
33+
return srv.Send(relay.Response{Group: 7})
3434
})
3535
stream := MustSucceed(transport.Client().Stream(ctx, addr))
36-
Expect(stream.Send(distrelay.Request{Keys: channel.Keys{1, 2}})).To(Succeed())
36+
Expect(stream.Send(relay.Request{Keys: channel.Keys{1, 2}})).To(Succeed())
3737
Expect(MustSucceed(stream.Receive()).Group).To(Equal(uint32(7)))
3838
Expect(stream.CloseSend()).To(Succeed())
3939
})
@@ -60,15 +60,15 @@ var _ = Describe("Transport", func() {
6060
}))
6161
transport.Server().BindHandler(func(
6262
_ context.Context,
63-
srv freighter.ServerStream[distrelay.Request, distrelay.Response],
63+
srv freighter.ServerStream[relay.Request, relay.Response],
6464
) error {
6565
if _, err := srv.Receive(); err != nil {
6666
return err
6767
}
68-
return srv.Send(distrelay.Response{})
68+
return srv.Send(relay.Response{})
6969
})
7070
stream := MustSucceed(transport.Client().Stream(ctx, addr))
71-
Expect(stream.Send(distrelay.Request{})).To(Succeed())
71+
Expect(stream.Send(relay.Request{})).To(Succeed())
7272
MustSucceed(stream.Receive())
7373
Expect(stream.CloseSend()).To(Succeed())
7474
Expect(clientCalls.Load()).To(Equal(int32(1)))

core/pkg/distribution/transport/grpc/framer/writer/transport_test.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,27 +16,27 @@ import (
1616
. "github.com/onsi/ginkgo/v2"
1717
. "github.com/onsi/gomega"
1818
"github.com/synnaxlabs/freighter"
19-
distwriter "github.com/synnaxlabs/synnax/pkg/distribution/framer/writer"
19+
"github.com/synnaxlabs/synnax/pkg/distribution/framer/writer"
2020
. "github.com/synnaxlabs/x/testutil"
2121
)
2222

2323
var _ = Describe("Transport", func() {
2424
It("Should round-trip a request over the wire", func(ctx SpecContext) {
2525
transport.Server().BindHandler(func(
2626
_ context.Context,
27-
srv freighter.ServerStream[distwriter.Request, distwriter.Response],
27+
srv freighter.ServerStream[writer.Request, writer.Response],
2828
) error {
2929
req, err := srv.Receive()
3030
if err != nil {
3131
return err
3232
}
33-
return srv.Send(distwriter.Response{SeqNum: 42, Command: req.Command})
33+
return srv.Send(writer.Response{SeqNum: 42, Command: req.Command})
3434
})
3535
stream := MustSucceed(transport.Client().Stream(ctx, addr))
36-
Expect(stream.Send(distwriter.Request{Command: distwriter.CommandWrite})).To(Succeed())
36+
Expect(stream.Send(writer.Request{Command: writer.CommandWrite})).To(Succeed())
3737
res := MustSucceed(stream.Receive())
3838
Expect(res.SeqNum).To(Equal(42))
39-
Expect(res.Command).To(Equal(distwriter.CommandWrite))
39+
Expect(res.Command).To(Equal(writer.CommandWrite))
4040
Expect(stream.CloseSend()).To(Succeed())
4141
})
4242

@@ -62,15 +62,15 @@ var _ = Describe("Transport", func() {
6262
}))
6363
transport.Server().BindHandler(func(
6464
_ context.Context,
65-
srv freighter.ServerStream[distwriter.Request, distwriter.Response],
65+
srv freighter.ServerStream[writer.Request, writer.Response],
6666
) error {
6767
if _, err := srv.Receive(); err != nil {
6868
return err
6969
}
70-
return srv.Send(distwriter.Response{})
70+
return srv.Send(writer.Response{})
7171
})
7272
stream := MustSucceed(transport.Client().Stream(ctx, addr))
73-
Expect(stream.Send(distwriter.Request{Command: distwriter.CommandWrite})).To(Succeed())
73+
Expect(stream.Send(writer.Request{Command: writer.CommandWrite})).To(Succeed())
7474
MustSucceed(stream.Receive())
7575
Expect(stream.CloseSend()).To(Succeed())
7676
Expect(clientCalls.Load()).To(Equal(int32(1)))

0 commit comments

Comments
 (0)