Fix thread creation failures showing as successfully delivered

Author: synzen

services/backend-api/client/src/features/feed/components/UserFeedLogs/DeliveryHistory/index.tsx

@@ -275,19 +275,21 @@ export const DeliveryHistory = () => {
                           </Td>
                           <Td>
                             <Skeleton isLoaded={fetchStatus === "idle"}>
-                              {item.details?.message}
-                              {item.details?.data && (
-                                <Button
-                                  leftIcon={<Search2Icon />}
-                                  size="xs"
-                                  variant="outline"
-                                  onClick={() =>
-                                    setDetailsData(JSON.stringify(item.details?.data, null, 2))
-                                  }
-                                >
-                                  View Details
-                                </Button>
-                              )}
+                              <HStack>
+                                <span>{item.details?.message}</span>
+                                {item.details?.data && (
+                                  <Button
+                                    leftIcon={<Search2Icon />}
+                                    size="xs"
+                                    variant="outline"
+                                    onClick={() =>
+                                      setDetailsData(JSON.stringify(item.details?.data, null, 2))
+                                    }
+                                  >
+                                    View Details
+                                  </Button>
+                                )}
+                              </HStack>
                             </Skeleton>
                           </Td>
                         </Tr>

services/user-feeds/src/delivery-record/delivery-record.service.ts

@@ -301,6 +301,12 @@ export class DeliveryRecordService {
           record.error_code === ArticleDeliveryErrorCode.ThirdPartyBadRequest
         ) {
           details.message = "Invalid message format";
+
+          try {
+            if (record.external_detail) {
+              details.data = JSON.parse(record.external_detail);
+            }
+          } catch (err) {}
         } else if (
           record.error_code === ArticleDeliveryErrorCode.ThirdPartyForbidden
         ) {

services/user-feeds/src/delivery/mediums/discord-medium.service.ts

@@ -636,9 +636,9 @@ export class DiscordMediumService implements DeliveryMedium {
       body: threadBody,
     });
 
-    if (!res.success) {
+    if (!res.success || res.status >= 300 || res.status < 200) {
       throw new Error(
-        `Failed to create initial thread for webhok forum ${webhookId}: ${
+        `Failed to create initial thread for webhook forum ${webhookId}: ${
           res.detail
         }. Body: ${JSON.stringify(res.body)}`
       );
@@ -759,7 +759,7 @@ export class DiscordMediumService implements DeliveryMedium {
         ArticleDeliveryContentType.DiscordThreadCreation
       );
 
-    if (!res.success) {
+    if (!res.success || res.status >= 300 || res.status < 200) {
       return threadCreationDeliveryStates;
     }
 
@@ -1115,6 +1115,12 @@ export class DiscordMediumService implements DeliveryMedium {
     contentType: ArticleDeliveryContentType
   ): ArticleDeliveryState[] {
     if (!response.success) {
+      throw new Error(
+        `Failed to create thread for medium ${details.mediumId}: ${
+          response.detail
+        }. Body: ${JSON.stringify(response.body)}`
+      );
+    } else {
       if (response.status === 404) {
         return [
           {
@@ -1158,14 +1164,20 @@ export class DiscordMediumService implements DeliveryMedium {
             article,
           },
         ];
-      } else {
-        throw new Error(
-          `Failed to create thread for medium ${details.mediumId}: ${
-            response.detail
-          }. Body: ${JSON.stringify(response.body)}`
-        );
+      } else if (response.status > 300 || response.status < 200) {
+        return [
+          {
+            id: generateDeliveryId(),
+            status: ArticleDeliveryStatus.Failed,
+            mediumId: details.mediumId,
+            articleIdHash: article.flattened.idHash,
+            errorCode: ArticleDeliveryErrorCode.ThirdPartyBadRequest,
+            internalMessage: `Response: ${JSON.stringify(response.body)}`,
+            article,
+          },
+        ];
       }
-    } else {
+
       return [
         {
           id: generateDeliveryId(),