chore: remove github warnings (#686)

Author: lucaslovato

source/routers/index.tsx

@@ -1,4 +1,4 @@
-import React, { useEffect } from 'react';
+import React from 'react';
 import { Routes, Route, Navigate } from 'react-router-dom';
 
 import {

source/scripts/Background/controllers/message-handler/requests.ts

@@ -45,13 +45,13 @@ export const methodRequest = async (
   if (prefix === 'wallet' && methodName === 'isConnected')
     return dapp.isConnected(host);
   if (data.method && !isBitcoinBased && prefix !== 'sys') {
-    const provider = EthProvider(host, activeNetwork);
+    const provider = EthProvider(host);
     const resp = await provider.unrestrictedRPCMethods(
       data.method,
       data.params
     );
     if (resp !== false && resp !== undefined) {
-      return resp; //Sending back to Dapp non restrictive method response
+      return resp; //Sending back to Dapp non-restrictive method response
     }
   }
   const activeAccountData = accounts[activeAccount.type][activeAccount.id];
@@ -129,21 +129,13 @@ export const methodRequest = async (
       ? [dapp.getAccount(host)?.address]
       : [];
   }
-  // if (
-  //   !isRequestAllowed &&
-  //   methodName !== 'switchEthereumChain' &&
-  //   methodName !== 'getProviderState' &&
-  //   methodName !== 'getSysProviderState' &&
-  //   methodName !== 'getAccount' &&
-  //   methodName !== 'changeUTXOEVM'
-  // )
-  //   throw cleanErrorStack(ethErrors.provider.unauthorized());
   const estimateFee = () => wallet.getRecommendedFee();
 
   //* Wallet methods
   if (prefix === 'wallet') {
     let tryingToAdd = false;
-    const { activeNetwork, networks: chains } = store.getState().vault;
+    const { activeNetwork: currentNetwork, networks: chains } =
+      store.getState().vault;
     switch (methodName) {
       case 'isLocked':
         return !wallet.isUnlocked();
@@ -257,17 +249,17 @@ export const methodRequest = async (
         tryingToAdd = true;
       case 'switchEthereumChain':
         if (isBitcoinBased) throw cleanErrorStack(ethErrors.rpc.internal());
-        const chainId = tryingToAdd
+        const chainIdToAdd = tryingToAdd
           ? customRPCData.chainId
           : Number(data.params[0].chainId);
 
-        if (activeNetwork.chainId === chainId) return null;
-        else if (chains.ethereum[chainId] && !isNetworkChanging) {
+        if (currentNetwork.chainId === chainIdToAdd) return null;
+        else if (chains.ethereum[chainIdToAdd] && !isNetworkChanging) {
           return popupPromise({
             host,
             route: 'switch-EthChain',
             eventName: 'wallet_switchEthereumChain',
-            data: { chainId: chainId },
+            data: { chainId: chainIdToAdd },
           });
         } else if (isNetworkChanging)
           throw cleanErrorStack(
@@ -286,25 +278,23 @@ export const methodRequest = async (
           },
         });
       case 'getProviderState':
-        const providerState = {
+        return {
           accounts: dapp.getAccount(host)
             ? [dapp.getAccount(host).address]
             : [],
-          chainId: `0x${activeNetwork.chainId.toString(16)}`,
+          chainId: `0x${currentNetwork.chainId.toString(16)}`,
           isUnlocked: wallet.isUnlocked(),
-          networkVersion: activeNetwork.chainId,
+          networkVersion: currentNetwork.chainId,
           isBitcoinBased,
         };
-        return providerState;
       case 'getSysProviderState':
-        const blockExplorerURL = isBitcoinBased ? activeNetwork.url : null;
-        const sysProviderState = {
+        const blockExplorerURL = isBitcoinBased ? currentNetwork.url : null;
+        return {
           xpub: dapp.getAccount(host)?.xpub ? dapp.getAccount(host).xpub : null,
           blockExplorerURL: blockExplorerURL,
           isUnlocked: wallet.isUnlocked(),
           isBitcoinBased,
         };
-        return sysProviderState;
       default:
         throw cleanErrorStack(ethErrors.rpc.methodNotFound());
     }
@@ -375,7 +365,7 @@ export const methodRequest = async (
     dapp.getAccount(host)?.address &&
     prefix !== 'sys' &&
     !isBitcoinBased &&
-    EthProvider(host, activeNetwork).checkIsBlocking(data.method) &&
+    EthProvider(host).checkIsBlocking(data.method) &&
     accounts[activeAccount.type][activeAccount.id].address !==
       dapp.getAccount(host)?.address
   ) {
@@ -400,7 +390,7 @@ export const methodRequest = async (
 
   //* Providers methods
   if (prefix !== 'sys' && !isBitcoinBased) {
-    const provider = EthProvider(host, activeNetwork);
+    const provider = EthProvider(host);
     const resp = await provider.restrictedRPCMethods(data.method, data.params);
     console.log({ responseInside: resp });
     // if (!wallet.isUnlocked()) return false;

source/scripts/Background/controllers/promises/cancellablesPromises.ts

@@ -3,6 +3,7 @@ export interface IPromiseProps {
   promise: Promise<{}>;
 }
 
+// eslint-disable-next-line no-shadow
 export enum PromiseTargets {
   ASSETS = 'assets',
   BALANCE = 'balance',
@@ -29,7 +30,9 @@ export class CancellablePromises {
       reject: (reason?: any) => void
     ) => void
   ): { cancel: () => void; currentPromise: Promise<T> } => {
-    let cancel = () => {};
+    let cancel = () => {
+      //noop
+    };
 
     const currentPromise: Promise<T> = new Promise((resolve, reject) => {
       cancel = () => {
@@ -41,50 +44,6 @@ export class CancellablePromises {
     return { currentPromise, cancel };
   };
 
-  public cancelAllPromises = () => {
-    if (this.transactionPromise) {
-      this.transactionPromise.cancel();
-      this.transactionPromise = null;
-    }
-
-    if (this.assetsPromise) {
-      this.assetsPromise.cancel();
-      this.assetsPromise = null;
-    }
-    if (this.nftsPromise) {
-      this.nftsPromise.cancel();
-      this.nftsPromise = null;
-    }
-
-    if (this.balancePromise) {
-      this.balancePromise.cancel();
-      this.balancePromise = null;
-    }
-  };
-
-  public cancelPromise(target: PromiseTargets) {
-    switch (target) {
-      case PromiseTargets.TRANSACTION:
-        this.transactionPromise.cancel();
-        this.transactionPromise = null;
-        break;
-
-      case PromiseTargets.ASSETS:
-        this.assetsPromise.cancel();
-        this.assetsPromise = null;
-        break;
-      case PromiseTargets.NFTS:
-        this.nftsPromise.cancel();
-        this.nftsPromise = null;
-        break;
-
-      case PromiseTargets.BALANCE:
-        this.balancePromise.cancel();
-        this.balancePromise = null;
-        break;
-    }
-  }
-
   public setPromise(target: PromiseTargets, promiseState: any) {
     switch (target) {
       case PromiseTargets.TRANSACTION:

source/scripts/Background/controllers/transactions/queue.ts

@@ -44,7 +44,9 @@ export class Queue {
     } else {
       this.queue.push(
         new Promise(async (resolve) => {
-          await new Promise<void>((resolve) => this.waiting.push(resolve));
+          await new Promise<void>((resolvePromise) =>
+            this.waiting.push(resolvePromise)
+          );
           const result = await this.runFn(fn);
           return resolve(result);
         })

source/scripts/Background/handlers/handleStateChanges.ts

@@ -11,7 +11,9 @@ export function handleObserveStateChanges() {
       type: 'CONTROLLER_STATE_CHANGE',
       data: currentState,
     })
-    .catch(() => {});
+    .catch(() => {
+      //no-op
+    });
 
   store.subscribe(() => {
     const nextState = store.getState();
@@ -32,7 +34,9 @@ export function handleObserveStateChanges() {
           type: 'CONTROLLER_STATE_CHANGE',
           data: nextState,
         })
-        .catch(() => {}); // ignore errors when sending message and the extension is closed
+        .catch(() => {
+          //no-op
+        }); // ignore errors when sending message and the extension is closed
     }
   });
 }

source/scripts/Provider/EthProvider.ts

@@ -1,7 +1,6 @@
 import { TypedData } from 'ethers-eip712';
 import { ethErrors } from 'helpers/errors';
 
-import { INetwork } from '@pollum-io/sysweb3-network';
 import { validateEOAAddress } from '@pollum-io/sysweb3-utils';
 
 import { getController } from 'scripts/Background';
@@ -15,12 +14,11 @@ import cleanErrorStack from 'utils/cleanErrorStack';
 import { decodeTransactionData } from 'utils/ethUtil';
 import { verifyNetworkEIP1559Compatibility } from 'utils/network';
 
-export const EthProvider = (host: string, network?: INetwork) => {
+export const EthProvider = (host: string) => {
   const sendTransaction = async (params: ITransactionParams) => {
     const {
       ethereumTransaction: { web3Provider },
     } = getController().wallet;
-    // await setSignerNetwork(network, 'ethereum');
     const tx = params;
     const validateTxToAddress = await validateEOAAddress(tx.to, web3Provider);
     const isLegacyTx = !(await verifyNetworkEIP1559Compatibility(web3Provider));

source/state/vault/types.ts

@@ -87,6 +87,7 @@ export type PaliAccount = {
   [id: number]: IPaliAccount;
 };
 
+// eslint-disable-next-line no-shadow
 export enum TransactionsType {
   Ethereum = 'ethereum',
   Syscoin = 'syscoin',