Skip to content

Commit 8eb4e47

Browse files
author
jagdeep sidhu
committed
pass max send to backend to handle fees/values properly
1 parent d223605 commit 8eb4e47

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
"@heroicons/react": "^1.0.6",
6464
"@reduxjs/toolkit": "^2.8.2",
6565
"@sidhujag/sysweb3-core": "^1.0.27",
66-
"@sidhujag/sysweb3-keyring": "^1.0.579",
66+
"@sidhujag/sysweb3-keyring": "^1.0.581",
6767
"@sidhujag/sysweb3-network": "^1.0.106",
6868
"@sidhujag/sysweb3-utils": "^1.1.271",
6969
"@tippyjs/react": "^4.2.6",

source/pages/Send/Confirm.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -455,6 +455,7 @@ export const SendConfirm = () => {
455455
{
456456
...restTx,
457457
to: destinationTo,
458+
isMaxSend: Boolean(basicTxValues.isMax),
458459
value: value.toHexString(), // Convert to hex string to avoid out-of-safe-range error
459460
gasPrice: BigNumber.from(gasPrice).toHexString(), // Use BigNumber for precision
460461
gasLimit: (
@@ -509,6 +510,7 @@ export const SendConfirm = () => {
509510
{
510511
...restTx,
511512
to: destinationTo,
513+
isMaxSend: Boolean(basicTxValues.isMax),
512514
value: value.toHexString(), // Convert to hex string to avoid out-of-safe-range error
513515
maxPriorityFeePerGas: parseUnits(
514516
Boolean(
@@ -558,6 +560,10 @@ export const SendConfirm = () => {
558560
const retryTxObject = {
559561
...restTx,
560562
to: destinationTo,
563+
// This retry intentionally sends slightly less than MAX to add a buffer.
564+
// Do NOT mark as isMaxSend, otherwise sysweb3 will recompute the value
565+
// and remove this buffer.
566+
isMaxSend: false,
561567
value: reducedValue.toHexString(), // Convert to hex string to avoid out-of-safe-range error
562568
maxPriorityFeePerGas: parseUnits(
563569
Boolean(

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2629,10 +2629,10 @@
26292629
resolved "https://registry.yarnpkg.com/@sidhujag/sysweb3-core/-/sysweb3-core-1.0.27.tgz#b7dd7d065c1845519e91ac470540ab94721eb33b"
26302630
integrity sha512-aeUJpk+DiziPJbD6HFnfixKZj0T4HYStshjk6+adziftLwamNc3MIp+MtIVZwtzvNpbzIXwAnuJM/QXQsc01NQ==
26312631

2632-
"@sidhujag/sysweb3-keyring@^1.0.579":
2633-
version "1.0.579"
2634-
resolved "https://registry.yarnpkg.com/@sidhujag/sysweb3-keyring/-/sysweb3-keyring-1.0.579.tgz#78604bddfca12e289bf8fe1389703093290356fc"
2635-
integrity sha512-jSkCF5t7JXDxtu1DZtwl4aJAgfFBrj7k2LilfnMnfshyZGICNrq0xlk2ZHK5BS9fxyd6+ndwAwiE1bOwatBvmQ==
2632+
"@sidhujag/sysweb3-keyring@^1.0.581":
2633+
version "1.0.581"
2634+
resolved "https://registry.yarnpkg.com/@sidhujag/sysweb3-keyring/-/sysweb3-keyring-1.0.581.tgz#a75d1368aee0a89ef2f4cf1aad94f93bc792309a"
2635+
integrity sha512-FRSl2vFNbd55mOUN2eUJYtgh/Ia00hEBi3isW8MYDXNwHJwbHpLXlGlddX3iDvaDJ+B97lSja1SWfn/wSxsOGA==
26362636
dependencies:
26372637
"@bitcoinerlab/secp256k1" "^1.2.0"
26382638
"@ethersproject/abstract-provider" "^5.8.0"

0 commit comments

Comments
 (0)