Skip to content

Commit 47ab141

Browse files
committed
ci: add libprotobuf-dev to unit-tests-asan-coverage workflow
This workflow runs directly on the GitHub runner host (not inside one of the deb/rhel/suse-compliant docker containers whose entrypoints already install libprotobuf-dev on demand), so the dependency must be installed in the workflow itself. Without it, building with PROXYSQLGENAI=1 fails at Makefile parse time: the top-level Makefile recurses into plugins/mysqlx (PROXYSQL40 is implied by PROXYSQLGENAI), and plugins/mysqlx/Makefile's protobuf 3.x ABI guard aborts when it cannot find pkg-config metadata for protobuf. The rest of the dependency list mirrors INSTALL.md's Ubuntu section, to which libprotobuf-dev was added separately for general builds; this brings the workflow's package set in line with that.
1 parent 85ad4fe commit 47ab141

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

.github/workflows/CI-unit-tests-asan-coverage.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,19 @@ jobs:
8787
- name: Install build dependencies
8888
# Mirrors the Ubuntu list in INSTALL.md. libmysqlclient-dev is
8989
# needed by some internal build-time helpers used by the vendored
90-
# deps.
90+
# deps. libprotobuf-dev is required for the mysqlx plugin: with
91+
# PROXYSQLGENAI=1 the top-level Makefile recurses into
92+
# plugins/mysqlx (PROXYSQL40 is implied), and that Makefile's
93+
# protobuf 3.x ABI guard fires at parse time without it. The
94+
# docker-compose entrypoints (deb/rhel/suse-compliant) install
95+
# this on demand for container-based builds; this workflow runs
96+
# directly on the runner host so it has to be installed here.
9197
run: |
9298
sudo apt-get -y install \
9399
libssl-dev libgnutls28-dev libmysqlclient-dev \
94100
libboost-all-dev libunwind8 libunwind-dev uuid-dev \
95101
libncurses-dev libicu-dev libevent-dev libtirpc-dev \
96-
ca-certificates
102+
ca-certificates libprotobuf-dev
97103
98104
- name: Install coverage tooling
99105
run: |

0 commit comments

Comments
 (0)