test(pg-compat): review follow-ups — Go cleanup parity, connect encoding assert, xfail entry warning

Author: renecannao

test/pg-compat/behaviors/connect.py

@@ -9,5 +9,10 @@ def run(Adapter):
     a = Adapter()
     try:
         assert a.exec_simple("SELECT 1")[0][0] == 1
+        # Uniform with the four SP-3 driver ports (go/java/node/prisma):
+        # assert the client_encoding=UTF8 pin took effect -- see
+        # harness/targets.py's encoding rationale (backend DBs default to
+        # SQL_ASCII; ProxySQL imposes UTF8).
+        assert a.exec_simple("SHOW client_encoding")[0][0] == "UTF8"
     finally:
         a.close()

test/pg-compat/conftest.py

@@ -1,4 +1,5 @@
 import os
+import warnings
 
 import psycopg
 import pytest
@@ -48,11 +49,26 @@ def proxy_conn():
 
 
 def pytest_collection_modifyitems(config, items):
+    matched_ids = set()
     for item in items:
         entry = _XFAILS.get(item.nodeid)
         if entry:
+            matched_ids.add(item.nodeid)
             item.add_marker(
                 pytest.mark.xfail(
                     reason=f'{entry["reason"]} ({entry["ref"]})', strict=False
                 )
             )
+
+    # Catalogue hygiene: a [[xfail]] entry whose test_id matched NO collected
+    # item is currently a silent no-op (e.g. a typo'd nodeid, or a test that
+    # was renamed/removed without updating xfail.toml). Warn -- don't fail
+    # collection -- so a stale/typo'd entry is visible in the run instead of
+    # quietly doing nothing forever.
+    for test_id in _XFAILS:
+        if test_id not in matched_ids:
+            warnings.warn(
+                f"xfail.toml entry test_id={test_id!r} matched no collected "
+                f"test item -- stale or typo'd entry?",
+                stacklevel=1,
+            )

test/pg-compat/drivers/go/behaviors.go

@@ -110,8 +110,13 @@ func transactions() error {
 	defer conn.Close(ctx)
 
 	// Cleanup runs on success AND on failure (defer), leaving no state
-	// behind, same as the Python behavior's try/finally.
+	// behind, same as the Python behavior's try/finally. Parity with
+	// Java/Node/Prisma: best-effort ROLLBACK first (error ignored) restores
+	// a usable session state before the DROP -- if a non-assertion error
+	// above left the connection mid-transaction, an aborted implicit
+	// transaction would otherwise reject the DROP.
 	defer func() {
+		conn.Exec(ctx, "ROLLBACK")
 		conn.Exec(ctx, fmt.Sprintf("DROP TABLE IF EXISTS %s", txTable))
 	}()