Closes #3207: Add new variable 'mysql-tls_version' controlling the 'tls versions' allowed for client connections #3359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JavierJF
changed the title
…ls versions' allowed for client connections
… 'admin-tls_version-t'
renecannao
requested changes
Mar 25, 2021
…mysql-tls_version'
…'test_mysql-tls_version-t.cpp' for 'mysql-tls_version'
|
Retest this please |
JavierJF
changed the title
|
retest this please |
+ Changed default allowed versions to 'TLSv1.2' and 'TLSv1.3'. This change is required due to the recent upgrade to OpenSSL 3.0, which deprecated older protocol versions. + Added capability for setting older protocol versions than 'TLSv1.2' issuing a warning to the user. + Refactored extraction of allowed versions from 'mysql_thread___tls_version' variable and other minor improvements.
+ Test is now compiled against 'libmysqlclient' due to 'libmariadbclient' dependency being also compiled against 'OpenSSL 3.0'. + Minor refactor and reuse of function from utils.
|
Retest this please. |
- Added conditional compilation for 'test_mysql-tls_version' left as an example on how to compile tap tests against libmysqlclient. - Homogenized compilation line in Makefile
|
Automated message: PR pending admin approval for build testing |
|
retest this please |
1 similar comment
|
retest this please |
|
hi, is there some activity on it ? :-) It would be very nice to have this options. cu denny |
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3207.