-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Description
When using DBIx::Sunny (a Perl database interface),
SHOW WARNINGS queries are sent with inline comments like:
SHOW /* example.pl line 10 */ WARNINGSThis causes ProxySQL to incorrectly return warning_count in the EOF packet, because the current logic
doesn't strip comments before checking the query.
proxysql/lib/mysql_connection.cpp
Line 1828 in 2637d28
| MyRS->add_eof(query.length == 13 && strncasecmp(query.ptr, "SHOW WARNINGS", 13) == 0); |
Proposed fix: Use digest_text (which has comments stripped) instead of raw query, similar to the existing pattern at:
proxysql/lib/mysql_connection.cpp
Line 600 in 2637d28
| (dig_len != 13 || strncasecmp(dig_text, "SHOW WARNINGS", 13) != 0)) { |
I have already prepared a fix for this issue and plan to submit a pull request soon.
I'm relatively new to this codebase, so please let me know if I've misunderstood anything.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels