Detect duplicacy when one number selected from contact and another typed manually

[AkankshaBodhankar]

One is selected from contacts
Another one is typed manually
only +91 is additional to the first one

[vihanga-liyanage]

Apart from detecting the duplicacy what is the expectation hear? Should we delete one number after prompting the user, and if so, which one should we delete?

[Buddhiprabha]

@AkankshaBodhankar how do you plan to solve the issue?

[vihanga-liyanage]

I would suggest a simple algorithm to track the similarity of the six number as a starter. I'm sure it can be minimized using some conditions as well. As an example, if the number contains a +, then we can get that number, slice away the first three characters and compare with other five numbers.

[vihanga-liyanage]

Well follow inputs are also accepted in the current system. This occurs if the contact on the phone was entered without country codes, as it shows in the second image.

[AkankshaBodhankar]

@Buddhiprabha I was planning to use substring() method for implementation
I think implementing this would be better once validating numbers is done
I have opened an issue for validating numbers as well ISSUE #84
Once validation is done it will be easier to implement. As, the length of the numbers will be fixed and also we would know exactly which substring to compare with ...like substring(3rd index ,last) in +91'9985397810' will be compared to 9985397810
A simple toast will be shown if they are duplicates and the duplicate will be erased

I didn't get a green flag yet to go ahead with ISSUE #84.. I'll start working on it and then, this issue

[shruthinayak]

Hello,
Great work on the app 👍
I'm a newbie and wanted to make some contributions. Hence looked into this issue. If I may suggest, here are some things that can be incorporated.
*Set error flags to EditText instead of showing toast. *

This will help us achieve a couple things.

1. Let the user know what he exactly needs to change.
   To do this, we can maintain a Set of already entered phone numbers. In the "OnActivityResult", before setting the EditText to the selected phone number, one can put a check to see if the Set already contains the phone number, if yes then set the error flag with appropriate message.
   phoneInput.setText(selectedNumber);
if (phSet.contains(selectedNumber)) {
phoneInput.setError(getString((R.string.duplicate_number_errormessage)));
phoneInput.requestFocus();
}
2. Lets say that one of the phone numbers is invalid for ex.(565 or 123456), we can set the error flag with different message.
   This can be done when we get the text from the EditText after clicking the save button.
3. Code wise:
   This will simplify the code of check_duplicate_number() to
   if(comrade'x'editText.getError()!=null){
return true;
}

Let me know if this change is okay. I can take it up.

Thanks,
Shruthi.

[AkankshaBodhankar]

@shruthinayak : Great idea. Get in touch with the mentors to get an approval :-)

[shruthinayak]

@AkankshaBodhankar Thank you.
@Buddhiprabha Could you please take a look at the suggestion? Let me know what you think about it.

[Buddhiprabha]

@shruthinayak Please follow the discussion at #84

[sandarumk]

On hold until validating numbers is finalized.