Skip to content

Commit

Permalink
reduce panic in stream canceling
Browse files Browse the repository at this point in the history
  • Loading branch information
syumai committed Apr 20, 2024
1 parent 0713696 commit 1b359b9
Showing 1 changed file with 16 additions and 5 deletions.
21 changes: 16 additions & 5 deletions internal/jsutil/stream.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,22 @@ func ConvertReaderToReadableStream(reader io.ReadCloser) js.Value {
return NewPromise(cb)
}))
rsInit.Set("cancel", js.FuncOf(func(js.Value, []js.Value) any {
err := stream.Cancel()
if err != nil {
panic(err)
}
return js.Undefined()
var cb js.Func
cb = js.FuncOf(func(this js.Value, pArgs []js.Value) any {
defer cb.Release()
resolve := pArgs[0]
reject := pArgs[1]
go func() {
err := stream.Cancel()
if err != nil {
reject.Invoke(Error(err.Error()))
return
}
resolve.Invoke()
}()
return js.Undefined()
})
return NewPromise(cb)
}))
return ReadableStreamClass.New(rsInit)
}

0 comments on commit 1b359b9

Please sign in to comment.