RATIS-2282. LogAppender Restart Due to Premature Log Entry Access During Concurrent Write Processing (apache#1249)

RkGrit · szetszwo · commit 938af308a256 · 2025-05-18T16:57:37.000-07:00
diff --git a/ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/LogSegment.java b/ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/LogSegment.java
@@ -328,10 +328,10 @@ private void append(boolean keepEntryInCache, LogEntryProto entry, Op op) {
     }
 
     final LogRecord record = new LogRecord(totalFileSize, entry);
-    records.add(record);
     if (keepEntryInCache) {
       putEntryCache(record.getTermIndex(), entry, op);
     }
+    records.add(record);
     totalFileSize += getEntrySize(entry, op);
     endIndex = entry.getIndex();
   }

Original file line number	Diff line number	Diff line change
`@@ -328,10 +328,10 @@ private void append(boolean keepEntryInCache, LogEntryProto entry, Op op) {`
`328`	`328`	`}`
`329`	`329`
`330`	`330`	`final LogRecord record = new LogRecord(totalFileSize, entry);`
`331`		`- records.add(record);`
`332`	`331`	`if (keepEntryInCache) {`
`333`	`332`	`putEntryCache(record.getTermIndex(), entry, op);`
`334`	`333`	`}`
	`334`	`+ records.add(record);`
`335`	`335`	`totalFileSize += getEntrySize(entry, op);`
`336`	`336`	`endIndex = entry.getIndex();`
`337`	`337`	`}`