Skip to content

Commit 3075cd1

Browse files
committed
[Gradle] Fix copying signed release APK
1 parent 137ea65 commit 3075cd1

File tree

3 files changed

+24
-30
lines changed

3 files changed

+24
-30
lines changed

Diff for: .github/utils/rename_artifacts.py renamed to .github/utils/find_artifacts.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
files = glob.glob(f"{project_dir}/app/release/*.*")
1515
for file in files:
16-
file_relative = file.replace(sys.argv[1] + "/", "")
16+
file_relative = file.replace(project_dir + "/", "")
1717
if "-aligned.apk" in file:
1818
os.unlink(file)
1919
elif "-signed.apk" in file:

Diff for: .github/workflows/_build.yml

+19-26
Original file line numberDiff line numberDiff line change
@@ -86,43 +86,33 @@ jobs:
8686
- name: Bump nightly version
8787
if: ${{ inputs.nightly }}
8888
run: python $GITHUB_WORKSPACE/.github/utils/bump_nightly.py $GITHUB_WORKSPACE >> $GITHUB_OUTPUT
89-
- name: Write signing passwords
89+
- name: Write signing passwords and keystore
9090
env:
9191
DB_HOST: ${{ secrets.DB_HOST }}
9292
DB_USER: ${{ secrets.DB_USER }}
9393
DB_PASS: ${{ secrets.DB_PASS }}
9494
DB_NAME: ${{ secrets.DB_NAME }}
95-
run: python $GITHUB_WORKSPACE/.github/utils/sign.py $GITHUB_WORKSPACE commit >> $GITHUB_OUTPUT
95+
KEY_STORE: ${{ secrets.KEY_STORE }}
96+
run: |
97+
python $GITHUB_WORKSPACE/.github/utils/sign.py $GITHUB_WORKSPACE commit >> $GITHUB_OUTPUT
98+
echo $KEY_STORE | base64 --decode > app/keystore.jks
9699
- name: Clean build artifacts
97100
run: |
98101
rm -rf app/release/*
99102
rm -rf app/build/outputs/apk/*
100103
rm -rf app/build/outputs/bundle/*
101104
102-
- name: Build APK with Gradle
103-
if: ${{ inputs.build-apk }}
104-
uses: gradle/gradle-build-action@v2
105-
with:
106-
arguments: assembleOfficialRelease
107-
- name: Build AAB with Gradle
108-
if: ${{ inputs.build-aab }}
109-
uses: gradle/gradle-build-action@v2
105+
- name: Build app with Gradle
106+
if: ${{ inputs.build-apk || inputs.build-aab }}
107+
uses: gradle/actions/setup-gradle@v3
110108
with:
111-
arguments: bundlePlayRelease
112-
113-
- name: Sign build artifacts
114-
uses: r0adkll/sign-android-release@v1
115-
with:
116-
releaseDirectory: app/release
117-
signingKeyBase64: ${{ secrets.KEY_STORE }}
118-
alias: ${{ secrets.KEY_ALIAS }}
119-
keyStorePassword: ${{ secrets.KEY_STORE_PASSWORD }}
120-
keyPassword: ${{ secrets.KEY_ALIAS_PASSWORD }}
121-
env:
122-
BUILD_TOOLS_VERSION: "34.0.0"
123-
- name: Rename signed artifacts
124-
id: artifacts
125-
run: python $GITHUB_WORKSPACE/.github/utils/rename_artifacts.py $GITHUB_WORKSPACE >> $GITHUB_OUTPUT
109+
arguments: |
110+
${{ inputs.build-apk && 'assembleOfficialRelease' || '' }}
111+
${{ inputs.build-aab && 'bundlePlayRelease' || '' }}
112+
-P android.injected.signing.store.file=keystore.jks
113+
-P android.injected.signing.store.password=${{ secrets.KEY_STORE_PASSWORD }}
114+
-P android.injected.signing.key.alias=${{ secrets.KEY_ALIAS }}
115+
-P android.injected.signing.key.password=${{ secrets.KEY_ALIAS_PASSWORD }}
126116
127117
- name: Upload release to server
128118
if: ${{ inputs.release-ssh }}
@@ -131,9 +121,12 @@ jobs:
131121
REMOTE_HOST: ${{ secrets.SSH_IP }}
132122
REMOTE_USER: ${{ secrets.SSH_USERNAME }}
133123
SSH_PRIVATE_KEY: ${{ secrets.SSH_KEY }}
134-
SOURCE: ${{ steps.artifacts.outputs.signedReleaseFileRelative }}
124+
SOURCE: app/release/
135125
TARGET: ${{ inputs.nightly && secrets.SSH_PATH_NIGHTLY || secrets.SSH_PATH_RELEASE }}
136126

127+
- name: Find signed artifacts
128+
id: artifacts
129+
run: python $GITHUB_WORKSPACE/.github/utils/find_artifacts.py $GITHUB_WORKSPACE >> $GITHUB_OUTPUT
137130
- name: Extract release changelogs
138131
id: changelog
139132
run: python $GITHUB_WORKSPACE/.github/utils/extract_changelogs.py $GITHUB_WORKSPACE >> $GITHUB_OUTPUT

Diff for: app/build.gradle

+4-3
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,10 @@ tasks.whenTaskAdded { task ->
153153
dependsOn(task.name)
154154
duplicatesStrategy DuplicatesStrategy.FAIL
155155
from file("${projectDir}/${flavor}/release/"),
156-
file("${buildDir}/outputs/mapping/${flavor}Release/"),
157-
file("${buildDir}/outputs/bundle/${flavor}Release/")
158-
include "*.aab", "*.apk", "mapping.txt", "output-metadata.json"
156+
file("${projectDir}/build/outputs/apk/${flavor}/release/"),
157+
file("${projectDir}/build/outputs/mapping/${flavor}Release/"),
158+
file("${projectDir}/build/outputs/bundle/${flavor}Release/")
159+
include "*-release.aab", "*-release.apk", "mapping.txt", "output-metadata.json"
159160
destinationDir file("${projectDir}/release/")
160161
rename ".+?\\.(.+)", "Edziennik_${android.defaultConfig.versionName}_${flavor}." + '$1'
161162
}

0 commit comments

Comments
 (0)