Treat computed make refs as uncached

Finding: [P2] Treat computed Make variable names as uncached — /Users/tomasz/github/t-kalinowski/quickr/R/aaa-utils.R:752-752

Resolution: computed variable names with nested make references are now treated as dynamic inputs and bypass successful-probe caching. Added a regression test for FC resolved through a ROOT suffix variable.

Author: t-kalinowski

R/aaa-utils.R

@@ -749,7 +749,7 @@ quickr_text_has_makevars_uncached_function <- function(text) {
   function_pattern <- "\\$\\([A-Za-z_][A-Za-z0-9_.-]*[[:space:]]|\\$\\{[A-Za-z_][A-Za-z0-9_.-]*[[:space:]]"
   substitution_pattern <- "\\$\\([A-Za-z_][A-Za-z0-9_.-]*:[^)]*\\)|\\$\\{[A-Za-z_][A-Za-z0-9_.-]*:[^}]*\\}"
   shell_assignment_pattern <- "^[[:space:]]*(?:(?:export|override|private)[[:space:]]+)*[A-Za-z_][A-Za-z0-9_.-]*[[:space:]]*!="
-  indirect_ref_pattern <- "\\$[({]\\$[({]"
+  indirect_ref_pattern <- "\\$[({][^)}]*\\$[({]"
   any(grepl(
     paste(
       function_pattern,

tests/testthat/test-compiler-cache.R

@@ -1211,6 +1211,42 @@ test_that("quickr_cached_r_cmd_config_value retries Makevars with indirect refs"
   expect_equal(calls, 2L)
 })
 
+test_that("quickr_cached_r_cmd_config_value retries Makevars with computed refs", {
+  cache <- new.env(parent = emptyenv())
+  makevars <- withr::local_tempfile()
+  writeLines(
+    c(
+      "SUFFIX = A",
+      "FC = $(ROOT_$(SUFFIX))"
+    ),
+    makevars
+  )
+  calls <- 0L
+  local_mocked_bindings(
+    quickr_r_cmd_config_probe = function(name) {
+      calls <<- calls + 1L
+      list(value = paste0("value-", calls), ok = TRUE)
+    },
+    .package = "quickr"
+  )
+  withr::local_envvar(c(
+    ROOT_A = "gfortran",
+    R_MAKEVARS_USER = makevars
+  ))
+
+  expect_identical(
+    quickr_cached_r_cmd_config_value("FC", cache = cache),
+    "value-1"
+  )
+
+  withr::local_envvar(ROOT_A = "flang")
+  expect_identical(
+    quickr_cached_r_cmd_config_value("FC", cache = cache),
+    "value-2"
+  )
+  expect_equal(calls, 2L)
+})
+
 test_that("quickr_cached_r_cmd_config_value keys on MAKEFILES content", {
   cache <- new.env(parent = emptyenv())
   makefile <- withr::local_tempfile()