Merge pull request #39 from t-kalinowski/case-sensitive-checks

Case sensitive checks

Author: t-kalinowski

R/preprocess-lang.R

@@ -37,3 +37,14 @@ whole_doubles_to_ints <- function(x) {
   }
   walker(x)
 }
+
+
+substitute_unique_case_insensitive_symbols <- function(x) {
+  # TODO: would be nice to fix case-insenstive name clashes
+  # with automatic substitutions. Would be a little involved since
+  # substitute will not replace tag names in a call, e.g.,
+  # declare(type(<NAME> = ...)), NAME would need to be manually replaced.
+  stopifnot(is.function(x))
+  nms <- unique(c(all.names(body(x), names(formals(x)))))
+  stop("not yet implemented")
+}

R/quick.R

@@ -236,6 +236,14 @@ check_all_var_names_valid <- function(fun) {
       glue_collapse(invalid, ", ", last = ", and ")
     )
   }
+
+  case_clashes <- nms[is_duplicate(tolower(nms))]
+  if (length(case_clashes)) {
+    stop(
+      "Fortran is case-insensitive; these names conflict when case is ignored: ",
+      glue_collapse(glue::backtick(case_clashes), ", ", last = " and ")
+    )
+  }
 }
 
 
@@ -247,3 +255,9 @@ make_unique_name <- local({
     paste0(prefix, i <<- i + 1L)
   }
 })
+
+is_duplicate <- function(x) {
+  out <- duplicated(x) | duplicated(x, fromLast = TRUE)
+  names(out) <- names(x)
+  out
+}

tests/testthat/test-errors.R

@@ -0,0 +1,9 @@
+test_that("case-sensitive variable name clashes", {
+  expect_error(regexp = "case-insensitive.+`j`.+`J`", {
+    quick(function(j) {
+      declare(type(j = integer(1)))
+      J <- double(length = j)
+      J
+    })
+  })
+})