Commit d4a12a5
committed
Extract check_subscript_exprs() shared by read and write subscripts
The read-side `[` handler and the write-side compile_subset_designator()
carried the same six-line validation loop; the invariant that both sides
validate identically is now pinned by a single helper instead of a
comment asking to keep two copies in sync.
Review finding (fable-final-review.md #3); no behavior change.1 parent 0fcdd67 commit d4a12a5
2 files changed
Lines changed: 17 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1392 | 1392 | | |
1393 | 1393 | | |
1394 | 1394 | | |
1395 | | - | |
1396 | | - | |
1397 | | - | |
1398 | | - | |
1399 | | - | |
1400 | | - | |
| 1395 | + | |
1401 | 1396 | | |
1402 | 1397 | | |
1403 | 1398 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
| 26 | + | |
32 | 27 | | |
33 | 28 | | |
34 | 29 | | |
| |||
306 | 301 | | |
307 | 302 | | |
308 | 303 | | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
309 | 318 | | |
310 | 319 | | |
311 | 320 | | |
312 | | - | |
313 | | - | |
| 321 | + | |
314 | 322 | | |
315 | 323 | | |
316 | 324 | | |
| |||
0 commit comments