Try to avoid re-querying when the query is same

Author: t2t2

src/syncers/collection.js

@@ -66,9 +66,14 @@ export default class CollectionSyncer extends BaseSyncer {
 
 			// When new value is found
 			const callback = function (newVal) {
+				// Avoid re-querying if it's the same
+				if (this.Vue.util.looseEqual(this.filters.query, newVal)) {
+					this.filters.query = newVal
+					return
+				}
 				this.filters.query = newVal
 
-				// Clear state (if now null it just makes sure)
+				// Clear state (if query is now null it makes sure everything's reset)
 				this.state = this._initialState()
 				this._matcher = () => false
 

test/collection.query.test.js

@@ -118,6 +118,19 @@ test('Switching queries', async t => {
 
 	t.falsy(syncer.loading)
 	t.deepEqual(syncer.state, {2: {id: 2, otherItem: true}})
+
+	// Try to avoid re-querying whenver possible
+	instance.$once('syncer-loaded', () => {
+		t.fail('Queried again when test shouldn\'t')
+	})
+	instance.variables.query = {otherItem: true}
+	// Wait for watchers to do their thing
+	await new Promise(resolve => {
+		instance.$nextTick(() => {
+			resolve()
+		})
+	})
+	t.false(syncer.loading)
 })
 
 test('Creating items', async t => {