Skip to content

Custom build page #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

gamebox
Copy link
Contributor

@gamebox gamebox commented Apr 9, 2016

This closes #43

@mrmrs plans on touching up the aesthetics and the copy.

@gamebox
Copy link
Contributor Author

gamebox commented Apr 18, 2016

I know that you have a lot going on, but is there something I can do to help move this along @mrmrs or @johnotander ? I'm scared of losing a lot of context when you ask for changes here.

@johno
Copy link
Member

johno commented Apr 19, 2016

Sorry about the delay on this @gamebox.

I know that @mrmrs wants to do some design-age and tweak the messaging before going "live". But I'd imagine to start we could merge in the page without a link in the nav. This will allow us to soak it a bit and make sure it all works before adding a link for all users to see.

@gamebox
Copy link
Contributor Author

gamebox commented Apr 20, 2016

That sounds like a good approach. I'll add a commit to remove the link tomorrow morning and add it to the PR

@mrmrs
Copy link
Member

mrmrs commented Apr 20, 2016

Hey Anthony,
I'd say let's just leave it unmerged right now. I just got internet in my apartment so trying to catch up on lots of oss things. I hate to have you undo work or do unnecessary work by making a commit just to remove the link. I understand you don't want to lose context, but I also don't like to ship things without working on copy or visual design. My deepest apologies for being behind on this, open source efforts on my end generally come in waves. Definitely appreciate your help with this. Remember: any requested changes made will just become new issues. There is no pressure or obligation on your part to do them :)

Sent from my iPhone

On Apr 20, 2016, at 3:58 AM, Anthony Bullard [email protected] wrote:

That sounds like a good approach. I'll add a commit to remove the link tomorrow morning and add it to the PR


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@mrmrs
Copy link
Member

mrmrs commented Apr 26, 2016

This has been moved to a separate PR.

@mrmrs mrmrs closed this Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Build Page
3 participants