Fix exception raised when attempting to vote

Seems like Bukkit / Spigot API changes have caused the vote menu to
raise an exception and crash when attempting to vote in an election.

Either that, or it's because we removed cached player state from the
worlds we're using this plugin in, and we didn't notice it broke things.

In any case, a new version of triumph-gui (3.1.6 -- weirdly we were
using 3.2 previously, but such a version doesn't actually seem to exist)
coupled with some changes to make sure we don't pass a null owner to the
SkullBuilder.owne() api seems to have fixed the issues.

Author: tadhunt

build.gradle

@@ -56,7 +56,7 @@ subprojects {
     compileJava.options.encoding = "UTF-8"
     compileTestJava.options.encoding = "UTF-8"
 
-    version = "MCPD-1.2.5"
+    version = "MCPD-1.2.6"
     group = "me.lorenzo0111"
 
     repositories {

elections-spigot/build.gradle

@@ -52,7 +52,7 @@ dependencies {
     implementation('space.rocketplugins.pluginslib:bukkit:2.0.3.2')
     implementation("net.kyori:adventure-platform-bukkit:4.3.0")
     implementation('org.bstats:bstats-bukkit:3.0.2')
-    implementation("dev.triumphteam:triumph-gui:3.2")
+    implementation("dev.triumphteam:triumph-gui:3.1.6")
 
     slim('com.github.cryptomorin:XSeries:9.6.1.1')
 

elections-spigot/src/main/java/me/lorenzo0111/elections/ElectionsPlus.java

@@ -56,6 +56,7 @@
 
 import org.bukkit.Bukkit;
 import org.bukkit.Location;
+import org.bukkit.OfflinePlayer;
 import org.bukkit.World;
 import org.bukkit.block.Block;
 import org.bukkit.plugin.RegisteredServiceProvider;
@@ -731,4 +732,24 @@ public EClaim findClaimByGpId(Long gpid) {
 
         return null;
     }
+
+    /*
+     * NOTE(tadhunt): This is a hack to make sure that we have a non-null OfflinePlayer to
+     * use for the ItemBuilder API, otherwise we end up crashing with weird exceptions.
+     */
+    public OfflinePlayer getPartyOwner(Party party, OfflinePlayer defaultOwner) {
+        UUID nilUuid = new UUID(0, 0);
+        UUID partyOwnerUuid = party.getOwner();
+
+        if (partyOwnerUuid.equals(nilUuid)) {
+            return defaultOwner;
+        }
+
+        try {
+            return Bukkit.getOfflinePlayer(party.getOwner());
+        } catch(Exception e) {
+            return defaultOwner;
+        }
+    }
+
 }

elections-spigot/src/main/java/me/lorenzo0111/elections/menus/AddPartyMenu.java

@@ -36,6 +36,7 @@
 import net.kyori.adventure.text.Component;
 import org.bukkit.Bukkit;
 import org.bukkit.Material;
+import org.bukkit.OfflinePlayer;
 import org.bukkit.entity.Player;
 import org.bukkit.event.inventory.InventoryClickEvent;
 
@@ -82,8 +83,9 @@ public void setup() {
             this.getFiller().fillBottom(ItemBuilder.from(Objects.requireNonNull(XMaterial.BLACK_STAINED_GLASS_PANE.parseItem())).asGuiItem());
 
             for (Party party : parties.values()) {
+                OfflinePlayer partyOwner = plugin.getPartyOwner(party, this.owner);
                 SkullBuilder item = ItemBuilder.skull()
-                        .owner(Bukkit.getOfflinePlayer(party.getOwner()))
+                        .owner(partyOwner)
                         .name(Component.text("§9" + party.getName()))
                         .lore(Messages.component(false, "guis", "add"), Messages.component(false, "guis", "remove"));
 

elections-spigot/src/main/java/me/lorenzo0111/elections/menus/PartiesMenu.java

@@ -38,6 +38,7 @@
 import net.kyori.adventure.text.Component;
 import org.bukkit.Bukkit;
 import org.bukkit.Material;
+import org.bukkit.OfflinePlayer;
 import org.bukkit.entity.Player;
 
 import java.util.EnumSet;
@@ -76,11 +77,12 @@ public void setup() {
             this.getFiller().fillBottom(ItemBuilder.from(Objects.requireNonNull(XMaterial.BLACK_STAINED_GLASS_PANE.parseItem())).asGuiItem());
 
             for (Party party : parties.map().values()) {
+                OfflinePlayer partyOwner = plugin.getPartyOwner(party, this.owner);
                 SkullBuilder item = ItemBuilder.skull()
                         .name(Component.text("§9" + party.getName()))
                         .lore(canEdit(owner, party) ? Messages.component(false, "guis", "edit-party") : Messages.component(false, "guis", "no-edit-party"));
 
-                item.owner(Bukkit.getOfflinePlayer(party.getOwner()));
+                item.owner(partyOwner);
 
                 if (party.getIcon() != null)
                     item.texture(party.getIcon());

elections-spigot/src/main/java/me/lorenzo0111/elections/menus/VoteMenu.java

@@ -37,6 +37,7 @@
 import net.kyori.adventure.text.Component;
 import org.bukkit.Bukkit;
 import org.bukkit.Material;
+import org.bukkit.OfflinePlayer;
 import org.bukkit.entity.Player;
 
 import java.util.HashSet;
@@ -69,11 +70,14 @@ public void setup() {
             if (party == null) {
                 continue;
             }
+
+            OfflinePlayer partyOwner = plugin.getPartyOwner(party, this.owner);
+
             this.addItem(ItemBuilder.skull()
                     .name(Component.text("§9" + party.getName()))
                     .lore(Messages.component(false, "guis", "vote"))
                     .texture(party.getIcon())
-                    .owner(Bukkit.getOfflinePlayer(party.getOwner()))
+                    .owner(partyOwner)
                     .asGuiItem(e -> {
                         this.close(e.getWhoClicked());