Skip to content

Split SyntaxError::UnclosedPIOrXmlDecl into 2 separate variants #916

@SuchAFuriousDeath

Description

@SuchAFuriousDeath

The SyntaxError enum does not currently differentiate between and unclosed processing instruction and an unclosed xml tag:

UnclosedPIOrXmlDecl,

I was trying to make some tests pass in Ruffle and it turns out that in order for the tests to pass, we need to differentiate between those 2 errors and throw different errors based on which one occured.

I was wondering whether it would be acceptable to split the SyntaxError::UnclosedPIOrXmlDecl variant into 2 separate variants. This would of course be a breaking change. I could do a PR if it is deemed acceptable.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions