Fixes related to biome, build to TS and unit tests.

mateuscardosodeveloper · mateuscardosodeveloper · commit d346887be109 · 2025-04-04T12:40:38.000-03:00
diff --git a/src/analysis/data-retention.ts b/src/analysis/data-retention.ts
@@ -23,17 +23,12 @@ async function resolveDataRetentionByOrg(org_id: string) {
   });
 
   for (const device_obj of device_list) {
-    // @ts-ignore: Unreachable code error
-    if (!device_obj.bucket) {
-      return;
-    }
-
-    const bucket_variables = await Resources.buckets.listVariables(device_obj.bucket.id);
-    if (!bucket_variables[0]) {
+    const variables = await Resources.devices.getDeviceData(device_obj.id, { qty: 9999 });
+    if (!variables[0]) {
       return;
     }
 
-    const bucket_vars = bucket_variables.map((v) => v.variable);
+    const bucket_vars = variables.map((v) => v.variable);
     const data_retention_ignore = bucket_vars
       .map((r) => {
         if (!r.includes("action")) {
diff --git a/src/analysis/send-report.ts b/src/analysis/send-report.ts
@@ -9,7 +9,7 @@
  * - When setting a scheduled report, an action will trigger this script.
  */
 
-import dayjs from "dayjs";
+import { DateTime } from "luxon";
 
 import { Analysis, Resources } from "@tago-io/sdk";
 import { ActionInfo, TagoContext, UserInfo } from "@tago-io/sdk/lib/types";
@@ -93,7 +93,7 @@ async function resolveReport(context: TagoContext, action_info: ActionInfo, org_
       status: status_history,
       battery: `${(battery?.value as string) ?? "N/A"}${battery?.unit ?? ""}`,
       rssi: (rssi?.value as string) ?? "N/A",
-      date: dayjs(String(sensor_info.last_input)).format("YYYY-MM-DD HH:mm:ss"),
+      date: DateTime.fromISO(String(sensor_info.last_input)).toFormat("yyyy-MM-dd HH:mm:ss"),
     });
   }
 
diff --git a/src/analysis/status-updater.ts b/src/analysis/status-updater.ts
@@ -11,7 +11,7 @@
  */
 
 import async from "async";
-import dayjs from "dayjs";
+import { DateTime } from "luxon";
 
 import { Analysis, Resources, Utils } from "@tago-io/sdk";
 import { DeviceInfo, DeviceListItem, TagoContext } from "@tago-io/sdk/lib/types";
@@ -38,9 +38,9 @@ async function resolveOrg(org: DeviceListItem) {
   });
 
   for (const sensor of sensorList) {
-    const last_input = dayjs(sensor.last_input);
-    const now = dayjs();
-    const diff_time = now.diff(last_input, "hours");
+    const last_input = DateTime.fromISO(String(sensor.last_input || ""));
+    const now = DateTime.now();
+    const diff_time = now.diff(last_input, "hours").hours;
     total_qty++;
     if (diff_time < 24) {
       active_qty++;
@@ -136,15 +136,15 @@ async function resolveDevice(context: TagoContext, org_id: string, device_id: st
     return Promise.reject("Device not found");
   }
 
-  const checkin_date = dayjs(device_info.last_input);
+  const checkin_date = DateTime.fromISO(device_info.last_input.toString());
 
-  if (!checkin_date) {
+  if (!checkin_date.isValid) {
     return "no data";
   }
 
-  let diff_hours: string | number = dayjs().diff(checkin_date, "hours");
+  let diff_hours: string | number = DateTime.now().diff(checkin_date, "hours").hours;
 
-  if (diff_hours !== diff_hours) {
+  if (isNaN(diff_hours)) {
     diff_hours = "-";
   } //checking for NaN
 
diff --git a/src/lib/device-name-exists.test.ts b/src/lib/device-name-exists.test.ts
@@ -1,8 +1,8 @@
 import { deviceNameExists } from "./device-name-exists";
 
-jest.mock("../lib/fetch-device-list", () => {
+vitest.mock("../lib/fetch-device-list", () => {
   return {
-    fetchDeviceList: jest
+    fetchDeviceList: vitest
       .fn()
       .mockImplementationOnce(() => Promise.resolve([]))
       .mockImplementationOnce(() => Promise.resolve([{ id: "orgOne" }]))
diff --git a/src/lib/install-template.ts b/src/lib/install-template.ts
@@ -22,7 +22,7 @@ async function InstallTemplate(templates: string[], replaceObj: any) {
   }
 
   for (const dashboard of dash_list) {
-    let dash_info = (await Resources.dashboards.info(dashboard)) as Writeable<DashboardInfo> & { setup: {} };
+    let dash_info = (await Resources.dashboards.info(dashboard)) as Writeable<DashboardInfo> & { setup: Record<string, unknown> };
     const hidden_var = dash_info.tags?.find((x) => x.key === "hidden");
     dash_info.visible = !hidden_var;
     dash_info = replaceJSON(dash_info, replaceObj);
diff --git a/src/lib/pdf-template.ts b/src/lib/pdf-template.ts
@@ -1,10 +1,10 @@
-import dayjs from "dayjs";
+import { DateTime } from "luxon";
 
 const headerTemplate = `
 <div class="header" style="background-color: rgba(47, 48, 101, 0.1); align-items: center; padding: 0px 30px; font-size: 30px; width: 100%; color:black !important; margin:0px 20px 80px 20px; border-radius: 8px 8px 0 0; -webkit-print-color-adjust: exact; height: 60rem;">
   <div style="display: inline-block; margin: 0 2rem; vertical-align: top; text-align: start; width: 70%;">
     <h1 style="font-weight: 400; color:black !important; font-size: 18px;">$ORG_NAME$ - Sensor Report</h1>
-    <h1 style="font-weight: 400; font-size: 10px;">${dayjs().format("YYYY-MM-DD HH:mm:ss")}</h1>
+    <h1 style="font-weight: 400; font-size: 10px;">${DateTime.now().toFormat("yyyy-MM-dd HH:mm:ss")}</h1>
   </div>
   <div style="display: inline-block; width: 25%; margin-top:15px;">
     <img
diff --git a/src/lib/send-pdf.ts b/src/lib/send-pdf.ts
@@ -41,8 +41,7 @@ async function createPDF(context: TagoContext, htmlBody: string, users_info_list
   const report = await pdf.generate({ base64, options }).catch((error) => console.debug(error));
 
   // Send the email.
-  // eslint-disable-next-line unicorn/no-array-for-each
-  users_info_list.forEach(async (user_info) => {
+  for (const user_info of users_info_list) {
     if (user_info?.email) {
       await email
         .send({
@@ -60,7 +59,7 @@ async function createPDF(context: TagoContext, htmlBody: string, users_info_list
     } else {
       console.debug("Error - couldnt find user");
     }
-  });
+  }
 
   const filename = `/reports/${org_id}/sensor_report_${uuidv4()}.pdf`;
 
diff --git a/src/lib/undo-device-changes.ts b/src/lib/undo-device-changes.ts
@@ -19,7 +19,6 @@ async function undoDeviceChanges({ scope, deviceInfo }: { scope: DeviceListScope
   for (const key of Object.keys(deviceScope)) {
     if (key === "name") {
       const oldName = deviceScope?.old?.[key] as string;
-      // eslint-disable-next-line no-undef
       await Resources.devices.edit(deviceInfo.id, { name: oldName });
     } else if (key.includes("param.")) {
       const paramKey = key.replace("param.", "");
diff --git a/src/lib/validation.ts b/src/lib/validation.ts
@@ -2,7 +2,6 @@ import { DateTime } from "luxon";
 
 import { Resources } from "@tago-io/sdk";
 
-// eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
 type validation_type = "success" | "danger" | "warning" | string;
 interface IValidateOptions {
   show_markdown?: boolean;
diff --git a/src/services/alerts/check-in-alerts.ts b/src/services/alerts/check-in-alerts.ts
@@ -1,4 +1,4 @@
-import dayjs from "dayjs";
+import { DateTime } from "luxon";
 
 import { Resources } from "@tago-io/sdk";
 import { TagoContext } from "@tago-io/sdk/lib/types";
@@ -18,7 +18,7 @@ interface ICheckInParam {
  */
 async function checkInTrigger(context: TagoContext, org_id: string, params: ICheckInParam) {
   const { last_input, device_id } = params;
-  const checkin_date = dayjs(last_input);
+  const checkin_date = last_input ? DateTime.fromJSDate(last_input) : null;
   if (!checkin_date) {
     return "no data";
   }
@@ -28,7 +28,7 @@ async function checkInTrigger(context: TagoContext, org_id: string, params: IChe
   const actionList = paramList.filter((param) => param.key.startsWith("checkin"));
   for (const param of actionList) {
     const [interval] = param.value.split(",");
-    const diff_hours: string | number = dayjs().diff(checkin_date, "hours");
+    const diff_hours: number = DateTime.now().diff(checkin_date, "hours").hours;
 
     if (diff_hours >= Number(interval) && !param.sent) {
       const action_id = param.key.replace("checkin", "");
diff --git a/src/services/alerts/geofence-alert.ts b/src/services/alerts/geofence-alert.ts
@@ -23,7 +23,6 @@ function insidePolygon(point: [number, number], geofence: Data["metadata"]) {
     const yi = geofence[i][1];
     const xj = geofence[j][0];
     const yj = geofence[j][1];
-    // eslint-disable-next-line @typescript-eslint/restrict-plus-operands
     const intersect = yi > y != yj > y && x < ((xj - xi) * (y - yi)) / (yj - yi) + xi;
     if (intersect) {
       inside = !inside;
diff --git a/src/services/device/register.ts b/src/services/device/register.ts
@@ -125,7 +125,7 @@ async function sensorAdd({ context, scope, environment }: RouterConstructorData)
   let dash_id = "";
   try {
     ({ id: dash_id } = await getDashboardByConnectorID(connector_id));
-  } catch (error) {
+  } catch (_error) {
     return validate("#VAL.ERROR__NO_DASHBOARD_FOUND#", "danger");
   }
 
diff --git a/src/services/organization/register.ts b/src/services/organization/register.ts
@@ -152,8 +152,7 @@ async function orgAdd({ context, scope, environment }: RouterConstructorData) {
   if (new_user_name?.value) {
     scope = scope.map((data) => ({ ...data, device: device_id }));
     await userAdd({ context, scope, environment }).catch(async (error) => {
-      // @ts-expect-error - expected error.
-      await orgDel({ scope: [{ device: device_id }] }).catch((error) => console.log(error));
+      await orgDel({ scope: [{ device: device_id }], environment }).catch((error) => console.log(error));
       throw await validate(error, "danger").catch((error) => console.log(error));
     });
   }
diff --git a/src/services/plan/check-and-charge-usage.ts b/src/services/plan/check-and-charge-usage.ts
@@ -53,7 +53,7 @@ const checkTagoPlan = async (type: CommunicationMean, environment: AnalysisEnvir
  * @param current_sms_usage Current sms usage of the organization
  * @param service_type Type of service that will be checked
  */
-const sendLimitAlert = async (context: TagoContext, org_id: string, current_email_usage: string, current_sms_usage: string, service_type: string) => {
+const sendLimitAlert = async (_context: TagoContext, org_id: string, _current_email_usage: string, _current_sms_usage: string, service_type: string) => {
   //guest will not receive the notification/email
   const users_list = await Resources.run.listUsers({ amount: 9999, fields: ["id", "name", "email"], filter: { tags: [{ key: "organization_id", value: org_id }] } });
 
diff --git a/src/services/reports/action.model.ts b/src/services/reports/action.model.ts
@@ -26,8 +26,7 @@ async function actionModel(action_object: ReportActionStructure, timezone: strin
     name: `SENSOR REPORT ACTION / VAR. GROUP: ${action_object.group}`,
     active: action_object.active,
     type: "schedule",
-    // eslint-disable-next-line no-unsafe-optional-chaining
-    tags: [{ key: "organization_id", value: action_object.org_id }, ...action_object?.tags],
+    tags: [{ key: "organization_id", value: action_object.org_id }, ...action_object.tags],
     trigger: [
       {
         cron: action_object.cron, //"00 08 */1 * Fri,Mon,Sat,Sun,Thu,Tue,Wed"
diff --git a/src/services/reports/edit.ts b/src/services/reports/edit.ts
@@ -102,7 +102,7 @@ async function reportEdit({ context, scope, environment }: RouterConstructorData
 
   const user_info = await Resources.run.userInfo(environment._user_id);
   const timezone = user_info?.timezone || "America/Sao_Paulo";
-  const action_model = await actionModel(action_object, timezone);
+  const action_model = await actionModel(action_object, timezone, environment);
 
   await Resources.actions
     .edit(action_registered.id, action_model)
diff --git a/src/services/user/remove.ts b/src/services/user/remove.ts
@@ -1,4 +1,5 @@
 import { Resources } from "@tago-io/sdk";
+import { UserListScope } from "@tago-io/sdk/lib/modules/Utils/router/router.types";
 
 import { RouterConstructorData } from "../../types";
 
@@ -7,7 +8,7 @@ import { RouterConstructorData } from "../../types";
  * @param scope Scope is a variable sent by the analysis
  * @param environment Environment Variable is a resource to send variables values to the context of your script
  */
-async function userDel({ scope, environment }: RouterConstructorData) {
+async function userDel({ scope, environment }: RouterConstructorData & { scope: UserListScope[] }) {
   if (!environment || !scope) {
     throw new Error("Missing parameters");
   }
@@ -17,7 +18,6 @@ async function userDel({ scope, environment }: RouterConstructorData) {
     throw "[Error] No config device ID: config_id.";
   }
 
-  // @ts-expect-error user is not defined on sdk types
   const user_id = scope[0].user;
   if (!user_id) {
     throw new Error("User id not found");

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ async function InstallTemplate(templates: string[], replaceObj: any) {`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`for (const dashboard of dash_list) {`
`25`		`- let dash_info = (await Resources.dashboards.info(dashboard)) as Writeable<DashboardInfo> & { setup: {} };`
	`25`	`+ let dash_info = (await Resources.dashboards.info(dashboard)) as Writeable<DashboardInfo> & { setup: Record<string, unknown> };`
`26`	`26`	`const hidden_var = dash_info.tags?.find((x) => x.key === "hidden");`
`27`	`27`	`dash_info.visible = !hidden_var;`
`28`	`28`	`dash_info = replaceJSON(dash_info, replaceObj);`