changes requested in review

Author: bgelatti

plugins/tagoio-integration/src/back/Request.ts

@@ -9,6 +9,7 @@ async function createTCore(token: string, data: any) {
   try {
     const region = (await pluginStorage.get("region")) || "us-e1";
     const response = await axios({
+      //TODO: fix this import and check if works
       url: `${getConnectionURI.default.default(region).api}/tcore/instance`,
       method: "POST",
       headers: { token },
@@ -32,6 +33,7 @@ async function sendDataToTagoio(
   try {
     const region = (await pluginStorage.get("region")) || "us-e1";
     const response = await axios({
+      //TODO: fix this import and check if works
       url: `${getConnectionURI.default.default(region).api}/tcore/sse/${connId}`,
       method: "POST",
       headers: { token },

plugins/tagoio-integration/src/back/Server.ts

@@ -13,6 +13,7 @@ import {
   startRealtimeCommunication,
 } from "./RealtimeConnection.ts";
 import { createTCore, sendDataToTagoio } from "./Request.ts";
+import { regionsDefinition } from "@tago-io/sdk/lib/regions.js";
 
 let server: http.Server | null = null;
 
@@ -86,6 +87,11 @@ async function routeStartTCore(req: Request, res: Response) {
   const osInfo = await helpers.getOSInfo();
   const profileToken = "p-".concat(req.headers.token as string);
   const region = req.headers.region as string;
+  if (!regionsDefinition[region as keyof typeof regionsDefinition]) {
+    res.sendStatus(400);
+    return;
+  }
+
   await pluginStorage.set("region", region);
   const item = await pluginStorage.get("tcore").catch(() => null);
 

plugins/tagoio-integration/src/front/Auth/Auth.tsx

@@ -10,18 +10,7 @@ import InstanceName from "./InstanceName/InstanceName.tsx";
 import Otp from "./Otp/Otp.tsx";
 import OtpPicker from "./OtpPicker/OtpPicker.tsx";
 import Profiles from "./Profiles/Profiles.tsx";
-
-// Region configuration
-const REGIONS = {
-  "us-e1": {
-    label: "United States East 1",
-    apiUrl: "https://api.tago.io",
-  },
-  "eu-w1": {
-    label: "Europe West 1",
-    apiUrl: "https://api.eu-w1.tago.io",
-  },
-};
+import { REGIONS } from "./regions.ts";
 
 /**
  * Props.
@@ -63,7 +52,7 @@ function Auth(props: IAuthProps) {
   const { onSignIn, port } = props;
 
   // Get the API URL based on selected region
-  const API_URL = REGIONS[selectedRegion].apiUrl;
+  const apiUrl = REGIONS[selectedRegion].apiUrl;
 
   /**
    * Logs in.
@@ -82,7 +71,7 @@ function Auth(props: IAuthProps) {
 
         // logs in and gets the account
         const result = await axios.post(
-          `${API_URL}/account/login`,
+          `${apiUrl}/account/login`,
           {
             email,
             password,
@@ -114,7 +103,7 @@ function Auth(props: IAuthProps) {
         setLoading(false);
       }
     },
-    [email, password, loading, otpType, API_URL],
+    [email, password, loading, otpType, apiUrl],
   );
 
   /**
@@ -151,7 +140,7 @@ function Auth(props: IAuthProps) {
 
         // uses the account to get a profile token
         // logs in and gets the account
-        const tokenData = await axios.post(`${API_URL}/account/profile/token`, {
+        const tokenData = await axios.post(`${apiUrl}/account/profile/token`, {
           email,
           password,
           otp_type: lastPinCode ? otpType : undefined,
@@ -170,7 +159,7 @@ function Auth(props: IAuthProps) {
         setLoading(false);
       }
     },
-    [email, otpType, lastPinCode, password, API_URL],
+    [email, otpType, lastPinCode, password, apiUrl],
   );
 
   /**
@@ -205,14 +194,14 @@ function Auth(props: IAuthProps) {
       setContent("otp");
 
       if (newType !== "authenticator") {
-        await axios.post(`${API_URL}/account/login/otp`, {
+        await axios.post(`${apiUrl}/account/login/otp`, {
           email,
           password,
           otp_type: newType,
         });
       }
     },
-    [email, password, API_URL],
+    [email, password, apiUrl],
   );
 
   /**
@@ -246,7 +235,6 @@ function Auth(props: IAuthProps) {
               password={password}
               selectedRegion={selectedRegion}
               onChangeRegion={setSelectedRegion}
-              regions={REGIONS}
             />
           ) : content === "profiles" ? (
             // profile selection

plugins/tagoio-integration/src/front/Auth/Credentials/Credentials.tsx

@@ -3,6 +3,7 @@ import { type KeyboardEvent, useCallback, useRef, useState } from "react";
 // @ts-ignore
 import SVGTagoIO from "../../../../assets/tagoio-logo.svg";
 import * as Style from "./Credentials.style";
+import { REGIONS } from "../regions.ts";
 
 /**
  * Props interface
@@ -17,7 +18,6 @@ interface ICredentialsProps {
   onLogin: () => void;
   selectedRegion: string;
   onChangeRegion: (region: "us-e1" | "eu-w1") => void;
-  regions: Record<string, { label: string; apiUrl: string }>;
 }
 
 /**
@@ -33,7 +33,6 @@ function Credentials(props: ICredentialsProps) {
     onLogin,
     selectedRegion,
     onChangeRegion,
-    regions,
   } = props;
   const [emailError, setEmailError] = useState(false);
   const [passwordError, setPasswordError] = useState(false);
@@ -133,9 +132,9 @@ function Credentials(props: ICredentialsProps) {
             outline: "none",
           }}
         >
-          {Object.entries(regions).map(([value, config]) => (
-            <option key={value} value={value}>
-              {config.label}
+          {Object.entries(REGIONS).map(([regionKey, region]) => (
+            <option key={regionKey} value={regionKey}>
+              {region.label}
             </option>
           ))}
         </select>