feat(protocol): integrate signal service with shasta (#20270)

Co-authored-by: Gustavo Gonzalez <gustavo@taiko.xyz>
Co-authored-by: ggonzalez94 <17907743+ggonzalez94@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>
Co-authored-by: David <david@taiko.xyz>

Author: 6 people

.release-please-manifest.json

@@ -11,4 +11,4 @@
   "packages/taiko-client-rs": "2.0.0",
   "packages/taikoon-ui": "1.3.0",
   "packages/ui-lib": "1.0.0"
-}
+}

packages/protocol/CLAUDE.md

@@ -210,6 +210,7 @@ See inline comments for specific safety justifications on each unchecked block.
 Due to aggressive use of unchecked blocks throughout these contracts, developers **MUST** explicitly cast values to their proper types before performing mathematical operations when mixing different numeric types. Without explicit casts, Solidity may perform implicit conversions that could lead to unexpected results within unchecked blocks.
 
 **Example:**
+
 ```solidity
 // ✅ CORRECT - Explicit casting
 uint256(uint48Value) + uint256(anotherUint48)

packages/protocol/contracts/layer1/shasta/iface/IInbox.sol

@@ -15,6 +15,8 @@ interface IInbox {
         address codec;
         /// @notice The token used for bonds
         address bondToken;
+        /// @notice The signal service contract address
+        address signalService;
         /// @notice The proof verifier contract
         address proofVerifier;
         /// @notice The proposer checker contract
@@ -38,8 +40,6 @@ interface IInbox {
         uint16 forcedInclusionDelay;
         /// @notice The fee for forced inclusions in Gwei
         uint64 forcedInclusionFeeInGwei;
-        /// @notice The maximum number of checkpoints to store in ring buffer
-        uint16 maxCheckpointHistory;
         /// @notice The minimum delay between checkpoints in seconds
         /// @dev Must be less than or equal to finalization grace period
         uint16 minCheckpointDelay;

packages/protocol/contracts/layer1/shasta/impl/Inbox.sol

@@ -13,10 +13,9 @@ import { LibBlobs } from "../libs/LibBlobs.sol";
 import { LibBonds } from "src/shared/shasta/libs/LibBonds.sol";
 import { LibBondsL1 } from "../libs/LibBondsL1.sol";
 import { LibForcedInclusion } from "../libs/LibForcedInclusion.sol";
-import { LibCheckpointStore } from "src/shared/shasta/libs/LibCheckpointStore.sol";
 import { LibHashSimple } from "../libs/LibHashSimple.sol";
-import { ICheckpointStore } from "src/shared/shasta/iface/ICheckpointStore.sol";
 import { LibMath } from "src/shared/libs/LibMath.sol";
+import { ICheckpointStore } from "src/shared/shasta/iface/ICheckpointStore.sol";
 
 /// @title Inbox
 /// @notice Core contract for managing L2 proposals, proofs, verification and forced inclusion in
@@ -28,7 +27,7 @@ import { LibMath } from "src/shared/libs/LibMath.sol";
 ///      - Bond instruction processing for economic security
 ///      - Finalization of proven proposals with checkpoint rate limiting
 /// @custom:security-contact security@taiko.xyz
-contract Inbox is IInbox, IForcedInclusionStore, ICheckpointStore, EssentialContract {
+contract Inbox is IInbox, IForcedInclusionStore, EssentialContract {
     using LibAddress for address;
     using LibMath for uint48;
     using LibMath for uint256;
@@ -90,9 +89,6 @@ contract Inbox is IInbox, IForcedInclusionStore, ICheckpointStore, EssentialCont
     /// @notice The fee for forced inclusions in Gwei.
     uint64 internal immutable _forcedInclusionFeeInGwei;
 
-    /// @notice The maximum number of checkpoints to store in ring buffer.
-    uint16 internal immutable _maxCheckpointHistory;
-
     /// @notice The minimum delay between checkpoints in seconds.
     uint16 internal immutable _minCheckpointDelay;
 
@@ -133,9 +129,8 @@ contract Inbox is IInbox, IForcedInclusionStore, ICheckpointStore, EssentialCont
     /// @dev 2 slots used
     LibForcedInclusion.Storage private _forcedInclusionStorage;
 
-    /// @dev Storage for checkpoint management
-    /// @dev 2 slots used
-    LibCheckpointStore.Storage private _checkpointStorage;
+    /// @notice Signal service responsible for checkpoints
+    ICheckpointStore public immutable signalService;
 
     uint256[37] private __gap;
 
@@ -146,13 +141,14 @@ contract Inbox is IInbox, IForcedInclusionStore, ICheckpointStore, EssentialCont
     /// @notice Initializes the Inbox contract
     /// @param _config Configuration struct containing all constructor parameters
     constructor(IInbox.Config memory _config) {
-        require(_config.maxCheckpointHistory != 0, LibCheckpointStore.InvalidMaxCheckpointHistory());
+        require(_config.signalService != address(0), ZERO_ADDRESS());
         require(_config.ringBufferSize != 0, RingBufferSizeZero());
 
         _codec = _config.codec;
         _bondToken = IERC20(_config.bondToken);
         _proofVerifier = IProofVerifier(_config.proofVerifier);
         _proposerChecker = IProposerChecker(_config.proposerChecker);
+        signalService = ICheckpointStore(_config.signalService);
         _provingWindow = _config.provingWindow;
         _extendedProvingWindow = _config.extendedProvingWindow;
         _maxFinalizationCount = _config.maxFinalizationCount;
@@ -162,7 +158,6 @@ contract Inbox is IInbox, IForcedInclusionStore, ICheckpointStore, EssentialCont
         _minForcedInclusionCount = _config.minForcedInclusionCount;
         _forcedInclusionDelay = _config.forcedInclusionDelay;
         _forcedInclusionFeeInGwei = _config.forcedInclusionFeeInGwei;
-        _maxCheckpointHistory = _config.maxCheckpointHistory;
         _minCheckpointDelay = _config.minCheckpointDelay;
         _permissionlessInclusionMultiplier = _config.permissionlessInclusionMultiplier;
         _compositeKeyVersion = _config.compositeKeyVersion;
@@ -331,6 +326,7 @@ contract Inbox is IInbox, IForcedInclusionStore, ICheckpointStore, EssentialCont
         config_ = IInbox.Config({
             codec: _codec,
             bondToken: address(_bondToken),
+            signalService: address(signalService),
             proofVerifier: address(_proofVerifier),
             proposerChecker: address(_proposerChecker),
             provingWindow: _provingWindow,
@@ -342,28 +338,12 @@ contract Inbox is IInbox, IForcedInclusionStore, ICheckpointStore, EssentialCont
             minForcedInclusionCount: _minForcedInclusionCount,
             forcedInclusionDelay: _forcedInclusionDelay,
             forcedInclusionFeeInGwei: _forcedInclusionFeeInGwei,
-            maxCheckpointHistory: _maxCheckpointHistory,
             minCheckpointDelay: _minCheckpointDelay,
             permissionlessInclusionMultiplier: _permissionlessInclusionMultiplier,
             compositeKeyVersion: _compositeKeyVersion
         });
     }
 
-    /// @inheritdoc ICheckpointStore
-    function getCheckpoint(uint48 _offset) external view returns (Checkpoint memory) {
-        return LibCheckpointStore.getCheckpoint(_checkpointStorage, _offset, _maxCheckpointHistory);
-    }
-
-    /// @inheritdoc ICheckpointStore
-    function getLatestCheckpointBlockNumber() external view returns (uint48) {
-        return LibCheckpointStore.getLatestCheckpointBlockNumber(_checkpointStorage);
-    }
-
-    /// @inheritdoc ICheckpointStore
-    function getNumberOfCheckpoints() external view returns (uint48) {
-        return LibCheckpointStore.getNumberOfCheckpoints(_checkpointStorage);
-    }
-
     // ---------------------------------------------------------------
     // Internal Functions
     // ---------------------------------------------------------------
@@ -945,9 +925,7 @@ contract Inbox is IInbox, IForcedInclusionStore, ICheckpointStore, EssentialCont
             bytes32 checkpointHash = _hashCheckpoint(_checkpoint);
             require(checkpointHash == _expectedCheckpointHash, CheckpointMismatch());
 
-            LibCheckpointStore.saveCheckpoint(
-                _checkpointStorage, _checkpoint, _maxCheckpointHistory
-            );
+            signalService.saveCheckpoint(_checkpoint);
             _coreState.lastCheckpointTimestamp = uint48(block.timestamp);
         } else {
             require(

packages/protocol/contracts/layer1/shasta/impl/ShastaDevnetInbox.sol

@@ -23,7 +23,6 @@ contract ShastaDevnetInbox is InboxOptimized2 {
     ///                     = (86400 * 2) / 12 / 6
     ///                     = 2400
     uint64 private constant _RING_BUFFER_SIZE = 2400;
-    uint16 private constant _MAX_CHECKPOINT_HISTORY = 256;
 
     // ---------------------------------------------------------------
     // Constructor
@@ -33,11 +32,13 @@ contract ShastaDevnetInbox is InboxOptimized2 {
         address _codec,
         address _proofVerifier,
         address _proposerChecker,
-        address _taikoToken
+        address _taikoToken,
+        address _signalService
     )
         InboxOptimized2(
             IInbox.Config({
                 bondToken: _taikoToken,
+                signalService: _signalService,
                 codec: _codec,
                 proofVerifier: _proofVerifier,
                 proposerChecker: _proposerChecker,
@@ -50,7 +51,6 @@ contract ShastaDevnetInbox is InboxOptimized2 {
                 minForcedInclusionCount: 1,
                 forcedInclusionDelay: 0,
                 forcedInclusionFeeInGwei: 10_000_000, // 0.01 ETH
-                maxCheckpointHistory: _MAX_CHECKPOINT_HISTORY,
                 minCheckpointDelay: 384 seconds, // 1 epoch
                 permissionlessInclusionMultiplier: 5,
                 compositeKeyVersion: 1

packages/protocol/contracts/layer1/shasta/impl/ShastaMainnetInbox.sol

@@ -25,8 +25,6 @@ contract ShastaMainnetInbox is InboxOptimized2 {
     ///                     = 2400
     uint64 private constant _RING_BUFFER_SIZE = 2400;
 
-    uint16 private constant _MAX_CHECKPOINT_HISTORY = 256;
-
     // ---------------------------------------------------------------
     // Constructor
     // ---------------------------------------------------------------
@@ -39,6 +37,7 @@ contract ShastaMainnetInbox is InboxOptimized2 {
         InboxOptimized2(
             IInbox.Config({
                 bondToken: LibL1Addrs.TAIKO_TOKEN,
+                signalService: LibL1Addrs.SIGNAL_SERVICE,
                 codec: _codec,
                 proofVerifier: _proofVerifier,
                 proposerChecker: _proposerChecker,
@@ -51,7 +50,6 @@ contract ShastaMainnetInbox is InboxOptimized2 {
                 minForcedInclusionCount: 1,
                 forcedInclusionDelay: 100,
                 forcedInclusionFeeInGwei: 10_000_000, // 0.01 ETH
-                maxCheckpointHistory: _MAX_CHECKPOINT_HISTORY,
                 minCheckpointDelay: 384 seconds, // 1 epoch
                 permissionlessInclusionMultiplier: 5,
                 compositeKeyVersion: 1

packages/protocol/contracts/layer2/based/ShastaAnchor.sol

@@ -3,8 +3,8 @@ pragma solidity ^0.8.24;
 
 import { ECDSA } from "@openzeppelin/contracts/utils/cryptography/ECDSA.sol";
 import { PacayaAnchor } from "./PacayaAnchor.sol";
-import { LibCheckpointStore } from "src/shared/shasta/libs/LibCheckpointStore.sol";
 import { ICheckpointStore } from "src/shared/shasta/iface/ICheckpointStore.sol";
+import { ISignalServiceShasta } from "src/shared/shasta/iface/ISignalServiceShasta.sol";
 import { IBondManager as IShastaBondManager } from "./IBondManager.sol";
 import { LibBonds } from "src/shared/shasta/libs/LibBonds.sol";
 
@@ -18,7 +18,7 @@ import { LibBonds } from "src/shared/shasta/libs/LibBonds.sol";
 ///      - State tracking for multi-block proposals
 ///      - Checkpoint storage for L1 block data
 /// @custom:security-contact security@taiko.xyz
-abstract contract ShastaAnchor is PacayaAnchor, ICheckpointStore {
+abstract contract ShastaAnchor is PacayaAnchor {
     // ---------------------------------------------------------------
     // Structs
     // ---------------------------------------------------------------
@@ -59,9 +59,6 @@ abstract contract ShastaAnchor is PacayaAnchor, ICheckpointStore {
     /// @notice Contract managing bond deposits, withdrawals, and transfers.
     IShastaBondManager public immutable bondManager;
 
-    /// @notice Maximum number of checkpoints to store in ring buffer.
-    uint16 public immutable maxCheckpointHistory;
-
     // ---------------------------------------------------------------
     // State variables
     // ---------------------------------------------------------------
@@ -73,12 +70,8 @@ abstract contract ShastaAnchor is PacayaAnchor, ICheckpointStore {
     mapping(uint256 blockId => uint256 endOfSubmissionWindowTimestamp) public
         blockIdToEndOfSubmissionWindowTimeStamp;
 
-    /// @dev Storage for checkpoint management
-    /// @dev 2 slots used
-    LibCheckpointStore.Storage internal _checkpointStorage;
-
     /// @notice Storage gap for upgrade safety.
-    uint256[44] private __gap;
+    uint256[46] private __gap;
 
     // ---------------------------------------------------------------
     // Constructor
@@ -90,27 +83,23 @@ abstract contract ShastaAnchor is PacayaAnchor, ICheckpointStore {
     /// @param _signalService The address of the signal service.
     /// @param _pacayaForkHeight The block height at which the Pacaya fork is activated.
     /// @param _shastaForkHeight The block height at which the Shasta fork is activated.
-    /// @param _maxCheckpointHistory The maximum number of checkpoints to store.
     /// @param _bondManager The address of the bond manager.
     constructor(
         uint48 _livenessBondGwei,
         uint48 _provabilityBondGwei,
         address _signalService,
         uint64 _pacayaForkHeight,
         uint64 _shastaForkHeight,
-        uint16 _maxCheckpointHistory,
         IShastaBondManager _bondManager
     )
         PacayaAnchor(_signalService, _pacayaForkHeight, _shastaForkHeight)
     {
         require(
             _shastaForkHeight == 0 || _shastaForkHeight > _pacayaForkHeight, InvalidForkHeight()
         );
-        require(_maxCheckpointHistory != 0, LibCheckpointStore.InvalidMaxCheckpointHistory());
 
         livenessBondGwei = _livenessBondGwei;
         provabilityBondGwei = _provabilityBondGwei;
-        maxCheckpointHistory = _maxCheckpointHistory;
         bondManager = _bondManager;
     }
 
@@ -186,15 +175,13 @@ abstract contract ShastaAnchor is PacayaAnchor, ICheckpointStore {
 
         // Process new L1 anchor data
         if (_anchorBlockNumber > previousState_.anchorBlockNumber) {
-            // Save L1 block data
-            LibCheckpointStore.saveCheckpoint(
-                _checkpointStorage,
+            // Save L1 block data to signal service
+            ISignalServiceShasta(address(signalService)).saveCheckpoint(
                 ICheckpointStore.Checkpoint({
                     blockNumber: _anchorBlockNumber,
                     blockHash: _anchorBlockHash,
                     stateRoot: _anchorStateRoot
-                }),
-                maxCheckpointHistory
+                })
             );
 
             // Update state atomically
@@ -237,21 +224,6 @@ abstract contract ShastaAnchor is PacayaAnchor, ICheckpointStore {
         return _getDesignatedProver(_proposalId, _proposer, _proverAuth);
     }
 
-    /// @inheritdoc ICheckpointStore
-    function getCheckpoint(uint48 _offset) external view returns (Checkpoint memory) {
-        return LibCheckpointStore.getCheckpoint(_checkpointStorage, _offset, maxCheckpointHistory);
-    }
-
-    /// @inheritdoc ICheckpointStore
-    function getLatestCheckpointBlockNumber() external view returns (uint48) {
-        return LibCheckpointStore.getLatestCheckpointBlockNumber(_checkpointStorage);
-    }
-
-    /// @inheritdoc ICheckpointStore
-    function getNumberOfCheckpoints() external view returns (uint48) {
-        return LibCheckpointStore.getNumberOfCheckpoints(_checkpointStorage);
-    }
-
     // ---------------------------------------------------------------
     // Private functions
     // ---------------------------------------------------------------

packages/protocol/contracts/layer2/based/TaikoAnchor.sol

@@ -23,7 +23,6 @@ contract TaikoAnchor is ShastaAnchor {
         address _signalService,
         uint64 _pacayaForkHeight,
         uint64 _shastaForkHeight,
-        uint16 _maxCheckpointHistory,
         address _bondManager
     )
         ShastaAnchor(
@@ -32,7 +31,6 @@ contract TaikoAnchor is ShastaAnchor {
             _signalService,
             _pacayaForkHeight,
             _shastaForkHeight,
-            _maxCheckpointHistory,
             IShastaBondManager(_bondManager)
         )
     { }

packages/protocol/contracts/shared/shasta/iface/ICheckpointStore.sol

@@ -11,6 +11,7 @@ interface ICheckpointStore {
 
     /// @notice Represents a synced checkpoint
     struct Checkpoint {
+        /// @notice The block number associated with the checkpoint.
         uint48 blockNumber;
         /// @notice The block hash for the end (last) L2 block in this proposal.
         bytes32 blockHash;
@@ -32,17 +33,12 @@ interface ICheckpointStore {
     // External Functions
     // ---------------------------------------------------------------
 
-    /// @notice Gets a checkpoint by index
-    /// @param _offset The offset of the checkpoint. Use 0 for the last checkpoint, 1 for the
-    /// second last, etc.
-    /// @return _ The checkpoint
-    function getCheckpoint(uint48 _offset) external view returns (Checkpoint memory);
-
-    /// @notice Gets the latest checkpoint number
-    /// @return _ The latest checkpoint number
-    function getLatestCheckpointBlockNumber() external view returns (uint48);
+    /// @notice Saves a checkpoint
+    /// @param _checkpoint The checkpoint data to persist
+    function saveCheckpoint(Checkpoint calldata _checkpoint) external;
 
-    /// @notice Gets the number of checkpoints
-    /// @return _ The number of checkpoints
-    function getNumberOfCheckpoints() external view returns (uint48);
+    /// @notice Gets a checkpoint by its block number
+    /// @param _blockNumber The block number associated with the checkpoint
+    /// @return _ The checkpoint
+    function getCheckpoint(uint48 _blockNumber) external view returns (Checkpoint memory);
 }