Fix clippy warnings

Author: morr0ne

src/commands/build.rs

@@ -17,7 +17,7 @@ use xz2::read::XzDecoder;
 
 use crate::{
     check_hash, create_tarball,
-    package::{Info, Package, Source, StepVariant},
+    package::{Package, Source, StepVariant},
 };
 
 pub async fn build() -> Result<()> {
@@ -46,7 +46,7 @@ pub async fn build() -> Result<()> {
     }
 
     for source in &package.sources {
-        let file_path = fetch_and_verify_source(&client, source, &info).await?;
+        let file_path = fetch_and_verify_source(&client, source).await?;
         extract_source(&file_path)?;
     }
 
@@ -68,7 +68,7 @@ pub async fn build() -> Result<()> {
                 }
             }
             StepVariant::Move { path } => {
-                fs::create_dir_all(&path)?;
+                fs::create_dir_all(path)?;
 
                 working_dir = path.into();
             }
@@ -81,7 +81,7 @@ pub async fn build() -> Result<()> {
     Ok(())
 }
 
-async fn fetch_and_verify_source(client: &Client, source: &Source, info: &Info) -> Result<PathBuf> {
+async fn fetch_and_verify_source(client: &Client, source: &Source) -> Result<PathBuf> {
     let url: Url = source.url.as_str().try_into()?;
 
     let target_path = PathBuf::from(url.path_segments().unwrap().last().unwrap());

src/lib.rs

@@ -1,24 +1,18 @@
 use std::{
-    borrow::Cow,
     env::current_dir,
     fs::{self, File},
     path::Path,
-    sync::LazyLock,
 };
 
 use anyhow::{anyhow, bail, Result};
 use flate2::{write::GzEncoder, Compression};
-use regex::Regex;
 use sha2::{Digest, Sha256 as Sha256Hasher};
 use tracing::info;
 
 pub mod commands;
 pub mod package;
 
-use package::{Info, Package};
-
-static VARIABLE_REGEX: LazyLock<Regex> =
-    LazyLock::new(|| Regex::new(r"%\{([a-zA-Z0-9_]*)\}").expect("invalid regex"));
+use package::Package;
 
 pub fn check_hash<P: AsRef<Path>>(path: P, hash: &str) -> Result<bool> {
     let file = fs::read(path)?;

src/package.rs

@@ -128,7 +128,7 @@ impl Package {
         for step in package.steps.iter_mut() {
             match &mut step.variant {
                 StepVariant::Command { command, .. } => {
-                    *command = replace_vars(command.as_str(), &variables).into();
+                    *command = replace_vars(command.as_str(), &variables);
                 }
                 StepVariant::Move { path } => {
                     *path = replace_vars(path.as_str(), &variables).into();
@@ -140,7 +140,7 @@ impl Package {
     }
 }
 
-fn replace_vars<'h>(haystack: &'h str, variables: &HashMap<&str, &str>) -> String {
+fn replace_vars(haystack: &str, variables: &HashMap<&str, &str>) -> String {
     VARIABLE_REGEX
         .replace_all(haystack, |caps: &Captures| {
             variables.get(&caps[1]).expect("Unknown variable") // FIXME: error handling