src: replace most memsets with initializers

Author: Akaricchi

src/aniplayer.c

@@ -12,8 +12,9 @@
 #include "stageobjects.h"
 
 void aniplayer_create(AniPlayer *plr, Animation *ani, const char *startsequence) {
-	memset(plr,0,sizeof(AniPlayer));
-	plr->ani = ani;
+	*plr = (typeof(*plr)) {
+		.ani = ani,
+	};
 
 	aniplayer_queue(plr,startsequence,0);
 }

src/audio/stream/mixer.c

@@ -87,7 +87,7 @@ bool mixer_group_get_channels_range(AudioChannelGroup group, int *first, int *la
 // BEGIN INIT/SHUTDOWN
 
 bool mixer_init(Mixer *mx, const AudioStreamSpec *spec) {
-	memset(mx, 0, sizeof(*mx));
+	*mx = (typeof(*mx)) {};
 
 	if(!splayer_init(mx->players + CHANGROUP_BGM, MIXER_NUM_BGM_CHANNELS, spec)) {
 		log_error("splayer_init() failed");
@@ -118,7 +118,7 @@ void mixer_shutdown(Mixer *mx) {
 
 		if(plr->channels) {
 			splayer_shutdown(plr);
-			memset(plr, 0, sizeof(*plr));
+			*plr = (typeof(*plr)) {};
 		}
 	}
 }

src/audio/stream/player.c

@@ -25,7 +25,7 @@ union audio_buffer {
 };
 
 bool splayer_init(StreamPlayer *plr, int num_channels, const AudioStreamSpec *dst_spec) {
-	memset(plr, 0, sizeof(*plr));
+	*plr = (typeof(*plr)) {};
 
 	if(dst_spec->sample_format != SDL_AUDIO_F32) {
 		log_error("Unsupported audio format: 0x%4x", dst_spec->sample_format);

src/boss.c

@@ -1427,15 +1427,15 @@ void boss_start_next_attack(Boss *b, Attack *a) {
 Attack *boss_add_attack(Boss *boss, AttackType type, const char *name, float timeout, int hp, BossRule draw_rule) {
 	assert(boss->acount < BOSS_MAX_ATTACKS);
 
-	Attack *a = &boss->attacks[boss->acount];
-	boss->acount += 1;
-	memset(a, 0, sizeof(Attack));
-	a->type = type;
-	a->name = name;
-	a->timeout = timeout * FPS;
-	a->maxhp = hp;
-	a->hp = hp;
-	a->draw_rule = draw_rule;
+	Attack *a = &boss->attacks[boss->acount++];
+	*a = (typeof(*a)) {
+		.type = type,
+		.name = name,
+		.timeout = timeout * FPS,
+		.maxhp = hp,
+		.hp = hp,
+		.draw_rule = draw_rule,
+	};
 
 	COEVENT_INIT_ARRAY(a->events);
 

src/cli.c

@@ -104,7 +104,7 @@ int cli_args(int argc, char **argv, CLIAction *a) {
 		{}
 	};
 
-	memset(a, 0, sizeof(*a));
+	*a = (typeof(*a)) {};
 
 	int nopts = ARRAY_SIZE(taisei_opts);
 	struct option opts[nopts];

src/coroutine/cosched.c

@@ -12,7 +12,7 @@
 #include "hashtable.h"
 
 void cosched_init(CoSched *sched) {
-	memset(sched, 0, sizeof(*sched));
+	*sched = (typeof(*sched)) {};
 }
 
 CoTask *_cosched_new_task(CoSched *sched, CoTaskFunc func, void *arg, size_t arg_size, bool is_subtask, CoTaskDebugInfo debug) {
@@ -136,5 +136,5 @@ void cosched_finish(CoSched *sched) {
 	finish_task_list(&sched->pending_tasks);
 	assert(!sched->tasks.first);
 	assert(!sched->pending_tasks.first);
-	memset(sched, 0, sizeof(*sched));
+	*sched = (typeof(*sched)) {};
 }

src/coroutine/cotask.c

@@ -577,8 +577,9 @@ void *cotask_yield(void *arg) {
 
 static inline CoWaitResult cotask_wait_init(CoTaskData *task_data, char wait_type) {
 	CoWaitResult wr = task_data->wait.result;
-	memset(&task_data->wait, 0, sizeof(task_data->wait));
-	task_data->wait.wait_type = wait_type;
+	task_data->wait = (typeof(task_data->wait)) {
+		.wait_type = wait_type,
+	};
 	return wr;
 }
 

src/credits.c

@@ -301,11 +301,10 @@ static void resize_fb(void *userdata, IntExtent *out_dimensions, FloatRect *out_
 }
 
 static void credits_init(void) {
-	memset(&credits, 0, sizeof(credits));
+	credits = (typeof(credits)) {};
 	stage3d_init(&stage_3d_context, 32);
 
-	FBAttachmentConfig a[2];
-	memset(a, 0, sizeof(a));
+	FBAttachmentConfig a[2] = {};
 
 	for(int i = 0; i < ARRAY_SIZE(a); i++) {
 		a[i].tex_params.filter.min = TEX_FILTER_LINEAR;

src/dialog.c

@@ -13,7 +13,7 @@
 #include "resource/font.h"
 
 void dialog_init(Dialog *d) {
-	memset(d, 0, sizeof(*d));
+	*d = (typeof(*d)) {};
 	d->state = DIALOG_STATE_IDLE;
 	d->text.current = &d->text.buffers[0];
 	d->text.fading_out = &d->text.buffers[1];
@@ -31,18 +31,14 @@ void dialog_deinit(Dialog *d) {
 }
 
 void dialog_add_actor(Dialog *d, DialogActor *a, const char *name, DialogSide side) {
-	memset(a, 0, sizeof(*a));
-	a->name = name;
-	a->face = "normal";
-	a->side = side;
-	a->target_opacity = 1;
-	a->composite_dirty = true;
-
-	if(side == DIALOG_SIDE_RIGHT) {
-		a->speech_color = *RGB(0.6, 0.6, 1.0);
-	} else {
-		a->speech_color = *RGB(1.0, 1.0, 1.0);
-	}
+	*a = (typeof(*a)) {
+		.name = name,
+		.face = "normal",
+		.side = side,
+		.target_opacity = 1,
+		.composite_dirty = true,
+		.speech_color = (side == DIALOG_SIDE_RIGHT) ? *RGB(0.6, 0.6, 1.0) : *RGB(1.0, 1.0, 1.0),
+	};
 
 	alist_append(&d->actors, a);
 }

src/dynarray.c

@@ -23,7 +23,7 @@ void _dynarray_free_data(dynarray_size_t sizeof_element, DynamicArray *darr) {
 	if(darr->capacity) {
 		DYNARRAY_DEBUG(darr, "%u/%u", darr->num_elements, darr->capacity);
 	}
-	memset(darr, 0, sizeof(*darr));
+	*darr = (typeof(*darr)) {};
 }
 
 INLINE void _dynarray_resize(dynarray_size_t sizeof_element, DynamicArray *darr, dynarray_size_t capacity) {