Skip to content

Commit 9a447fa

Browse files
authored
Merge pull request #14 from takenet/feature/avatar-separation
Fix avatar border radius and split component "AvatarArray" to a new "Avatar"
2 parents 1a1e615 + 0085614 commit 9a447fa

7 files changed

Lines changed: 28 additions & 24 deletions

File tree

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"scripts": {
77
"start": "./node_modules/.bin/webpack-dev-server --port 3000",
88
"build": "./node_modules/.bin/webpack",
9+
"watch": "./node_modules/.bin/webpack --watch --progress",
910
"commit": "./node_modules/.bin/git-cz",
1011
"semantic-release": "semantic-release --prepare && npm publish && semantic-release post"
1112
},
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
import './Avatar.scss';
2+
import template from './AvatarView.html';
3+
import angular from 'core/angular';
4+
5+
export const AvatarComponent = angular
6+
.module('blipComponents.avatar', [])
7+
.component('avatar', {
8+
controllerAs: '$ctrl',
9+
bindings: {
10+
user: '<?'
11+
},
12+
template,
13+
})
14+
.name;

src/components/avatarArray/AvatarArray.scss renamed to src/components/avatar/Avatar.scss

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
.avatar-array {
2-
& > tooltip {
1+
.avatar {
2+
tooltip {
33
width: 55px;
44
height: 55px;
55
cursor: default;
@@ -21,25 +21,10 @@
2121
img {
2222
width: 55px;
2323
height: 55px;
24+
border-radius: 50%;
2425
}
2526
}
26-
// & > span {
27-
// cursor: default;
28-
// padding: 2px;
29-
// height: 55px;
30-
// width: 55px;
31-
// // border: 1px solid red;
32-
// background: white;
33-
// border-radius: 50%;
34-
// position: absolute;
35-
// left: 0;
36-
// transition: left 1s linear;
3727

38-
// img {
39-
// width: 55px;
40-
// height: 55px;
41-
// }
42-
// }
4328
letter-avatar {
4429
margin: 0;
4530
height: 50px;
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
<span class="avatar">
2+
<span tooltips tooltip-template="{{$ctrl.$ctrl.user.tooltipName}}" tooltip-side="bottom" tooltip-class="small">
3+
<img ng-if="$ctrl.user.photoUri" ng-src="{{$ctrl.user.photoUri}}" alt="{{$ctrl.user.fullName}}">
4+
<letter-avatar ng-if="!$ctrl.user.photoUri" class="account-editing-avatar ml4" text="$ctrl.user.fullName"></letter-avatar>
5+
</span>
6+
</span>

src/components/avatarArray/AvatarArray.component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import './AvatarArray.scss';
21
import template from './AvatarArrayView.html';
32
import angular from 'core/angular';
43

@@ -10,7 +9,7 @@ class AvatarArray {
109
this.$scope.$watch('$ctrl.members', (newValue, oldValue) => {
1110
setTimeout(() => {
1211
let array = Array.from(
13-
document.querySelectorAll('.avatar-array > tooltip'),
12+
document.querySelectorAll('.avatar-array tooltip'),
1413
) as Element[];
1514
if (this.limit) {
1615
array = array.slice(0, this.limit);
Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
11
<div class="avatar-array">
2-
<span tooltips tooltip-template="{{member.tooltipName}}" tooltip-side="bottom" tooltip-class="small" ng-repeat="member in $ctrl.members">
3-
<img ng-if="member.photoUri" ng-src="{{member.photoUri}}" alt="{{member.fullName}}">
4-
<letter-avatar ng-if="!member.photoUri" class="account-editing-avatar ml4" text="member.fullName"></letter-avatar>
5-
</span>
2+
<avatar user="member" ng-repeat="member in $ctrl.members"></avatar>
63
</div>

src/components/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import angular from 'core/angular';
22
import { accordion } from './accordion';
33
import { AnalysisInfoComponent } from './analysisInfo/analysisInfo.component';
4+
import { AvatarComponent } from './avatar/avatar.component';
45
import { AvatarArrayComponent } from './avatarArray/avatarArray.component';
56
import { ActionsBarComponent } from './actionsBar/actionsBar.component';
67
import { AddRemoveComponent } from './addRemove/addRemove.component';
@@ -74,6 +75,7 @@ export const ComponentsModule = angular
7475
.module('ComponentsModule', [
7576
accordion,
7677
AnalysisInfoComponent,
78+
AvatarComponent,
7779
AvatarArrayComponent,
7880
ActionsBarComponent,
7981
AddRemoveComponent,

0 commit comments

Comments
 (0)