-
Notifications
You must be signed in to change notification settings - Fork 541
Open
Description
In lock_test.go, settings of lock TTL are shrunk together to speed up tests:
func init() {
// Speed up tests.
defaultLockTTL = 3
maxLockTTL = 120
ttlFactor = 6
oracleUpdateInterval = 2
}
However, the remaining code still applies millisecond while computing elapsed time (ex.2pc.go/txnLockTTL), which will add a relatively large bias on the basic formula ttl = ttlFactor * sqrt(sizeInMiB).
In addition, ttlEquals ignores case that x < y, where float(x - y) will result in a wrong answer given x and y of uint type.
Metadata
Metadata
Assignees
Labels
No labels