fix: Sanitize URLs to remove prepended dots in allocator and client services (#199)

Author: eberrigan

packages/allocator/pyproject.toml

@@ -24,7 +24,7 @@ description = "VM Allocator Service Package for Lablink"
 name = "lablink-allocator-service"
 readme = "README.md"
 requires-python = ">=3.9"
-version = "0.0.3a1"
+version = "0.0.3a2"
 
 [project.optional-dependencies]
 dev = ["twine", "build", "pytest", "ruff", "pytest-cov"]

packages/allocator/src/lablink_allocator_service/utils/config_helpers.py

@@ -74,6 +74,10 @@ def get_allocator_url(cfg, allocator_ip: str) -> Tuple[str, str]:
         host = allocator_ip
 
     base_url = f"{protocol}://{host}"
+
+    # Sanitize URL to remove prepended dots
+    base_url = base_url.replace("://.", "://")
+
     return base_url, protocol
 
 

packages/client/pyproject.toml

@@ -22,7 +22,7 @@ keywords = ["vm", "docker", "postgres", "tutorial", "AWS"]
 name = "lablink-client-service"
 readme = "README.md"
 requires-python = ">=3.8"
-version = "0.0.8a2"
+version = "0.0.8a3"
 
 [project.optional-dependencies]
 dev = ["twine", "build", "pytest", "ruff", "pytest-cov"]

packages/client/src/lablink_client_service/check_gpu.py

@@ -22,7 +22,8 @@ def check_gpu_health(allocator_url: str, interval: int = 20):
     """
     logger.debug("Starting GPU health check...")
     last_status = None
-    base_url = allocator_url.rstrip('/')
+    base_url = allocator_url.rstrip("/")
+    base_url = base_url.replace("://.", "://")
 
     while True:
         curr_status = None
@@ -105,6 +106,8 @@ def main(cfg: Config) -> None:
     else:
         allocator_url = f"http://{cfg.allocator.host}:{cfg.allocator.port}"
 
+    allocator_url_env = allocator_url_env.replace("://.", "://")
+
     check_gpu_health(allocator_url=allocator_url)
 
 

packages/client/src/lablink_client_service/update_inuse_status.py

@@ -113,11 +113,13 @@ def main(cfg: Config) -> None:
     # otherwise use host:port with HTTP
     allocator_url = os.getenv("ALLOCATOR_URL")
     if allocator_url:
-        base_url = allocator_url.rstrip('/')
+        base_url = allocator_url.rstrip("/")
     else:
         base_url = f"http://{cfg.allocator.host}:{cfg.allocator.port}"
     url = f"{base_url}/api/update_inuse_status"
 
+    url = url.replace("://.", "://")
+
     # Start listening for the process
     listen_for_process(
         process_name=cfg.client.software,