chore: remove dead code

Delete provably unused items (OverlayData, BLOCK_SHAPE_TABLE, unused
serpentine coefficients) and drop stale allow(dead_code) attributes
from items that are now in use. The one genuinely test-only helper
(FrameBuffer::max_brightness) is narrowed to
cfg_attr(not(test), allow(dead_code)).

Author: tamirelazar

src/app/runner.rs

@@ -52,31 +52,6 @@ use memory_stats::memory_stats;
 /// Target frame time in milliseconds for 30 FPS (33.333ms)
 const TARGET_FRAME_TIME_MS: f32 = 33.333;
 
-/// Data structure holding all overlay states for rendering.
-#[derive(Default)]
-#[allow(dead_code)]
-#[allow(clippy::type_complexity)]
-struct OverlayData {
-    pause_logo: Option<RenderedOverlay>,
-    pause_logo_pos: (usize, usize),
-    controls: Option<RenderedOverlay>,
-    controls_pos: (usize, usize),
-    status: Option<(String, usize, Vec<(usize, RgbColor)>)>,
-    notification: Option<(RenderedOverlay, usize, usize)>,
-    dashboard: Option<RenderedOverlay>,
-    dashboard_pos: (usize, usize),
-    config_browser: Option<RenderedOverlay>,
-    config_browser_pos: (usize, usize),
-    config_save: Option<RenderedOverlay>,
-    config_save_pos: (usize, usize),
-    keyboard_hints: Option<RenderedOverlay>,
-    keyboard_hints_pos: (usize, usize),
-    preset_comparison: Option<RenderedOverlay>,
-    preset_comparison_pos: (usize, usize),
-    palette_editor: Option<RenderedOverlay>,
-    palette_editor_pos: (usize, usize),
-}
-
 /// Updates food persistence attractors with fade-out effect.
 ///
 /// Gradually reduces the strength of food attractors over time using

src/config_manager.rs

@@ -435,7 +435,6 @@ impl SavedConfig {
     /// This function is part of the public API but currently unused in the main application.
     /// It is retained for future use in configuration management features like
     /// "Restart with saved config" or "Export config to file".
-    #[allow(dead_code)]
     pub fn to_sim_config(&self) -> Result<SimConfig, String> {
         let diffusion_kernel = parse_diffusion_kernel(&self.diffusion_kernel)?;
         let _init_mode = parse_init_mode(&self.init_mode)?;
@@ -534,7 +533,6 @@ fn parse_diffusion_kernel(s: &str) -> Result<DiffusionKernel, String> {
 ///
 /// This function is part of the configuration parsing API but currently unused.
 /// It is retained for future use in saved configuration loading.
-#[allow(dead_code)]
 fn parse_init_mode(s: &str) -> Result<InitMode, String> {
     match s.to_lowercase().as_str() {
         "random" => Ok(InitMode::Random),
@@ -550,7 +548,6 @@ fn parse_init_mode(s: &str) -> Result<InitMode, String> {
     }
 }
 
-#[allow(dead_code)]
 fn parse_charset(s: &str) -> Result<Charset, String> {
     match s.to_lowercase().as_str() {
         "halfblock" => Ok(Charset::HalfBlock),
@@ -664,7 +661,6 @@ pub fn save_config(config: SavedConfig) -> Result<(), String> {
 /// This function is part of the public API but currently unused in the main application.
 /// It is retained for future use in configuration management features like
 /// "Load saved preset by name" or CLI config restoration.
-#[allow(dead_code)]
 pub fn load_config(name: &str) -> Result<SavedConfig, String> {
     let config_file = load_config_file()?;
 

src/render/adaptive_brightness.rs

@@ -1,5 +1,3 @@
-#![allow(dead_code)]
-
 #[derive(Debug, Clone)]
 /// Manages adaptive brightness normalization to prevent screen flickering.
 ///

src/render/charset.rs

@@ -934,124 +934,6 @@ pub fn map_shape_braille(tl: f32, tr: f32, bl: f32, br: f32, threshold: f32) ->
     char::from_u32(0x2800 + pattern as u32).unwrap_or(' ')
 }
 
-// ===== Shape-Vector Block Rendering =====
-//
-// Extends HalfBlock mode from brightness-only vertical fill (▁▂▃▄▅▆▇█)
-// to shape-aware selection from ~23 Unicode block elements including
-// quadrant blocks (▖▗▘▝), half blocks (▀▄▌▐), diagonals (▚▞),
-// and three-quarter blocks (▙▛▜▟).
-//
-// Uses the same 6D shape vector matching as ASCII mode.
-
-/// Shape vector table for Unicode block element characters.
-///
-/// Each entry maps a block character to its 2×3 spatial fill pattern,
-/// computed from the geometric coverage of each character within the cell.
-/// Note: Currently unused since `map_shape_block` uses threshold-based
-/// quadrant matching for consistent tiling. Retained for reference.
-#[allow(dead_code)]
-const BLOCK_SHAPE_TABLE: [ShapeEntry; 23] = [
-    // === Empty ===
-    ShapeEntry {
-        ch: ' ',
-        vector: [0.00, 0.00, 0.00, 0.00, 0.00, 0.00],
-    },
-    // === Vertical fill from bottom (lower block elements) ===
-    ShapeEntry {
-        ch: '\u{2581}',
-        vector: [0.00, 0.00, 0.00, 0.00, 0.38, 0.38],
-    }, // ▁ 1/8
-    ShapeEntry {
-        ch: '\u{2582}',
-        vector: [0.00, 0.00, 0.00, 0.00, 0.75, 0.75],
-    }, // ▂ 1/4
-    ShapeEntry {
-        ch: '\u{2583}',
-        vector: [0.00, 0.00, 0.13, 0.13, 1.00, 1.00],
-    }, // ▃ 3/8
-    ShapeEntry {
-        ch: '\u{2584}',
-        vector: [0.00, 0.00, 0.50, 0.50, 1.00, 1.00],
-    }, // ▄ 1/2
-    ShapeEntry {
-        ch: '\u{2585}',
-        vector: [0.00, 0.00, 0.89, 0.89, 1.00, 1.00],
-    }, // ▅ 5/8
-    ShapeEntry {
-        ch: '\u{2586}',
-        vector: [0.25, 0.25, 1.00, 1.00, 1.00, 1.00],
-    }, // ▆ 3/4
-    ShapeEntry {
-        ch: '\u{2587}',
-        vector: [0.62, 0.62, 1.00, 1.00, 1.00, 1.00],
-    }, // ▇ 7/8
-    ShapeEntry {
-        ch: '\u{2588}',
-        vector: [1.00, 1.00, 1.00, 1.00, 1.00, 1.00],
-    }, // █ full
-    // === Upper half + upper 1/8 ===
-    ShapeEntry {
-        ch: '\u{2580}',
-        vector: [1.00, 1.00, 0.50, 0.50, 0.00, 0.00],
-    }, // ▀ upper half
-    ShapeEntry {
-        ch: '\u{2594}',
-        vector: [0.38, 0.38, 0.00, 0.00, 0.00, 0.00],
-    }, // ▔ upper 1/8
-    // === Left/right halves ===
-    ShapeEntry {
-        ch: '\u{258C}',
-        vector: [1.00, 0.00, 1.00, 0.00, 1.00, 0.00],
-    }, // ▌ left half
-    ShapeEntry {
-        ch: '\u{2590}',
-        vector: [0.00, 1.00, 0.00, 1.00, 0.00, 1.00],
-    }, // ▐ right half
-    // === Single quadrants ===
-    ShapeEntry {
-        ch: '\u{2598}',
-        vector: [1.00, 0.00, 0.50, 0.00, 0.00, 0.00],
-    }, // ▘ TL
-    ShapeEntry {
-        ch: '\u{259D}',
-        vector: [0.00, 1.00, 0.00, 0.50, 0.00, 0.00],
-    }, // ▝ TR
-    ShapeEntry {
-        ch: '\u{2596}',
-        vector: [0.00, 0.00, 0.50, 0.00, 1.00, 0.00],
-    }, // ▖ BL
-    ShapeEntry {
-        ch: '\u{2597}',
-        vector: [0.00, 0.00, 0.00, 0.50, 0.00, 1.00],
-    }, // ▗ BR
-    // === Diagonals ===
-    ShapeEntry {
-        ch: '\u{259A}',
-        vector: [1.00, 0.00, 0.50, 0.50, 0.00, 1.00],
-    }, // ▚ TL+BR
-    ShapeEntry {
-        ch: '\u{259E}',
-        vector: [0.00, 1.00, 0.50, 0.50, 1.00, 0.00],
-    }, // ▞ TR+BL
-    // === Three-quarter blocks ===
-    ShapeEntry {
-        ch: '\u{2599}',
-        vector: [1.00, 0.00, 1.00, 0.50, 1.00, 1.00],
-    }, // ▙ TL+BL+BR
-    ShapeEntry {
-        ch: '\u{259B}',
-        vector: [1.00, 1.00, 1.00, 0.50, 1.00, 0.00],
-    }, // ▛ TL+TR+BL
-    ShapeEntry {
-        ch: '\u{259C}',
-        vector: [1.00, 1.00, 0.50, 1.00, 0.00, 1.00],
-    }, // ▜ TL+TR+BR
-    ShapeEntry {
-        ch: '\u{259F}',
-        vector: [0.00, 1.00, 0.50, 1.00, 1.00, 1.00],
-    }, // ▟ TR+BL+BR
-];
-
 // ===== Sculpted Outline Rendering =====
 //
 // Used by the Sculpted charset mode for cells at the outline/edge of

src/render/downsample.rs

@@ -1,4 +1,3 @@
-#[allow(dead_code)]
 /// A frame of downsampled simulation data, ready for rendering.
 pub struct DownsampledFrame {
     width: usize,
@@ -62,13 +61,11 @@ impl DownsampledFrame {
         }
     }
 
-    #[allow(dead_code)]
     /// Returns the width of the frame in cells.
     pub fn width(&self) -> usize {
         self.width
     }
 
-    #[allow(dead_code)]
     /// Returns the height of the frame in cells.
     pub fn height(&self) -> usize {
         self.height
@@ -79,7 +76,6 @@ impl DownsampledFrame {
         &self.cells
     }
 
-    #[allow(dead_code)]
     /// Returns the cell at the specified coordinates.
     pub fn get(&self, x: usize, y: usize) -> Cell {
         if x < self.width && y < self.height {

src/render/error_diffusion.rs

@@ -11,13 +11,10 @@ mod fs_coeff {
     pub const DOWN_RIGHT: f32 = 1.0 / 16.0;
 
     /// Coefficients for serpentine (right-to-left) scanning.
+    /// Vertical coefficients (down, down_right) are shared with the parent module.
     pub mod serpentine {
         pub const RIGHT: f32 = 3.0 / 16.0;
         pub const DOWN_LEFT: f32 = 7.0 / 16.0;
-        #[allow(dead_code)]
-        pub const DOWN: f32 = 5.0 / 16.0;
-        #[allow(dead_code)]
-        pub const DOWN_RIGHT: f32 = 1.0 / 16.0;
     }
 }
 

src/render/grid.rs

@@ -175,7 +175,6 @@ impl GridRenderer {
         opacity.clamp(0.0, 1.0)
     }
 
-    #[allow(dead_code)]
     /// Blends the grid color with the underlying cell color.
     pub fn blend_color(
         &self,

src/render/options_overlay.rs

@@ -44,7 +44,6 @@ impl ControlsOverlay {
         }
     }
 
-    #[allow(dead_code)]
     /// Returns the total number of categories.
     pub fn total_categories() -> usize {
         Self::TOTAL_CATEGORIES

src/render/palette.rs

@@ -2595,7 +2595,6 @@ pub fn palette_accent_color(
     map_brightness_rgb(0.85, palette.clone(), reverse, invert, hue_offset, mapping)
 }
 
-#[allow(dead_code)]
 /// Generates an ANSI escape sequence for a truecolor foreground or background.
 pub fn truecolor_ansi(r: u8, g: u8, b: u8, is_fg: bool) -> String {
     format!("\x1b[{};2;{};{};{}m", if is_fg { 38 } else { 48 }, r, g, b)

src/simulation/agent.rs

@@ -36,7 +36,6 @@ pub fn normalize_angle(mut angle: f32) -> f32 {
 }
 
 /// Compile-time assertion that ATTRACTOR_MIN_DIST is positive to prevent division by zero.
-#[allow(dead_code)]
 const _: () = assert!(
     crate::config_defaults::steering::MIN_ATTRACTOR_DISTANCE > 0.0,
     "MIN_ATTRACTOR_DISTANCE must be positive to prevent division by zero"