Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Commit fd11dd5

Browse files
committed
apply workaround for aarch64 architectures, fixes #328
1 parent 9da84b3 commit fd11dd5

File tree

3 files changed

+68
-1
lines changed

3 files changed

+68
-1
lines changed

Diff for: build/android-ffmpeg.sh

+4
Original file line numberDiff line numberDiff line change
@@ -336,6 +336,10 @@ export LDFLAGS="${LDFLAGS}"
336336
# USE HIGHER LIMITS FOR FFMPEG LINKING
337337
ulimit -n 2048 1>>${BASEDIR}/build.log 2>&1
338338

339+
# Workaround for issue #328
340+
rm -f ${BASEDIR}/src/${LIB_NAME}/libswscale/aarch64/hscale.S 1>>${BASEDIR}/build.log 2>&1
341+
cp ${BASEDIR}/tools/make/ffmpeg/libswscale/aarch64/hscale.S ${BASEDIR}/src/${LIB_NAME}/libswscale/aarch64/hscale.S 1>>${BASEDIR}/build.log 2>&1
342+
339343
./configure \
340344
--cross-prefix="${TARGET_HOST}-" \
341345
--sysroot="${ANDROID_NDK_ROOT}/toolchains/llvm/prebuilt/${TOOLCHAIN}/sysroot" \

Diff for: build/ios-ffmpeg.sh

+5-1
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,11 @@ if [[ -z ${NO_WORKSPACE_CLEANUP_ffmpeg} ]]; then
394394
make distclean 2>/dev/null 1>/dev/null
395395
fi
396396

397-
${SED_INLINE} 's/check_cflags -mdynamic-no-pic && add_asflags -mdynamic-no-pic;/check_cflags -mdynamic-no-pic;/g' ./configure
397+
${SED_INLINE} 's/check_cflags -mdynamic-no-pic && add_asflags -mdynamic-no-pic;/check_cflags -mdynamic-no-pic;/g' ./configure 1>>${BASEDIR}/build.log 2>&1
398+
399+
# Workaround for issue #328
400+
rm -f ${BASEDIR}/src/${LIB_NAME}/libswscale/aarch64/hscale.S 1>>${BASEDIR}/build.log 2>&1
401+
cp ${BASEDIR}/tools/make/ffmpeg/libswscale/aarch64/hscale.S ${BASEDIR}/src/${LIB_NAME}/libswscale/aarch64/hscale.S 1>>${BASEDIR}/build.log 2>&1
398402

399403
./configure \
400404
--sysroot=${SDK_PATH} \

Diff for: tools/make/ffmpeg/libswscale/aarch64/hscale.S

+59
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
/*
2+
* Copyright (c) 2016 Clément Bœsch <clement stupeflix.com>
3+
*
4+
* This file is part of FFmpeg.
5+
*
6+
* FFmpeg is free software; you can redistribute it and/or
7+
* modify it under the terms of the GNU Lesser General Public
8+
* License as published by the Free Software Foundation; either
9+
* version 2.1 of the License, or (at your option) any later version.
10+
*
11+
* FFmpeg is distributed in the hope that it will be useful,
12+
* but WITHOUT ANY WARRANTY; without even the implied warranty of
13+
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14+
* Lesser General Public License for more details.
15+
*
16+
* You should have received a copy of the GNU Lesser General Public
17+
* License along with FFmpeg; if not, write to the Free Software
18+
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
19+
*/
20+
21+
#include "libavutil/aarch64/asm.S"
22+
23+
function ff_hscale_8_to_15_neon, export=1
24+
add x10, x4, w6, UXTW #1 // filter2 = filter + filterSize*2 (x2 because int16)
25+
1: ldr w8, [x5], #4 // filterPos[0]
26+
ldr w9, [x5], #4 // filterPos[1]
27+
movi v4.4S, #0 // val sum part 1 (for dst[0])
28+
movi v5.4S, #0 // val sum part 2 (for dst[1])
29+
mov w7, w6 // filterSize counter
30+
mov x13, x3 // srcp = src
31+
2: add x11, x13, w8, UXTW // srcp + filterPos[0]
32+
add x12, x13, w9, UXTW // srcp + filterPos[1]
33+
ld1 {v0.8B}, [x11] // srcp[filterPos[0] + {0..7}]
34+
ld1 {v1.8B}, [x12] // srcp[filterPos[1] + {0..7}]
35+
ld1 {v2.8H}, [x4], #16 // load 8x16-bit filter values, part 1
36+
ld1 {v3.8H}, [x10], #16 // ditto at filter+filterSize for part 2
37+
uxtl v0.8H, v0.8B // unpack part 1 to 16-bit
38+
uxtl v1.8H, v1.8B // unpack part 2 to 16-bit
39+
smull v16.4S, v0.4H, v2.4H // v16.i32{0..3} = part 1 of: srcp[filterPos[0] + {0..7}] * filter[{0..7}]
40+
smull v18.4S, v1.4H, v3.4H // v18.i32{0..3} = part 1 of: srcp[filterPos[1] + {0..7}] * filter[{0..7}]
41+
smull2 v17.4S, v0.8H, v2.8H // v17.i32{0..3} = part 2 of: srcp[filterPos[0] + {0..7}] * filter[{0..7}]
42+
smull2 v19.4S, v1.8H, v3.8H // v19.i32{0..3} = part 2 of: srcp[filterPos[1] + {0..7}] * filter[{0..7}]
43+
addp v16.4S, v16.4S, v17.4S // horizontal pair adding of the 8x32-bit multiplied values for part 1 into 4x32-bit
44+
addp v18.4S, v18.4S, v19.4S // horizontal pair adding of the 8x32-bit multiplied values for part 2 into 4x32-bit
45+
add v4.4S, v4.4S, v16.4S // update val accumulator for part 1
46+
add v5.4S, v5.4S, v18.4S // update val accumulator for part 2
47+
add x13, x13, #8 // srcp += 8
48+
subs w7, w7, #8 // processed 8/filterSize
49+
b.gt 2b // inner loop if filterSize not consumed completely
50+
mov x4, x10 // filter = filter2
51+
add x10, x10, w6, UXTW #1 // filter2 += filterSize*2
52+
addp v4.4S, v4.4S, v5.4S // horizontal pair adding of the 8x32-bit sums into 4x32-bit
53+
addp v4.4S, v4.4S, v4.4S // horizontal pair adding of the 4x32-bit sums into 2x32-bit
54+
sqshrn v4.4H, v4.4S, #7 // shift and clip the 2x16-bit final values
55+
st1 {v4.S}[0], [x1], #4 // write to destination
56+
subs w2, w2, #2 // dstW -= 2
57+
b.gt 1b // loop until end of line
58+
ret
59+
endfunc

0 commit comments

Comments
 (0)