fix: weights for stake tiers (#1015)

* chore: update pallet weights for credits

* chore: format

Author: 1xstj

pallets/credits/README.md

@@ -60,7 +60,6 @@ This pallet relies on:
 -   `RuntimeEvent`: The overarching event type.
 -   `Currency`: The currency trait for TNT.
 -   `AssetId`: The Asset ID type.
--   `TntAssetId`: The specific Asset ID for TNT.
 -   `MultiAssetDelegationInfo`: Provides staking information (`get_user_deposit_with_locks`).
 -   `BurnConversionRate`: Rate for converting burned TNT to potential credits.
 -   `ClaimWindowBlocks`: The maximum accrual window duration in blocks.

pallets/credits/src/benchmarking.rs

@@ -19,7 +19,7 @@
 #![cfg(feature = "runtime-benchmarks")]
 
 use super::*;
-use crate::{BalanceOf, Config, LastRewardUpdateBlock, Pallet as Credits};
+use crate::{types::StakeTier, BalanceOf, Config, LastRewardUpdateBlock, Pallet as Credits};
 use frame_benchmarking::{v2::*, BenchmarkError};
 use frame_support::{
 	traits::{Currency, Get},
@@ -56,6 +56,19 @@ fn setup_delegation<T: Config>(
 	Ok(())
 }
 
+/// Create stake tiers for benchmarking
+fn create_stake_tiers<T: Config>(tiers_count: u32) -> Vec<StakeTier<BalanceOf<T>>> {
+	let mut tiers = Vec::new();
+	for i in 0..tiers_count {
+		// Create increasing thresholds and rates
+		let threshold: BalanceOf<T> = ((i + 1) * 1000u32).into();
+		let rate: BalanceOf<T> = ((i + 1) * 10u32).into();
+
+		tiers.push(StakeTier { threshold, rate_per_block: rate });
+	}
+	tiers
+}
+
 #[benchmarks]
 mod benchmarks {
 	use super::*;
@@ -108,5 +121,19 @@ mod benchmarks {
 		Ok(())
 	}
 
+	#[benchmark]
+	fn set_stake_tiers() -> Result<(), BenchmarkError> {
+		// Use the maximum allowed number of tiers to benchmark worst-case scenario
+		let max_tiers = T::MaxStakeTiers::get() as u32;
+
+		// Create a set of stake tiers with increasing thresholds and rates
+		let new_tiers = create_stake_tiers::<T>(max_tiers);
+
+		#[extrinsic_call]
+		set_stake_tiers(RawOrigin::Root, new_tiers);
+
+		Ok(())
+	}
+
 	impl_benchmark_test_suite!(Credits, crate::mock::new_test_ext(vec![]), crate::mock::Runtime);
 }

pallets/credits/src/lib.rs

@@ -112,10 +112,6 @@ pub mod pallet {
 		/// The Asset ID type used by the Currency trait and MultiAssetDelegationInfo.
 		type AssetId: Parameter + Member + MaybeDisplay + Ord + MaxEncodedLen + Copy + Debug;
 
-		/// The specific Asset ID for the TNT token.
-		#[pallet::constant]
-		type TntAssetId: Get<Self::AssetId>;
-
 		/// The provider for checking the active TNT stake.
 		/// Ensure BalanceOf<Self> here resolves correctly to T::Currency::Balance.
 		type MultiAssetDelegationInfo: MultiAssetDelegationInfo<
@@ -245,6 +241,8 @@ pub mod pallet {
 		EmptyStakeTiers,
 		/// Amount overflowed.
 		Overflow,
+		/// The stake tiers are too large to fit into the storage.
+		StakeTiersOverflow,
 	}
 
 	#[pallet::call]
@@ -324,7 +322,7 @@ pub mod pallet {
 		///
 		/// Weight: O(n) where n is the number of tiers
 		#[pallet::call_index(2)]
-		#[pallet::weight(T::WeightInfo::burn())]
+		#[pallet::weight(T::WeightInfo::set_stake_tiers())]
 		pub fn set_stake_tiers(
 			origin: OriginFor<T>,
 			new_tiers: Vec<StakeTier<BalanceOf<T>>>,
@@ -346,7 +344,7 @@ pub mod pallet {
 			// Try to create a bounded vector
 			let bounded_tiers =
 				BoundedVec::<StakeTier<BalanceOf<T>>, T::MaxStakeTiers>::try_from(new_tiers)
-					.map_err(|_| Error::<T>::EmptyStakeTiers)?; // Reusing error since we don't have a specific one for exceeding max tiers
+					.map_err(|_| Error::<T>::StakeTiersOverflow)?;
 
 			// Update storage
 			StoredStakeTiers::<T>::set(bounded_tiers);

pallets/credits/src/mock.rs

@@ -532,11 +532,6 @@ impl pallet_multi_asset_delegation::Config for Runtime {
 }
 
 parameter_types! {
-	#[derive(Default, Copy, Clone, Eq, PartialEq, RuntimeDebug, Encode, Decode, MaxEncodedLen, TypeInfo)]
-	#[cfg_attr(feature = "std", derive(serde::Serialize, serde::Deserialize))]
-	pub const TntAssetId: AssetId = 1000;
-
-
 	#[derive(Default, Copy, Clone, Eq, PartialEq, RuntimeDebug, Encode, Decode, MaxEncodedLen, TypeInfo)]
 	#[cfg_attr(feature = "std", derive(serde::Serialize, serde::Deserialize))]
 	pub const MaxStakeTiers: u32 = 10;
@@ -550,7 +545,6 @@ impl pallet_credits::Config for Runtime {
 	type RuntimeEvent = RuntimeEvent;
 	type Currency = Balances;
 	type AssetId = AssetId;
-	type TntAssetId = TntAssetId;
 	type MultiAssetDelegationInfo = MultiAssetDelegation;
 	type BurnConversionRate = ConstU128<1000>;
 	type ClaimWindowBlocks = ConstU64<1000>;

pallets/credits/src/tests.rs

@@ -54,7 +54,7 @@ fn get_max_claimable(who: AccountId) -> Balance {
 		return 0;
 	}
 
-	let tnt_asset_id = <Runtime as crate::Config>::TntAssetId::get();
+	let tnt_asset_id = 0;
 	let tnt_asset = tangle_primitives::services::Asset::Custom(tnt_asset_id);
 
 	let maybe_deposit_info =
@@ -106,7 +106,7 @@ fn run_to_block(n: BlockNumber) {
 }
 
 fn setup_delegation(delegator: AccountId, operator: AccountId, amount: Balance) {
-	let tnt_asset_id = <Runtime as crate::Config>::TntAssetId::get();
+	let tnt_asset_id = 0;
 	let tnt_asset = tangle_primitives::services::Asset::Custom(tnt_asset_id);
 
 	let min_bond = <Runtime as pallet_multi_asset_delegation::Config>::MinOperatorBondAmount::get();
@@ -492,7 +492,7 @@ fn accrual_with_stake_change_works() {
 		let user = DAVE;
 		let operator = EVE;
 		let dave_id_str = b"dave_stake_change";
-		let tnt_asset_id = <Runtime as crate::Config>::TntAssetId::get();
+		let tnt_asset_id = 0;
 		let tnt_asset = tangle_primitives::services::Asset::Custom(tnt_asset_id);
 
 		let stake_tier3 = 15000;

pallets/credits/src/weights.rs

@@ -17,7 +17,7 @@
 //! Autogenerated weights for credits pallet
 //!
 //! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0
-//! DATE: 2025-05-07, STEPS: `10`, REPEAT: `2`, LOW RANGE: `[]`, HIGH RANGE: `[]`
+//! DATE: 2024-05-21, STEPS: `10`, REPEAT: `2`, LOW RANGE: `[]`, HIGH RANGE: `[]`
 //! EXECUTION: Some(Wasm), WASM-EXECUTION: Compiled, CHAIN: Some("dev"), DB CACHE: 128
 
 // Executed Command:
@@ -46,6 +46,8 @@ pub trait WeightInfo {
 	fn burn() -> Weight;
 	/// Weight for the `claim_credits` extrinsic
 	fn claim_credits() -> Weight;
+	/// Weight for the `set_stake_tiers` extrinsic
+	fn set_stake_tiers() -> Weight;
 }
 
 /// Weights for credits pallet using the Substrate node and recommended hardware.
@@ -61,8 +63,8 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
 		// Proof Size summary in bytes:
 		//  Measured:  `512`
 		//  Estimated: `1024`
-		// Minimum execution time: 25_000 nanoseconds.
-		Weight::from_parts(26_000_000, 1024)
+		// Minimum execution time: 24_300 nanoseconds.
+		Weight::from_parts(24_850_000, 1056)
 			.saturating_add(T::DbWeight::get().reads(3_u64))
 			.saturating_add(T::DbWeight::get().writes(2_u64))
 	}
@@ -79,24 +81,40 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
 		// Proof Size summary in bytes:
 		//  Measured:  `640`
 		//  Estimated: `1280`
-		// Minimum execution time: 35_000 nanoseconds.
-		Weight::from_parts(36_000_000, 1280)
+		// Minimum execution time: 34_100 nanoseconds.
+		Weight::from_parts(34_750_000, 1312)
 			.saturating_add(T::DbWeight::get().reads(4_u64))
 			.saturating_add(T::DbWeight::get().writes(2_u64))
 	}
+	
+	/// Storage: `Credits::StakeTiers` (r:0 w:1)
+	/// Proof: `Credits::StakeTiers` (`max_values`: None, `max_size`: Some(256), mode: `Measured`)
+	fn set_stake_tiers() -> Weight {
+		// Proof Size summary in bytes:
+		//  Measured:  `0`
+		//  Estimated: `0`
+		// Minimum execution time: 16_200 nanoseconds.
+		Weight::from_parts(17_350_000, 32)
+			.saturating_add(T::DbWeight::get().writes(1_u64))
+	}
 }
 
 // For backwards compatibility and tests
 impl WeightInfo for () {
 	fn burn() -> Weight {
-		Weight::from_parts(26_000_000, 0)
+		Weight::from_parts(24_850_000, 0)
 			.saturating_add(RocksDbWeight::get().reads(3_u64))
 			.saturating_add(RocksDbWeight::get().writes(2_u64))
 	}
 
 	fn claim_credits() -> Weight {
-		Weight::from_parts(36_000_000, 0)
+		Weight::from_parts(34_750_000, 0)
 			.saturating_add(RocksDbWeight::get().reads(4_u64))
 			.saturating_add(RocksDbWeight::get().writes(2_u64))
 	}
+	
+	fn set_stake_tiers() -> Weight {
+		Weight::from_parts(17_350_000, 0)
+			.saturating_add(RocksDbWeight::get().writes(1_u64))
+	}
 }

precompiles/credits/src/mock.rs

@@ -408,11 +408,6 @@ impl
 }
 
 parameter_types! {
-	#[derive(Default, Copy, Clone, Eq, PartialEq, RuntimeDebug, Encode, Decode, MaxEncodedLen, TypeInfo)]
-	#[cfg_attr(feature = "std", derive(serde::Serialize, serde::Deserialize))]
-	pub const TntAssetId: AssetId = 1000;
-
-
 	#[derive(Default, Copy, Clone, Eq, PartialEq, RuntimeDebug, Encode, Decode, MaxEncodedLen, TypeInfo)]
 	#[cfg_attr(feature = "std", derive(serde::Serialize, serde::Deserialize))]
 	pub const MaxStakeTiers: u32 = 10;
@@ -426,7 +421,6 @@ impl pallet_credits::Config for Runtime {
 	type RuntimeEvent = RuntimeEvent;
 	type Currency = Balances;
 	type AssetId = AssetId;
-	type TntAssetId = TntAssetId;
 	type MultiAssetDelegationInfo = MockDelegationManager;
 	type BurnConversionRate = ConstU128<1000>;
 	type ClaimWindowBlocks = ConstU64<1000>;

runtime/mainnet/src/lib.rs

@@ -1373,10 +1373,6 @@ impl pallet_rewards::Config for Runtime {
 }
 
 parameter_types! {
-	#[derive(Default, Copy, Clone, Eq, PartialEq, RuntimeDebug, Encode, Decode, MaxEncodedLen, TypeInfo)]
-	#[cfg_attr(feature = "std", derive(serde::Serialize, serde::Deserialize))]
-	pub const TntAssetId: AssetId = 0;
-
 	#[derive(Default, Copy, Clone, Eq, PartialEq, RuntimeDebug, Encode, Decode, MaxEncodedLen, TypeInfo)]
 	#[cfg_attr(feature = "std", derive(serde::Serialize, serde::Deserialize))]
 	pub const MaxStakeTiers: u32 = 10;
@@ -1390,7 +1386,6 @@ impl pallet_credits::Config for Runtime {
 	type RuntimeEvent = RuntimeEvent;
 	type Currency = Balances;
 	type AssetId = AssetId;
-	type TntAssetId = TntAssetId;
 	type MultiAssetDelegationInfo = MultiAssetDelegation;
 	type BurnConversionRate = ConstU128<1000>;
 	type ClaimWindowBlocks = ConstU64<1000>;

runtime/testnet/Cargo.toml

@@ -185,7 +185,8 @@ runtime-benchmarks = [
     "pallet-airdrop-claims/runtime-benchmarks",
     "pallet-multi-asset-delegation/runtime-benchmarks",
     "pallet-tangle-lst-benchmarking/runtime-benchmarks",
-    "pallet-rewards/runtime-benchmarks"
+    "pallet-rewards/runtime-benchmarks",
+    "pallet-credits/runtime-benchmarks",
 ]
 default = ["std", "with-rocksdb-weights", "evm-tracing"]
 local-testing = []

runtime/testnet/src/lib.rs

@@ -1258,10 +1258,6 @@ impl pallet_rewards::Config for Runtime {
 }
 
 parameter_types! {
-	#[derive(Default, Copy, Clone, Eq, PartialEq, RuntimeDebug, Encode, Decode, MaxEncodedLen, TypeInfo)]
-	#[cfg_attr(feature = "std", derive(serde::Serialize, serde::Deserialize))]
-	pub const TntAssetId: AssetId = 0;
-
 	#[derive(Default, Copy, Clone, Eq, PartialEq, RuntimeDebug, Encode, Decode, MaxEncodedLen, TypeInfo)]
 	#[cfg_attr(feature = "std", derive(serde::Serialize, serde::Deserialize))]
 	pub const MaxStakeTiers: u32 = 10;
@@ -1275,7 +1271,6 @@ impl pallet_credits::Config for Runtime {
 	type RuntimeEvent = RuntimeEvent;
 	type Currency = Balances;
 	type AssetId = AssetId;
-	type TntAssetId = TntAssetId;
 	type MultiAssetDelegationInfo = MultiAssetDelegation;
 	type BurnConversionRate = ConstU128<1000>;
 	type ClaimWindowBlocks = ConstU64<1000>;
@@ -1627,6 +1622,7 @@ mod benches {
 		[pallet_tangle_lst_benchmarking, crate::benches::LstBench::<Runtime>]
 		[pallet_multi_asset_delegation, MultiAssetDelegation]
 		[pallet_rewards, Rewards]
+		[pallet_credits, Credits]
 	);
 }