Skip to content
This repository was archived by the owner on Apr 7, 2022. It is now read-only.

Commit 0c31693

Browse files
authored
Merge pull request #295 from tango-controls/fix-v9.3.1-version
Fix package version for release v9.3.1
2 parents 5ee7748 + f31c9b2 commit 0c31693

3 files changed

Lines changed: 14 additions & 9 deletions

File tree

doc/how-to-contribute.rst

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,11 @@ Create an issue in Github
8686
| - [ ] Merge develop into stable
8787
| - [ ] Make sure Travis and Appveyor are OK on stable branch
8888
| - [ ] Make sure the documentation is updated for stable (readthedocs)
89-
| - [ ] Create a release tag on GitHub, from stable branch
89+
| - [ ] Create an annotated tag from stable branch
9090
| - [ ] Make sure the documentation is updated for release (readthedocs)
9191
| - [ ] Upload the new version to PyPI
9292
| - [ ] Bump the version with "-dev" in the develop branch
93-
| - [ ] Fill the release description on GitHub
93+
| - [ ] Create and fill in the release description on GitHub
9494
| - [ ] Build conda packages
9595
| - [ ] Advertise the release on the mailing list
9696
| - [ ] Close this issue
@@ -136,10 +136,13 @@ Make sure the documentation is updated
136136
- Set the new version to "active" here:
137137
https://readthedocs.org/dashboard/pytango/versions/
138138

139-
Create a release tag on GitHub
140-
* On the Releases page, use "Draft a new release".
141-
* Tag must match the format of previous tags, e.g. ``v9.3.1``.
142-
* Target must be the ``stable`` branch.
139+
Create an annotated tag for the release
140+
* Note: Github's release page makes lightweight tags which we don't want
141+
* Create tag:
142+
- ``$ git checkout stable``
143+
- ``$ git pull``
144+
- ``$ git tag -a -m "tag v9.3.1"``
145+
- ``$ git push -v origin refs/tags/v9.3.1``
143146

144147
Upload the new version to PyPI
145148
* Log in to https://pypi.org.
@@ -173,7 +176,9 @@ Bump the version with "-dev" in the develop branch
173176
* In ``appveyor.yml``, change ``version``, e.g. from ``9.3.1.{build}`` to
174177
``9.3.2.dev0.{build}``.
175178

176-
Fill in the release description on GitHub
179+
Create and fill in the release description on GitHub
180+
* Go to the Tags page: https://github.com/tango-controls/pytango/tags
181+
* Find the tag created above and click "Create release".
177182
* Content must be the same as the details in the changelog. List all the
178183
pull requests since the previous version.
179184

doc/revision.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ Document revisions
105105
+----------+----------------------------------------------------------------------------------+-----------------------------------------------------+--------------------------------+
106106
| 13/03/19 | `9.3.0 <http://pytango.readthedocs.io/en/v9.3.0>`_ | 9.3.0 Release | T\. Coutinho |
107107
+----------+----------------------------------------------------------------------------------+-----------------------------------------------------+--------------------------------+
108-
| 07/08/19 | `9.3.1 <http://pytango.readthedocs.io/en/v9.3.1>`_ | 9.3.1 Release | A\. Joubert |
108+
| 08/08/19 | `9.3.1 <http://pytango.readthedocs.io/en/v9.3.1>`_ | 9.3.1 Release | A\. Joubert |
109109
+----------+----------------------------------------------------------------------------------+-----------------------------------------------------+--------------------------------+
110110

111111
.. _pytango-version-history:

tango/release.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class Release:
4545
- license: (str) the license
4646
"""
4747
name = 'pytango'
48-
version_info = (9, 3, 1, 'dev', 1)
48+
version_info = (9, 3, 1)
4949
version = '.'.join(map(str, version_info[:3]))
5050
release = ''.join(map(str, version_info[3:]))
5151
separator = '.' if 'dev' in release or 'post' in release else ''

0 commit comments

Comments
 (0)