CI for publishing windows

Author: tanin

.github/workflows/create-release-mac.yml

@@ -22,8 +22,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-        with:
-          ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.tag || github.ref_name }}
       - name: Import Signing Certificate
         run: |
           # Create a temporary keychain

.github/workflows/create-release-windows.yml

@@ -1,4 +1,4 @@
-name: create-release-mac
+name: create-release-windows
 
 on:
   push:
@@ -18,63 +18,84 @@ permissions:
 jobs:
   build:
     runs-on: windows-latest
+    defaults:
+      run:
+        shell: msys2 {0}
 
     steps:
+      - uses: msys2/setup-msys2@v2
+        with:
+          update: true
+          install: >-
+            curl
+            git 
+            gcc
+            unzip
+      - uses: actions/setup-node@v4
+        with:
+          node-version: '22'
+      - name: Debug node
+        run: |
+          export PATH="${PATH}:/c/hostedtoolcache/windows/node/22.21.1/x64"
+          node --version
+          npm --version
       - name: Checkout
         uses: actions/checkout@v4
-        with:
-          ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.tag || github.ref_name }}
+      - name: Install Node modules
+        run: |
+          export PATH="${PATH}:/c/hostedtoolcache/windows/node/22.21.1/x64"
+          npm install
+      - name: Install WSL (needed by CodeSignTool)
+        run: |
+          wsl --install
       - uses: actions/setup-java@v4
         with:
           distribution: temurin
           java-version: '21'
           cache: 'gradle'
-      - uses: actions/setup-node@v4
-        with:
-          node-version: '22'
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v3
         with:
           cache-read-only: ${{ github.ref != 'refs/heads/main' }}
       - name: Get version
         id: version
-        run: echo "VERSION=$(./gradlew -q printInternalVersion)" >> "$GITHUB_OUTPUT"
+        run: |
+          version=$(./gradlew -q printInternalVersion)
+          echo "VERSION=$version" >> $GITHUB_OUTPUT
       - name: Validate the tag name
         run: |
-          if [ "${{ github.event_name }}" == "workflow_dispatch" ] && [ ! -z "${{ github.event.inputs.tag }}" ]; then
+          if [[ "${{ github.event_name }}" == "workflow_dispatch" && ! -z "${{ github.event.inputs.tag }}" ]]; then
             TAG=${{ github.event.inputs.tag }}
           else
             TAG=${GITHUB_REF#refs/tags/}
           fi
           if [[ ! "$TAG" =~ ^v ]]; then
             echo "Error: Tag ($TAG) must start with 'v'"
             exit 1
-          fi
+          fi 
           if [[ ! $TAG == v${{ steps.version.outputs.VERSION }} ]]; then
             echo "Error: Git tag version ($TAG) doesn't match project version (v${{ steps.version.outputs.VERSION }})"
             exit 1
           fi
-      - name: Install Node modules
-        run: npm install
       - name: Download CodeSignTool and extract
         run: |
           $ProgressPreference = 'SilentlyContinue'
           New-Item -ItemType Directory -Force -Path "./build-tools/codesign"
           Invoke-WebRequest -Uri "https://www.ssl.com/download/codesigntool-for-windows/" -OutFile "./build-tools/CodeSignTool.zip"
           Expand-Archive -Path "./build-tools/CodeSignTool.zip" -DestinationPath "./build-tools/codesign" -Force
           Remove-Item "./build-tools/CodeSignTool.zip"
-        shell: pwsh
+        shell: powershell
       - name: Download wixtool 3 and extract
         run: |
           $ProgressPreference = 'SilentlyContinue'
           New-Item -ItemType Directory -Force -Path "./build-tools/wixtool"
           Invoke-WebRequest -Uri "https://github.com/wixtoolset/wix3/releases/download/wix3141rtm/wix314-binaries.zip" -OutFile "./build-tools/wix-binaries.zip"
           Expand-Archive -Path "./build-tools/wix-binaries.zip" -DestinationPath "./build-tools/wixtool" -Force
           Remove-Item "./build-tools/wix-binaries.zip"
-        shell: pwsh
+        shell: powershell
       - name: Build an MSI
         run: |
-          export PATH="$PATH:$PWD/build-tools/wixtool"
+          export PATH="${PATH}:$PWD/build-tools/wixtool:/c/hostedtoolcache/windows/node/22.21.1/x64"
           ./gradlew clean jpackage
         env:
           CODESIGN_TOOL_DIR: "./build-tools/codesign"

.github/workflows/publish-mac-testflight.yml

@@ -19,8 +19,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-        with:
-          ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.tag || github.ref_name }}
       - name: Import Signing Certificate
         run: |
           # Create a temporary keychain

src/main/c/WindowsApi.c

@@ -17,7 +17,7 @@ __declspec(dllexport) char* openFileDialog(long hwnd, bool isSaved) {
 
   ZeroMemory(&ofn, sizeof(ofn));
   ofn.lStructSize = sizeof(ofn);
-  ofn.hwndOwner = (HWND) (uintptr_t) hwnd;
+  ofn.hwndOwner = (HWND) (size_t) hwnd;
   ofn.lpstrFile = szFile;
   ofn.lpstrFile[0] = '\0';
   ofn.nMaxFile = sizeof(szFile);