Merge pull request #104 from tanishiking/reflective-call-throw

Throw an exception when reflective proxy not found

Author: sjrd

Diff for: build.sbt

@@ -226,8 +226,6 @@ lazy val `scalajs-test-suite` = project
 
 lazy val IgnoredTestNames: Set[String] = {
   Set(
-    // reflective call: should be throw an exception when reflective proxy not found
-    "org.scalajs.testsuite.compiler.WasPublicBeforeTyperTestScala2",
     // javaLangClassGetNameRenamedThroughSemantics failed: org.junit.ComparisonFailure:
     // expected:<[renamed.test.]Class> but was:<[org.scalajs.testsuite.compiler.ReflectionTest$RenamedTest]Class>
     "org.scalajs.testsuite.compiler.ReflectionTest",

Diff for: wasm/src/main/scala/ir2wasm/HelperFunctions.scala

@@ -1650,9 +1650,16 @@ object HelperFunctions {
       instrs += I32_ADD
       instrs += LOCAL_SET(i)
     }
-    // method not found, trap
-    // TODO? maybe we should throw an exception
-    instrs += UNREACHABLE
+    // throw new TypeError("...")
+    instrs ++= ctx.getConstantStringInstr("TypeError")
+    instrs += CALL(WasmFunctionName.jsGlobalRefGet)
+    instrs += CALL(WasmFunctionName.jsNewArray)
+    // Originally, exception is thrown from JS saying e.g. "obj2.z1__ is not a function"
+    instrs ++= ctx.getConstantStringInstr("Method not found")
+    instrs += CALL(WasmFunctionName.jsArrayPush)
+    instrs += CALL(WasmFunctionName.jsNew)
+    instrs += EXTERN_CONVERT_ANY
+    instrs += THROW(ctx.exceptionTagName)
 
     fctx.buildAndAddToContext()
   }