Use a single name: String inside WasmFunctionName.

That makes it consistent with all other `Name`s.

Helper names are now namespace-free. They are the only `Name`s for
which the underlying string is still semantically meaningful, as
they must correlate with the actual names of the helpers in the
`LoaderContent`.

Author: sjrd

Diff for: wasm/src/main/scala/wasm4s/Names.scala

@@ -69,11 +69,9 @@ object Names {
       new WasmGlobalName("idHashCodeMap")
   }
 
-  final case class WasmFunctionName private (
-      val namespace: String,
-      val simpleName: String
-  ) extends WasmName {
-    val name = namespace + "#" + simpleName
+  final case class WasmFunctionName private (name: String) extends WasmName {
+    def this(namespace: String, simpleName: String) =
+      this(namespace + "#" + simpleName)
   }
 
   object WasmFunctionName {
@@ -141,7 +139,7 @@ object Names {
     val start = new WasmFunctionName("start", "start")
 
     private def helper(name: String): WasmFunctionName =
-      new WasmFunctionName("__scalaJSHelpers", name)
+      new WasmFunctionName(name)
 
     // JS helpers
 

Diff for: wasm/src/main/scala/wasm4s/WasmContext.scala

@@ -276,7 +276,7 @@ class WasmContext(val module: WasmModule) extends TypeDefinableWasmContext {
     val sig = WasmFunctionSignature(params, results)
     val typeName = addFunctionType(sig)
     module.addImport(
-      WasmImport(name.namespace, name.simpleName, WasmImportDesc.Func(name, typeName))
+      WasmImport("__scalaJSHelpers", name.name, WasmImportDesc.Func(name, typeName))
     )
   }
 

Diff for: wasm/src/main/scala/wasm4s/WasmFunctionContext.scala

@@ -95,10 +95,7 @@ class WasmFunctionContext private (
     addLocal(genSyntheticLocalName(), typ)
 
   def genInnerFuncName(): WasmFunctionName = {
-    val innerName = WasmFunctionName(
-      functionName.namespace,
-      functionName.simpleName + "__c" + innerFuncIdx
-    )
+    val innerName = WasmFunctionName(functionName.name + "__c" + innerFuncIdx)
     innerFuncIdx += 1
     innerName
   }