fix: add APP_URL setting in UI to fix localhost link in Telegram/Email (#43)

- Settings > General: add "URL ứng dụng" field with validation
- Backend: save app_url to app_settings, strip trailing slash
- Dispatcher: getBaseURL reads DB setting > env > fallback localhost

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: tanviet12

backend/api/handlers/settings.go

@@ -3,6 +3,7 @@ package handlers
 import (
 	"fmt"
 	"net/http"
+	"strings"
 	"time"
 
 	"github.com/gin-gonic/gin"
@@ -157,6 +158,7 @@ func SaveGeneralSettings(c *gin.Context) {
 		Timezone       string  `json:"timezone"`
 		Language       string  `json:"language"`
 		ExchangeRate   float64 `json:"exchange_rate_vnd"`
+		AppURL         string  `json:"app_url"`
 	}
 	if err := c.ShouldBindJSON(&req); err != nil {
 		c.JSON(http.StatusBadRequest, gin.H{"error": "invalid_request", "details": err.Error()})
@@ -182,6 +184,10 @@ func SaveGeneralSettings(c *gin.Context) {
 		upsertSetting(tenantID, "exchange_rate_vnd", fmt.Sprintf("%.0f", req.ExchangeRate), nil)
 	}
 
+	// Strip trailing slash from app URL
+	appURL := strings.TrimRight(req.AppURL, "/")
+	upsertSetting(tenantID, "app_url", appURL, nil)
+
 	c.JSON(http.StatusOK, gin.H{"message": "saved"})
 }
 

backend/notifications/dispatcher.go

@@ -80,7 +80,7 @@ func (d *Dispatcher) SendJobResults(ctx context.Context, job models.Job, run mod
 
 		// Use custom template if configured
 		body := defaultBody
-		link := fmt.Sprintf("%s/%s/jobs/%s", d.getBaseURL(), job.TenantID, job.ID)
+		link := fmt.Sprintf("%s/%s/jobs/%s", d.getBaseURL(job.TenantID), job.TenantID, job.ID)
 		if output.Template == "custom" && output.CustomTemplate != "" {
 			body = d.renderCustomTemplate(output.CustomTemplate, job.Name, total, passed, failed, issues, defaultBody, link)
 		}
@@ -197,10 +197,17 @@ func trimSpace(s string) string {
 	return s[start:end]
 }
 
-func (d *Dispatcher) getBaseURL() string {
+func (d *Dispatcher) getBaseURL(tenantID string) string {
+	// Priority 1: tenant setting from DB
+	var setting models.AppSetting
+	if err := db.DB.Where("tenant_id = ? AND setting_key = ?", tenantID, "app_url").First(&setting).Error; err == nil && setting.ValuePlain != "" {
+		return setting.ValuePlain
+	}
+	// Priority 2: environment variable
 	if u := os.Getenv("APP_URL"); u != "" {
 		return u
 	}
+	// Priority 3: fallback
 	return "http://localhost:8080"
 }
 

frontend/src/views/Settings.vue

@@ -118,6 +118,16 @@
             class="mb-3"
           />
 
+          <v-text-field
+            v-model="generalSettings.appUrl"
+            label="URL ứng dụng"
+            placeholder="https://cqa.yourdomain.com"
+            hint="Cấu hình URL để hệ thống gửi link chính xác qua Telegram và Email"
+            persistent-hint
+            :rules="appUrlRules"
+            class="mb-3"
+          />
+
           <v-btn color="primary" :loading="savingGeneral" @click="saveGeneral">{{ $t('save_settings') }}</v-btn>
         </v-card>
       </v-col>
@@ -165,7 +175,12 @@ const geminiModels = [
 ]
 
 const aiSettings = reactive({ provider: 'claude', model: 'claude-sonnet-4-6', apiKey: '', batchMode: true, batchSize: 5 })
-const generalSettings = reactive({ companyName: '', timezone: 'Asia/Ho_Chi_Minh', language: 'vi', exchangeRate: 26000 })
+const generalSettings = reactive({ companyName: '', timezone: 'Asia/Ho_Chi_Minh', language: 'vi', exchangeRate: 26000, appUrl: '' })
+
+const appUrlRules = [
+  (v: string) => !v || /^https?:\/\/.+/.test(v) || 'URL phải bắt đầu bằng http:// hoặc https://',
+  (v: string) => !v || !v.endsWith('/') || 'URL không nên có dấu / ở cuối',
+]
 
 const modelOptions = computed(() => {
   return aiSettings.provider === 'claude' ? claudeModels : geminiModels
@@ -185,6 +200,7 @@ async function loadSettings() {
     if (data.settings.ai_batch_mode) aiSettings.batchMode = data.settings.ai_batch_mode === 'true'
     if (data.settings.ai_batch_size) aiSettings.batchSize = parseInt(data.settings.ai_batch_size) || 5
     if (data.settings.exchange_rate_vnd) generalSettings.exchangeRate = parseFloat(data.settings.exchange_rate_vnd) || 26000
+    if (data.settings.app_url) generalSettings.appUrl = data.settings.app_url
     if (data.tenant) {
       generalSettings.companyName = data.tenant.name || ''
       generalSettings.timezone = data.tenant.timezone || 'Asia/Ho_Chi_Minh'
@@ -254,6 +270,7 @@ async function saveGeneral() {
       timezone: generalSettings.timezone,
       language: generalSettings.language,
       exchange_rate_vnd: generalSettings.exchangeRate,
+      app_url: generalSettings.appUrl,
     })
     showSnack(t('success'), 'success')
   } catch (err: any) {