Skip to content

Commit 06d4486

Browse files
committed
fix: remove writeFormat from doris perTable
1 parent 4e1a533 commit 06d4486

File tree

3 files changed

+5
-14
lines changed

3 files changed

+5
-14
lines changed

connectors/doris-connector/src/main/java/io/tapdata/connector/doris/bean/DorisConfig.java

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public class DorisConfig extends CommonDbConfig {
2424
private List<LinkedHashMap<String, String>> tableProperties = new ArrayList<>();
2525
private Boolean jdbcCompletion = false;
2626

27-
private Boolean useHTTPS =false;
27+
private Boolean useHTTPS = false;
2828

2929
private Integer backendNum;
3030

@@ -38,9 +38,9 @@ public DorisConfig() {
3838
public DorisConfig load(Map<String, Object> map) {
3939
DorisConfig config = (DorisConfig) super.load(map);
4040
config.setSchema(config.getDatabase());
41-
if(Boolean.TRUE.equals(useHTTPS)){
41+
if (Boolean.TRUE.equals(useHTTPS)) {
4242
config.setDorisHttp(getDorisHttp().replace("https://", ""));
43-
}else{
43+
} else {
4444
config.setDorisHttp(getDorisHttp().replace("http://", ""));
4545
}
4646
return config;
@@ -109,10 +109,6 @@ public String getWriteFormat() {
109109
return writeFormat;
110110
}
111111

112-
public String getWriteFormat(String key) {
113-
return getTableConfigValue(key, "writeFormat", writeFormat);
114-
}
115-
116112
public void setWriteFormat(String writeFormat) {
117113
this.writeFormat = writeFormat;
118114
}
@@ -185,8 +181,4 @@ public enum WriteFormat {
185181
public WriteFormat getWriteFormatEnum() {
186182
return WriteFormat.valueOf(writeFormat);
187183
}
188-
189-
public WriteFormat getWriteFormatEnum(String key) {
190-
return WriteFormat.valueOf(getTableConfigValue(key, "writeFormat", writeFormat));
191-
}
192184
}

connectors/doris-connector/src/main/java/io/tapdata/connector/doris/streamload/DorisStreamLoader.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public DorisStreamLoader(DorisJdbcContext dorisJdbcContext, CloseableHttpClient
7171
}
7272

7373
private void initMessageSerializer() {
74-
DorisConfig.WriteFormat writeFormat = dorisConfig.getWriteFormatEnum(tapTable.getId());
74+
DorisConfig.WriteFormat writeFormat = dorisConfig.getWriteFormatEnum();
7575
TapLogger.info(TAG, "Doris stream load run with {} format", writeFormat);
7676
switch (writeFormat) {
7777
case csv:
@@ -137,7 +137,7 @@ private Set<String> getDataColumns(TapRecordEvent recordEvent) {
137137
}
138138

139139
public RespContent put(final TapTable table) throws StreamLoadException, DorisRetryableException {
140-
DorisConfig.WriteFormat writeFormat = dorisConfig.getWriteFormatEnum(table.getId());
140+
DorisConfig.WriteFormat writeFormat = dorisConfig.getWriteFormatEnum();
141141
try {
142142
final String loadUrl = buildLoadUrl(dorisConfig.getDorisHttp(), dorisConfig.getDatabase(), table.getId());
143143
final String prefix = buildPrefix(URLEncoder.encode(table.getId()).replace("%", ""));

connectors/doris-connector/src/main/resources/spec_doris.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -487,7 +487,6 @@
487487
"title": "${writeFormat}",
488488
"default": "json",
489489
"x-index": 7,
490-
"x-perTable": true,
491490
"x-decorator": "FormItem",
492491
"x-decorator-props": {
493492
"feedbackLayout": "none"

0 commit comments

Comments
 (0)