Skip to content

Commit e57161c

Browse files
committed
fix: update tab handling in notification components TAP-6811
- Changed tab click event to tab change for better event handling in AlarmNotification.vue, NotificationPopover.vue, and SystemNotification.vue. - Simplified tab parameter checks in the respective components for improved readability and consistency.
1 parent a6acd66 commit e57161c

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

apps/daas/src/views/notification/AlarmNotification.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ export default {
155155
},
156156
handleClick(tab) {
157157
this.currentPage = 1
158-
if (tab.name === 'first') {
158+
if (tab === 'first') {
159159
this.read = true // 全部信息
160160
} else {
161161
this.read = false //未读
@@ -188,7 +188,7 @@ export default {
188188
</div>
189189
</div>
190190
191-
<el-tabs v-model="activeName" @tab-click="handleClick">
191+
<el-tabs v-model="activeName" @tab-change="handleClick">
192192
<div class="operation">
193193
<ElButton type="primary" @click="handlePageRead()">{{
194194
$t('notify_mask_read')

apps/daas/src/views/notification/NotificationPopover.vue

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,11 @@ export default {
143143
break
144144
}
145145
},
146-
tabHandler() {
147-
if (this.activeTab === 'user') {
146+
tabHandler(tab) {
147+
if (tab === 'user') {
148148
this.getUserOperations()
149149
}
150-
if (this.activeTab === 'alarm') {
150+
if (tab === 'alarm') {
151151
this.getAlarmData()
152152
}
153153
},
@@ -243,7 +243,7 @@ export default {
243243
v-model="activeTab"
244244
stretch
245245
class="notification-popover-wrap"
246-
@tab-click="tabHandler"
246+
@tab-change="tabHandler"
247247
>
248248
<ElButton
249249
v-if="activeTab === 'system'"

apps/daas/src/views/notification/SystemNotification.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ export default {
251251
},
252252
handleClick(tab) {
253253
this.currentPage = 1
254-
if (tab.name === 'first') {
254+
if (tab === 'first') {
255255
this.read = true // 全部信息
256256
} else {
257257
this.read = false //未读
@@ -313,7 +313,7 @@ export default {
313313
>
314314
<div v-loading="loading" class="system-notification">
315315
<div class="position-sticky top-0 z-10 bg-white">
316-
<el-tabs v-model="activeName" @tab-click="handleClick">
316+
<el-tabs v-model="activeName" @tab-change="handleClick">
317317
<el-tab-pane :label="$t('notify_user_all_notice')" name="first" />
318318
<el-tab-pane :label="$t('notify_unread_notice')" name="second" />
319319
</el-tabs>

packages/business/src/views/data-server/Drawer.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -333,9 +333,9 @@ export default {
333333
})
334334
}
335335
},
336-
tabChanged() {
336+
tabChanged(tab) {
337337
let debugParams = null
338-
if (this.tab === 'debug') {
338+
if (tab === 'debug') {
339339
this.isEdit = false
340340
debugParams = {}
341341
this.data.params.forEach((p) => {
@@ -995,7 +995,7 @@ export default {
995995
ref="tabs"
996996
v-model="tab"
997997
class="data-server__tabs flex-1"
998-
@tab-click="tabChanged"
998+
@tab-change="tabChanged"
999999
>
10001000
<ElTabPane
10011001
:label="$t('packages_business_data_server_drawer_peizhi')"

0 commit comments

Comments
 (0)