Skip to content

Consider changing the default value of TSIMP_DIAG to error #16

Open
@ItsHarper

Description

@ItsHarper

As is evidenced by the original version of this issue, I was very surprised to learn that by default, tsimp will run the script even if there are compilation errors. I think this is a poor default that should be reconsidered.

Original title and description

simp runs the script even when there is a compilation error

Here's what the output looks like:

> node --import=tsimp/import src/scripts/validate-json.ts

src/scripts/validate-json.ts:56:24 - error TS2345: Argument of type 'number' is not assignable to parameter of type 'string'.

56 console.log(parseFloat(3));
                          ~

<Regular program output>

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions