Merge pull request #61 from tarasko/feature/clean_strip

Simply setup.py, strip release builds using cibuildwheel options

Author: tarasko

.github/workflows/run-tests.yml

@@ -77,6 +77,9 @@ jobs:
       with:
         python-version: ${{ matrix.pyver }}
 
+    - name: Show Python build OPT flags (they are automatically added when building extensions)
+      run: python -c "import sysconfig; print(sysconfig.get_config_var('OPT'))"
+
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip

HISTORY.rst

@@ -9,6 +9,7 @@ picows Release History
 ------------------
 
 * Drop python 3.8 support
+* Strip extensions on Linux and MacOS. Reduce package size
 
 1.9.0 (2025-06-05)
 ------------------

pyproject.toml

@@ -50,3 +50,10 @@ asyncio_default_fixture_loop_scope = "function"
 files = "picows"
 ignore_missing_imports = true
 strict = true
+
+[tool.cibuildwheel]
+# Python that is used by github workers is build with -g flag
+# This flag is automatically passed when extensions are built
+# Add -g0 to negate -g.
+# This only affects our release builds when we are using cibuildwheel
+environment = "CFLAGS='-g0'"

setup.py

@@ -2,51 +2,22 @@
 import sys
 from Cython.Build import cythonize
 from setuptools import Extension, setup
-from setuptools.command.build_ext import build_ext
 
 vi = sys.version_info
 if vi < (3, 9):
     raise RuntimeError('picows requires Python 3.9 or greater')
 
 
-class CustomBuildExt(build_ext):
-    def build_extensions(self):
-        for ext in self.extensions:
-            if ext.extra_compile_args:
-                ext.extra_compile_args = [
-                    flag for flag in ext.extra_compile_args if flag != '-g'
-                ]
-            if ext.extra_link_args:
-                ext.extra_link_args = [
-                    flag for flag in ext.extra_link_args if flag != '-g'
-                ]
-
-            if os.name != 'nt':
-                self.compiler.compiler_so = [
-                    flag for flag in self.compiler.compiler_so if flag != '-g'
-                ]
-                self.compiler.linker_so = [
-                    flag for flag in self.compiler.linker_so if flag != '-g'
-                ]
-        super().build_extensions()
-
-
 if os.name == 'nt':
-    compile_args = ["/O2", "/DNDEBUG"]
-    link_args = []
     libraries = ["Ws2_32"]
 else:
-    compile_args = ["-O2", "-Wall", "-DNDEBUG", "-fno-strict-overflow", "-Wsign-compare", "-fPIC"]
-    link_args = ["-Wl,-s"]
     libraries = None
 
 cython_modules = [
     Extension(
         "picows.picows",
         ["picows/picows.pyx"],
         libraries=libraries,
-        extra_compile_args=compile_args,
-        extra_link_args=link_args,
     )
 ]
 
@@ -55,13 +26,10 @@ def build_extensions(self):
         Extension(
             "examples.echo_client_cython",
             ["examples/echo_client_cython.pyx"],
-            extra_compile_args=compile_args,
-            extra_link_args=link_args,
         )
     )
 
 setup(
-    cmdclass={'build_ext': CustomBuildExt},
     ext_modules=cythonize(
         cython_modules,
         compiler_directives={