Handle empty Bullish ticker messages

Author: thaaddeus

src/mappers/bullish.ts

@@ -123,8 +123,9 @@ export class BullishDerivativeTickerMapper implements Mapper<'bullish', Derivati
 
     if (message.dataType === 'V1TATickerResponse' && (message.type === 'snapshot' || message.type === 'update')) {
       const tickerMessage = message as BullishTickerMessage
+      const symbol = tickerMessage.data?.symbol
 
-      return tickerMessage.data.symbol.endsWith('-PERP') || /-\d{8}$/.test(tickerMessage.data.symbol)
+      return symbol !== undefined && (symbol.endsWith('-PERP') || /-\d{8}$/.test(symbol))
     }
 
     return false
@@ -183,8 +184,9 @@ export class BullishOptionSummaryMapper implements Mapper<'bullish', OptionSumma
 
     if (message.dataType === 'V1TATickerResponse' && (message.type === 'snapshot' || message.type === 'update')) {
       const tickerMessage = message as BullishTickerMessage
+      const symbol = tickerMessage.data?.symbol
 
-      return tickerMessage.data.symbol.endsWith('-C') || tickerMessage.data.symbol.endsWith('-P')
+      return symbol !== undefined && (symbol.endsWith('-C') || symbol.endsWith('-P'))
     }
 
     return false
@@ -263,7 +265,7 @@ type BullishMessageRole = 'snapshot' | 'update'
 type BullishAnonymousTradeUpdateMessage = BullishDataMessage<'V1TAAnonymousTradeUpdate', BullishAnonymousTradeUpdateData>
 type BullishLevel2Message = BullishDataMessage<'V1TALevel2', BullishLevel2Data>
 type BullishLevel1Message = BullishDataMessage<'V1TALevel1', BullishLevel1Data>
-type BullishTickerMessage = BullishDataMessage<'V1TATickerResponse', BullishTickerData>
+type BullishTickerMessage = BullishDataMessage<'V1TATickerResponse', BullishTickerData | null>
 type BullishDerivativeTickerMessage = BullishDataMessage<'V1TATickerResponse', BullishDerivativeTickerData>
 type BullishOptionTickerMessage = BullishDataMessage<'V1TATickerResponse', BullishOptionTickerData>
 type BullishIndexPriceMessage = BullishDataMessage<'V1TAIndexPrice', BullishIndexPriceData>

test/__snapshots__/mappers.test.ts.snap

@@ -979,6 +979,8 @@ exports[`map bullish derivative ticker messages 8`] = `[]`;
 
 exports[`map bullish derivative ticker messages 9`] = `[]`;
 
+exports[`map bullish derivative ticker messages 10`] = `[]`;
+
 exports[`map bullish option summary messages 1`] = `
 [
   {
@@ -1100,6 +1102,8 @@ exports[`map bullish option summary messages 7`] = `[]`;
 
 exports[`map bullish option summary messages 8`] = `[]`;
 
+exports[`map bullish option summary messages 9`] = `[]`;
+
 exports[`map bullish order book messages 1`] = `
 [
   {

test/mappers.test.ts

@@ -10334,6 +10334,12 @@ test('map bullish derivative ticker messages', () => {
         createdAtDatetime: '2026-04-24T14:58:45.522Z',
         otcBaseVolume: '0.00000000'
       }
+    },
+    // Bullish can publish empty ticker updates; they should be ignored by derivative ticker mapper
+    {
+      type: 'update',
+      dataType: 'V1TATickerResponse',
+      data: null
     }
   ]
 
@@ -10536,6 +10542,12 @@ test('map bullish option summary messages', () => {
         openInterestUSD: '50507926.2656',
         otcBaseVolume: '92.17200000'
       }
+    },
+    // Bullish can publish empty ticker updates; they should be ignored by option summary mapper
+    {
+      type: 'update',
+      dataType: 'V1TATickerResponse',
+      data: null
     }
   ]